Received-SPF: pass (google.com: domain of linux-kernel+bounces-70913-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <64955b50602fc64e2d3c7d4a92a1f9459e8c7ead.1708120036.git.mirq-linux@rere.qmqm.pl>
In-Reply-To: <64955b50602fc64e2d3c7d4a92a1f9459e8c7ead.1708120036.git.mirq-linux@rere.qmqm.pl>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Mon, 19 Feb 2024 09:13:44 +0100
Message-ID: <CAKfTPtAvcRvdHQ2OY4cej26dXt_y5LbtYh=OGWxfbQunh-Juww@mail.gmail.com>
Subject: Re: [PATCH 1/2] sched/topology: loop properly when clearing flags
To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, 
	Juri Lelli <juri.lelli@redhat.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>, 
	Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, 
	Daniel Bristot de Oliveira <bristot@redhat.com>, Valentin Schneider <vschneid@redhat.com>, 
	Len Brown <len.brown@intel.com>, "Joel Fernandes (Google)" <joel@joelfernandes.org>, 
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 16 Feb 2024 at 22:55, Micha=C5=82 Miros=C5=82aw <mirq-linux@rere.qm=
qm.pl> wrote:
>
> Fixed commit introduced sched_group::flags and a loop that was supposed
> to clear groups' flags if the child sched_domain was deleted.  The
> iterating part was missing.
>
> Fixes: 16d364ba6ef2 ("sched/topology: Introduce sched_group::flags")
> Signed-off-by: Micha=C5=82 Miros=C5=82aw <mirq-linux@rere.qmqm.pl>
> ---
>  kernel/sched/topology.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 10d1391e7416..75b1a18783c2 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -767,6 +767,7 @@ cpu_attach_domain(struct sched_domain *sd, struct roo=
t_domain *rd, int cpu)
>                          */
>                         do {
>                                 sg->flags =3D 0;
> +                               sg =3D sg->next;
>                         } while (sg !=3D sd->groups);

This has been discussed here
https://lore.kernel.org/all/20230523105935.GN83892@hirez.programming.kicks-=
ass.net/T/#m0881c3e17954dc6e23f81216873e721f8395e554

and here
https://lore.kernel.org/lkml/20230617081926.2035113-1-linmiaohe@huawei.com/

and the right solution would be to remove the while loop but  for
whatever the reason, this has never been resend with an updated commit
message

>
>                         sd->child =3D NULL;
> --
> 2.39.2
>