Received-SPF: pass (google.com: domain of linux-kernel+bounces-70936-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 19 Feb 2024 09:31:55 +0100
Message-ID: <874je4q2h0.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Hans Peter <flurry123@gmx.ch>
Cc: tiwai@suse.com,
	linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP 840 G8 (MB 8AB8)
In-Reply-To: <a170992c-2acf-42f9-9dcc-b5dae5fffa67@gmx.ch>
References: <a170992c-2acf-42f9-9dcc-b5dae5fffa67@gmx.ch>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Sun, 18 Feb 2024 13:16:03 +0100,
Hans Peter wrote:
> 
> The HP EliteBook 840 G8 seems to be circulating with different
> subsystem-IDs. alsa-info.sh showed on my box:
> 
> !!DMI Information
> !!---------------
> 
> Manufacturer:      HP
> Product Name:      HP EliteBook 840 G8 Notebook PC
> Product Version:   SBKPF
> Firmware Version:  T37 Ver. 01.15.02
> System SKU:        5S7R6EC#ABD
> Board Vendor:      HP
> Board Name:        8AB8
> 
> ...
> 
> !!HDA-Intel Codec information
> !!---------------------------
> --startcollapse--
> 
> Codec: Realtek ALC285
> Address: 0
> AFG Function Id: 0x1 (unsol 1)
> Vendor Id: 0x10ec0285
> Subsystem Id: 0x103c8ab9
> Revision Id: 0x100002
> 
> 
> So an additional quirk enabled mute led for me:
> 
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9752,6 +9752,7 @@
>  	SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)",
> ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)",
> ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8aab, "HP EliteBook 650 G9 (MB 8AA9)",
> ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8ab9, "HP EliteBook 840 G8 (MB 8AB8)",
> ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9",
> ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook
> PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook
> PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),

Could you repost a proper patch with your Signed-off-by tag?  It's a
legal requirement.  See Documentation/process/submitting-patches.rst
for details.

Also the information of your device could be a bit more concise.

Last but not least, the patch doesn't seem cleanly applicable.  Your
mailer seems breaking the lines.  Please fix your setup, or use
git-send-email to resubmit.


thanks,

Takashi