Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1010506rdb; Mon, 19 Feb 2024 00:51:22 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWIx4Arod2Psu1oajgRgtHVChRRA/dZ053WyQzI2jm5Q0NUHzKlN+Juim3qW1AAChmgZbSbMDx15KUkRS/HCwJpIeqf3KAh3lKzGWSqNA== X-Google-Smtp-Source: AGHT+IF41lHo1naI1rEwdL8cwDYfDV8Ev7Ak73wVaZVr2OfASSj79CPfCa2DsbYHXb7LH3/uisVb X-Received: by 2002:a05:6808:190e:b0:3c0:3bd9:136 with SMTP id bf14-20020a056808190e00b003c03bd90136mr15841846oib.24.1708332681780; Mon, 19 Feb 2024 00:51:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708332681; cv=pass; d=google.com; s=arc-20160816; b=sPKYwahcU6PkaB3TNYgJ9IZeSygUmnIvdDb4YSLte+u2BcIOb5Yx5g7Bfv7emwBAfq HhfOh3cAw039Bg7sKVu2q5g+TIJwMarFyg00YWlON+pQugYc0rh0WscfxgooTYE20OQj zqNebulSNVfdrdK70cFdpfrXDJ3OBU4N/PAlEBwTHfUNmnXJduWfkYruAepvIumu0evs FALc8bkHxEvfbfPVJo6Z1dONLXJONQ5h6jrgB56pT+wudxb71gFI3NQUX1IiweZpgCB/ 3Q9Cxm105o/DQpYvfdJgXIxZQ8x3uUEhiposeBqPQZ1U6r8FhfLpUAccV2t2wNnILbA5 y5Dg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=JrPQnhq+uifNDW6L1wLQ8gkUjpW0jaBliebCRq9SQQ4=; fh=IHuBnUBCWIA8KhpUAGFAXQh3gbKR3FS+jzmD2Z14MXo=; b=GTMAGMvLmaYDYK2iw5bNYeojlwhCHJ6dVNsXLkZCWXAryTIf8cPJ7FlH+uT+DHkgsQ Ccpu4iaqY+70nfXTDMmgbo4aRhnOb077yxgf1y7XetFM/CPTfZtVGsbrlonf8+0IZMQX 6meNHWNZLDglLVSKBd78VyJXJwKFUocwh6Gi250Qdpac1u7WiucU6IiMVpDv0U88LMWL DQ/0VBZWUA8/77vJ3ADs/u2GNk6ZWq5ErsFAjkkLubM1sMhVpoYeWdQpUNrNq9br8Cd6 u1WRABKU+wy4AU3s4JfHVVrsLWrFsRTfyqrzbNSy9hflzUER9gmY8zPTuy0qz5TAGQV5 yIXA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OLHxIk+y; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-70968-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70968-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b190-20020a6334c7000000b005dc14cf6b6dsi4088083pga.155.2024.02.19.00.51.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 00:51:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70968-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OLHxIk+y; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-70968-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70968-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 78FCC281E0F for ; Mon, 19 Feb 2024 08:51:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5FF70224EC; Mon, 19 Feb 2024 08:51:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OLHxIk+y" Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF57F224CC for ; Mon, 19 Feb 2024 08:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708332677; cv=none; b=O5NPyiia9ginROV0A0pFagQ3UzDWwaCoLFzVZB72fve1RUex1OvEl3F2JVc0PC1NpK/WK7imKLwWmfPptVy5a91jfvHEN+AWWOdmQ7Ki/AwZfdjDZ91wmwGvmoqw8ZepefKASPKa9psBY3bxO0X81x1syo7/FiyQCJFzYonvaUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708332677; c=relaxed/simple; bh=8eKREEc7F0lAf3GTw+lhnrYpcGZiLLA3+AD1RWpjJ1c=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=Nebw9WCsKgyPg3N2jtWyWhWipO5/VMAzpHd0fGihXucSi1Y17JuDDc+rCR7SL6R+kgk7mdWRUQoU946+1Xg73qcwswXMUyOt1LP2qypUXRMyT2gLZMVO5seGq9HWQBGoHaqFm2a4JAtSWR5vRvhj8MO//5KMUPdBge8Y8JJCZfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OLHxIk+y; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-512b4388dafso575118e87.2 for ; Mon, 19 Feb 2024 00:51:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708332674; x=1708937474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JrPQnhq+uifNDW6L1wLQ8gkUjpW0jaBliebCRq9SQQ4=; b=OLHxIk+yc6lty6vaK7xRBijROLZUE4tKD98qDYRgxk8GsjMsUQaAqwpv9kcGzqQ6K/ HK3Mz3RZ18YyEG9EgENJWY1UFKEgwLmtmWNiY+okmcjMgoLceqThELAlB6d01dj0j1yq 50ZMMdFDNR13o9c7yyQkB9dGz9pbe3CcYGVD7ap5XyjSSbfdhZmfJZ2l7amoKiBRxwsP xr8JiWHxE9ADz4YbdBicIX6vEioFYDUISSZP3xavw8Ak+EtBlRgw35/+1kPS/+48xk86 2OaCzzMQOrpQq2ZD+lhyxTirTqW2zqgLikmm8AWxXwvkyoPa3hJTOEWv09JBxrpIkfmz +Riw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708332674; x=1708937474; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JrPQnhq+uifNDW6L1wLQ8gkUjpW0jaBliebCRq9SQQ4=; b=Q1fYp5OyLXsP0Dq6DjR+Bcwsy7vpvQuVhxsCfSm/Hd3z6diFZ2au2pGOjMcTAcPIzR 5dmOEy6BZO59x7kKoQvb0b1ssNj8Pp3pMO+wJo4tASNbYBYa7u+Bj36LVP3IQDcdNS19 IG0RkqJ/LOF7OS0aFtDcPU9dcoKLYEYJ9uJKdkpRVQC7wQkr/ZRhq4/jnj3M4xnBJa+B 57vpOdJUDhpUrNVGo83kpOopNCXc7gO/b60NcQ6ajeFMJTpu+gbc3FeTYkaBezriZWWr UWnBfO+Vz6YBnk5X9tvGcO9NATiIbQuXWOwEViimuMM3eoqlDnAySzsOrqOQvjinlx/m WrsQ== X-Forwarded-Encrypted: i=1; AJvYcCXTHjpjEw9ea5WyWpV6BBxJAduCwG8uW879oBZ23M1Sr3UsdP7Ozpir544npR2J2OZKvnhHDmR/Mbq1vedGRDQ4wae7zLTs9/tMQpno X-Gm-Message-State: AOJu0YyyoDUSlEc6uwwH9epa/vSzJBMoLxN8LuCVJv0QjotJtJrBmKOT HZAYCINTRBc5/6MHj+sWGe/fXkHYXZoyXW8PItIrSdEitEHCiv1vGec1a9e0YQg= X-Received: by 2002:a05:6512:2150:b0:512:be4c:b53a with SMTP id s16-20020a056512215000b00512be4cb53amr39287lfr.3.1708332673938; Mon, 19 Feb 2024 00:51:13 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id p11-20020a05600c1d8b00b004126a0dfd11sm409187wms.29.2024.02.19.00.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 00:51:13 -0800 (PST) From: Neil Armstrong To: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, Martin Blumenstingl Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20240218175035.1948165-1-martin.blumenstingl@googlemail.com> References: <20240218175035.1948165-1-martin.blumenstingl@googlemail.com> Subject: Re: [PATCH v1] drm/meson: improve encoder probe / initialization error handling Message-Id: <170833267304.1737509.12815192021500266320.b4-ty@linaro.org> Date: Mon, 19 Feb 2024 09:51:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.4 Hi, On Sun, 18 Feb 2024 18:50:35 +0100, Martin Blumenstingl wrote: > Rename meson_encoder_{cvbs,dsi,hdmi}_init() to > meson_encoder_{cvbs,dsi,hdmi}_probe() so it's clear that these functions > are used at probe time during driver initialization. Also switch all > error prints inside those functions to use dev_err_probe() for > consistency. > > This makes the code more straight forward to read and makes the error > prints within those functions consistent (by logging all -EPROBE_DEFER > with dev_dbg(), while actual errors are logged with dev_err() and get > the error value printed). > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/meson: improve encoder probe / initialization error handling https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1a9e51bef89af0f0976cf4c83a1e682895695dcf -- Neil