Received-SPF: pass (google.com: domain of linux-kernel+bounces-71012-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 19 Feb 2024 10:14:40 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: =?utf-8?B?6ZmI6aqP?= <chenjun102@huawei.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, xuqiang36@huawei.com
Subject: Re: [PATCH v2] irqchip/mbigen: Fix incorrect null pointer check
Message-ID: <2024021928-engulf-diffusive-d451@gregkh>
References: <20240219085314.85363-1-chenjun102@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240219085314.85363-1-chenjun102@huawei.com>

On Mon, Feb 19, 2024 at 04:53:14PM +0800, 陈骏 wrote:
> From: Chen Jun <chenjun102@huawei.com>
> 
> bus_get_dev_root returns sp->dev_root set in subsys_register.
> And subsys_register is not called by platform_bus_init.
> 
> For platform_bus_type, bus_get_dev_root always returns NULL.
> This makes mbigen_of_create_domain always return -ENODEV.
> 
> Fixes: fea087fc291b ("irqchip/mbigen: move to use bus_get_dev_root()")
> Signed-off-by: Chen Jun <chenjun102@huawei.com>
> ---


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot