Received-SPF: pass (google.com: domain of linux-kernel+bounces-71047-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <2083520a-13f3-0ecd-45ce-ee4ba34d5bca@collabora.com>
Date: Mon, 19 Feb 2024 15:09:30 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3 3/9] drm/ci: mediatek: Add job to test panfrost and
 powervr GPU driver
Content-Language: en-US
To: Helen Koike <helen.koike@collabora.com>, dri-devel@lists.freedesktop.org
Cc: daniel@fooishbar.org, airlied@gmail.com, daniel@ffwll.ch,
 david.heidelberg@collabora.com, guilherme.gallo@collabora.com,
 sergi.blanch.torne@collabora.com, robdclark@gmail.com,
 linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-amlogic@lists.infradead.org, amd-gfx@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <20240130150340.687871-1-vignesh.raman@collabora.com>
 <20240130150340.687871-4-vignesh.raman@collabora.com>
 <61575073-ce37-4027-8f95-f05290cc10c4@collabora.com>
From: Vignesh Raman <vignesh.raman@collabora.com>
In-Reply-To: <61575073-ce37-4027-8f95-f05290cc10c4@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Helen,

On 09/02/24 23:51, Helen Koike wrote:
> 
> 
> On 30/01/2024 12:03, Vignesh Raman wrote:
>> For mediatek mt8173, the GPU driver is powervr and for mediatek
>> mt8183, the GPU driver is panfrost. So add support in drm-ci to
>> test panfrost and powervr GPU driver for mediatek SOCs and update
>> xfails. Powervr driver was merged in linux kernel, but there's no
>> mediatek support yet. So disable the mt8173-gpu job which uses
>> powervr driver.
>>
>> Add panfrost specific tests to testlist and skip KMS tests for
>> panfrost driver since it is not a not a KMS driver. Also update
>> the MAINTAINERS file to include xfails for panfrost driver.
>>
>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> 
> Hi Vignesh, thanks for your work.
> 
> I'm still wondering about a few things, please check below.
> 
>> ---
>>
>> v2:
>>    - Add panfrost and PVR GPU jobs for mediatek SOC with new xfails, 
>> add xfail
>>      entry to MAINTAINERS.
> 
> Maybe we should review how the xfails failes are named. I think they 
> should start with the DRIVER_NAME instead of GPU_VERSION.
> 
> For instance, consider the following job:
> 
> mediatek:mt8183-gpu:
>    extends:
>      - .mt8183
>    variables:
>      GPU_VERSION: mediatek-mt8183-gpu
>      DRIVER_NAME: panfrost
> 
> And we have mediatek-mt8183-gpu-skips.txt
> 
> If there is an error, we want to notify the panfrost driver maintainers 
> (and maybe not the mediatek driver maintainers), so MAINTAINERS file 
> doesn't correspond to this.

Agree.

> 
> How about a naming <driver name>_<hardware/gpu>_<type: gpu/display> ?
> 
> powervr_mediatek-mt8173_gpu-skipts.txt
> mediatek_mediatek-mt8173_display-skipts.txt
> panfrost_mediatek-mt8183_gpu-skips.txt
> mediatek_mediatek-mt8183_display-skips.txt
> ...
> 
> What do you think?

Yes we can keep this naming. In this case do we still need gpu/display 
in the xfails file name?

Regards,
Vignesh