Received-SPF: pass (google.com: domain of linux-kernel+bounces-71123-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Simon Horman <horms@kernel.org>
CC: Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann
	<daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org>, Martin KaFai Lau
	<martin.lau@linux.dev>, Song Liu <song@kernel.org>, Yonghong Song
	<yonghong.song@linux.dev>, John Fastabend <john.fastabend@gmail.com>, KP
 Singh <kpsingh@kernel.org>, Stanislav Fomichev <sdf@google.com>, Hao Luo
	<haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>, "David S. Miller"
	<davem@davemloft.net>, David Ahern <dsahern@kernel.org>, Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov
	<bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>, "x86@kernel.org"
	<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Kees Cook <keescook@chromium.org>,
	"linux-hardening @ vger . kernel . org" <linux-hardening@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Check return from set_memory_rox() and
 friends
Thread-Topic: [PATCH bpf-next] bpf: Check return from set_memory_rox() and
 friends
Thread-Index: AQHaYYt0k5q3btwWO0uxnF4OiPUcRLERdyKAgAAByoA=
Date: Mon, 19 Feb 2024 10:25:49 +0000
Message-ID: <2229a6a3-d37b-4865-a479-44df02dfa1d7@csgroup.eu>
References:
 <63322c8e8454de9b240583de58cd730bc97bb789.1708165016.git.christophe.leroy@csgroup.eu>
 <20240219101925.GW40273@kernel.org>
In-Reply-To: <20240219101925.GW40273@kernel.org>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
user-agent: Mozilla Thunderbird
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?NGpDdGhkVm9keWdXdDRWb1FiOHljdG1tRm1UYmNMWUhmSExFN3pzdER3OGJJ?=
 =?utf-8?B?RVQxQmQrZzhrL09pLzRCVnNIemlMRlJEcmNVQ3VGNmFJamxuRWcvWXpmVmw4?=
 =?utf-8?B?alNvQ2M5MmNFeFQrdk9YQnRSaWN4WDQwb3lja0granJLRGhxOHRVemExMGxF?=
 =?utf-8?B?Q2J5VHJhTmJaQzVWWCt1VTFaekw1Uzg3czROOTVNdTEvRWZCUXBVTG52VUR1?=
 =?utf-8?B?Q284Yk9EZmxzcjRzRVM2dkRiM2lNSjRhL1ZlYnRhQVdDTXh0QytVYkllMllV?=
 =?utf-8?B?RC92VkdIdHM4WlBNZmlNUHBUSFVJSUdTaXJqQTVFSnFUU3JUOWVOWFE0aDlw?=
 =?utf-8?B?WU92NEdrcHBxQ1Q0TTdFWk9pcnVhbG5yVlF3WGxySWtEK2d4ZWJCVEI1Y0Zj?=
 =?utf-8?B?YUdMOWJmUlhmUGsxNDNkWU9qUktiNHJIeTdYNE1NYTBUZTB5aGNZcFpjM2E0?=
 =?utf-8?B?QkVrTmg4L2lZMWVYYmNJVkNrb2Q0R0tPQzhuNzdvQkpycyttdWhnZWNUSzRQ?=
 =?utf-8?B?MS84Tk01TjgvQ005RkNzdFlYdGFjRmtZMmFPYnAyYUZpRHd2Z1hBU3FEZ0t3?=
 =?utf-8?B?UkRjTUlIYzNicitmcFBOcXE1TGpiQVhHWEx3TEtyaWRaZDYzRG1JWkpjZ0lB?=
 =?utf-8?B?MnB2SUxtcXhKUFdlTkJJUDN4OUdWUEx2UVZjWFlpZU9VWGNpcmRVSWx0LzUv?=
 =?utf-8?B?YlFUbDY2enkvOHdkUEw1ZGQ1WWY0RUpKZ0hZMC9lTDd4L0FVUzFsV2ZWTjBX?=
 =?utf-8?B?am83UXk2dTQ0U0hjbm9VRU05N2VUbkx3amdkMmIxRDZicVgyWHU4Sy8zQ3Vh?=
 =?utf-8?B?bk9aR3QyT1V5WG9yNUxqanZzWUozUnpuYmpCVXNmNnFXeGs2WXlIcDJMcnl4?=
 =?utf-8?B?dTJhbUQwZ3RLR2svR0F2eVR2aTVleEYzS0xFR0JIMjRRMUdnZXpUODlsa1Vw?=
 =?utf-8?B?MHcreVpxODFrUWZtbldadWRyWGoxL1QwSU81R2FxUFNUajNIRlNMdys3cWto?=
 =?utf-8?B?QWJZT0RzMjNwc2VHbTM1K1dWUDRiMnRQQlJkbGVMeEJCWjNVekVwdG84UXlZ?=
 =?utf-8?B?UXEzaFV5QU9zeU5uR0R2cTQzMHB0Zk9IcFREeXliYmZzT0VPeUJjclRab1Aw?=
 =?utf-8?B?NVozbHVBRStodWNtRFZkRGk3aDNSUW15aytTaXhRUkU5YUh3K29xY1ZTalAw?=
 =?utf-8?B?SzBUS0lpaE5GRzZNVWtBN01nTVZoTnZqRkFXb0tOYmdjR2F1Ykl0bVBLZUw1?=
 =?utf-8?B?NnRZQ3R2VTlFR1NRSE81eWMzOU1zWFVOY2hYbGFwYkd5R3d0eTJYS0djTEFq?=
 =?utf-8?B?ZFBwaE9MVzgyZm9qNm93RkFvU1VRUnVuYWpSVnJiRy9uU211a1BxTmY1UWtk?=
 =?utf-8?B?ZE9Rdk5mQVZOQlo2aDgxb0RYbzA5c0U2Z2xGZDRMeGtHTjEyTFh4eVZ4a0kw?=
 =?utf-8?B?WDBhaTlINHJKMmM4WUN6SFhOZ2VPMXZxVElIL1kzamFJZEdVVnJtK2RVOTVV?=
 =?utf-8?B?VXc0ZEt4cXVjTUNha21RTFVwUW52UzRiMTZYK052L2Vxb3Exam5NOERubHJR?=
 =?utf-8?B?alNvM2ZKbndNYzVIZjFLL0hBZ0ZGVGxCT0xUQXI1QUhOMzJpWHEyb0g2ZS9D?=
 =?utf-8?B?a0dmY3VBdUR6MHBkRDgxZkQ1VS9LYkJkS1I0dHlkbEYrVi9DSVJhUG1LdkVx?=
 =?utf-8?B?bVdGdHZxbUNERkR0MTJpOVJvZHM5WmR0UkxUUUpWOUF1NEpsYmY2VGJJcm4v?=
 =?utf-8?B?dHJ1U3A1Tk81SGpIeEF6M0ozbnV5VzJmT2djZzlrdjBqdGVrNUMyQ0pUR1E4?=
 =?utf-8?B?OWJiY0pxQ1RZMk5ScXZwTzNrMjQzSUdoNHFMTFpwMWZza3BHUnVqUEpySU1Q?=
 =?utf-8?B?RlRhYTdEcEpjYjNoZkNpd25xMnhFMndsNVBJa1k3TlZDQUtqSk51WjFvUGM2?=
 =?utf-8?B?NTVQMzNYWElTSWRSbksydUlHcGNPN0lPZldUWW5OVWlPeEg4aHVsdHhpZ1Ev?=
 =?utf-8?B?cFpNNVp2cno0T3p6WVpYQnNiRzZwTXpZR2p4RVVqRncvMGd2MHJlM3UxTXNy?=
 =?utf-8?B?ekkwSElsdmNzNHpLczdud3lURGFJRk5NbkxNTm8rRGxyZ2t3V2cvNzc4WGJo?=
 =?utf-8?Q?v1Q+YhZVU7qgyxlz23b5cNm6d?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FCA7258C29854644BF27B673C5083FCD@FRAP264.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: base64
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: csgroup.eu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: ba943d50-4599-4e42-0de8-08dc313524bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2024 10:25:49.8995
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 9914def7-b676-4fda-8815-5d49fb3b45c8
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LJAapoX6CgGJz1llVkpUEUxut4sbiplUFTKyDKofcTNHXd+sLHNZHHjroq7qk7j1If0WbTNNDGUIjQBsrOcW+DeUKFtRlNOXhY/7bDG/z2U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MR1P264MB2545

DQoNCkxlIDE5LzAyLzIwMjQgw6AgMTE6MTksIFNpbW9uIEhvcm1hbiBhIMOpY3JpdMKgOg0KPiBP
biBTYXQsIEZlYiAxNywgMjAyNCBhdCAxMToyNDowN0FNICswMTAwLCBDaHJpc3RvcGhlIExlcm95
IHdyb3RlOg0KPj4gYXJjaF9wcm90ZWN0X2JwZl90cmFtcG9saW5lKCkgYW5kIGFsbG9jX25ld19w
YWNrKCkgY2FsbA0KPj4gc2V0X21lbW9yeV9yb3goKSB3aGljaCBjYW4gZmFpbCwgbGVhZGluZyB0
byB1bnByb3RlY3RlZCBtZW1vcnkuDQo+Pg0KPj4gVGFrZSBpbnRvIGFjY291bnQgcmV0dXJuIGZy
b20gc2V0X21lbW9yeV9YWCgpIGZ1bmN0aW9ucyBhbmQgYWRkDQo+PiBfX211c3RfY2hlY2sgZmxh
ZyB0byBhcmNoX3Byb3RlY3RfYnBmX3RyYW1wb2xpbmUoKS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5
OiBDaHJpc3RvcGhlIExlcm95IDxjaHJpc3RvcGhlLmxlcm95QGNzZ3JvdXAuZXU+DQo+IA0KPiAu
Li4NCj4gDQo+PiBkaWZmIC0tZ2l0IGEva2VybmVsL2JwZi9jb3JlLmMgYi9rZXJuZWwvYnBmL2Nv
cmUuYw0KPj4gaW5kZXggZWE2ODQzYmUyNjE2Li4yM2NlMTdkYTNiZjcgMTAwNjQ0DQo+PiAtLS0g
YS9rZXJuZWwvYnBmL2NvcmUuYw0KPj4gKysrIGIva2VybmVsL2JwZi9jb3JlLmMNCj4+IEBAIC04
OTgsMjMgKzg5OCwzMCBAQCBzdGF0aWMgTElTVF9IRUFEKHBhY2tfbGlzdCk7DQo+PiAgIHN0YXRp
YyBzdHJ1Y3QgYnBmX3Byb2dfcGFjayAqYWxsb2NfbmV3X3BhY2soYnBmX2ppdF9maWxsX2hvbGVf
dCBicGZfZmlsbF9pbGxfaW5zbnMpDQo+PiAgIHsNCj4+ICAgCXN0cnVjdCBicGZfcHJvZ19wYWNr
ICpwYWNrOw0KPj4gKwlpbnQgZXJyOw0KPj4gICANCj4+ICAgCXBhY2sgPSBremFsbG9jKHN0cnVj
dF9zaXplKHBhY2ssIGJpdG1hcCwgQklUU19UT19MT05HUyhCUEZfUFJPR19DSFVOS19DT1VOVCkp
LA0KPj4gICAJCSAgICAgICBHRlBfS0VSTkVMKTsNCj4+ICAgCWlmICghcGFjaykNCj4+ICAgCQly
ZXR1cm4gTlVMTDsNCj4+ICAgCXBhY2stPnB0ciA9IGJwZl9qaXRfYWxsb2NfZXhlYyhCUEZfUFJP
R19QQUNLX1NJWkUpOw0KPj4gLQlpZiAoIXBhY2stPnB0cikgew0KPj4gLQkJa2ZyZWUocGFjayk7
DQo+PiAtCQlyZXR1cm4gTlVMTDsNCj4+IC0JfQ0KPj4gKwlpZiAoIXBhY2stPnB0cikNCj4+ICsJ
CWdvdG8gb3V0Ow0KPj4gICAJYnBmX2ZpbGxfaWxsX2luc25zKHBhY2stPnB0ciwgQlBGX1BST0df
UEFDS19TSVpFKTsNCj4+ICAgCWJpdG1hcF96ZXJvKHBhY2stPmJpdG1hcCwgQlBGX1BST0dfUEFD
S19TSVpFIC8gQlBGX1BST0dfQ0hVTktfU0laRSk7DQo+PiAgIAlsaXN0X2FkZF90YWlsKCZwYWNr
LT5saXN0LCAmcGFja19saXN0KTsNCj4gDQo+IEhpIENocmlzdG9waGUsDQo+IA0KPiBIZXJlIHBh
Y2sgaXMgYWRkZWQgdG8gcGFja19saXN0Lg0KPiANCj4+ICAgDQo+PiAgIAlzZXRfdm1fZmx1c2hf
cmVzZXRfcGVybXMocGFjay0+cHRyKTsNCj4+IC0Jc2V0X21lbW9yeV9yb3goKHVuc2lnbmVkIGxv
bmcpcGFjay0+cHRyLCBCUEZfUFJPR19QQUNLX1NJWkUgLyBQQUdFX1NJWkUpOw0KPj4gKwllcnIg
PSBzZXRfbWVtb3J5X3JveCgodW5zaWduZWQgbG9uZylwYWNrLT5wdHIsIEJQRl9QUk9HX1BBQ0tf
U0laRSAvIFBBR0VfU0laRSk7DQo+PiArCWlmIChlcnIpDQo+PiArCQlnb3RvIG91dF9mcmVlOw0K
PiANCj4gQnV0IHRoaXMgdW53aW5kIHBhdGggZG9lc24ndCBhcHBlYXIgdG8gcmVtb3ZlIHBhY2sg
Zm9ybSBwYWNrX2xpc3QuDQoNCkFoLCB0aGFua3MsDQoNCkluZGVlZCBJIHdvbmRlcmVkIGFib3V0
IGl0IGFuZCBpZ25vcmVkIGl0IGFzIEkgbWlzLXJlYWQgcGFja19saXN0IGFzIA0KcGFjay0+bGlz
dCwgdGhpbmtpbmcgaXQgd291bGQgaW1wbGljaXRlbHkgZmx5IGF3YXkgd2hlbiBkcm9waW5nIHBh
Y2suDQoNCkknbGwgc2VuZCBhIHYyIGluIGEgZmV3IGRheXMgb25jZSBtb3JlIHBlb3BsZSBoYXZl
IHJldmlld2VkIGl0Lg0KDQpDaHJpc3RvcGhlDQo=