Received-SPF: pass (google.com: domain of linux-kernel+bounces-71126-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20240212083347.10742-1-d.dulov@aladdin.ru>
References: <20240212083347.10742-1-d.dulov@aladdin.ru>
To: Daniil Dulov <d.dulov@aladdin.ru>
Cc: dhowells@redhat.com, Jeffrey E Altman <jaltman@auristor.com>,
    linux-afs@lists.infradead.org,
    Marc Dionne <marc.dionne@auristor.com>, linux-kernel@vger.kernel.org,
    lvc-project@linuxtesting.org
Subject: Re: [PATCH v2] afs: Increase buffer size in afs_update_volume_status()
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <123872.1708338493.1@warthog.procyon.org.uk>
Date: Mon, 19 Feb 2024 10:28:13 +0000
Message-ID: <123873.1708338493@warthog.procyon.org.uk>

Daniil Dulov <d.dulov@aladdin.ru> wrote:

> The max length of volume->vid value is 20 characters.
> So increase idbuf[] size up to 20 to avoid overflow.

Is that 20 including the NUL?  If not, I'd increase it to 24 (it's likely to
get rounded up to a multiple of 4 or 8 by the compiler).

David