Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1052900rdb; Mon, 19 Feb 2024 02:45:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWyKZK7p48XcCIZV9SBrLzKq8L6Dk0ukCWc992gvsTcyITnfbN4Bh/Db1c7kOsXTEzamZmV7aJerlpeLEGiwheNMdkirrOLvkUAl1+FWQ== X-Google-Smtp-Source: AGHT+IHvnZeFSTXE/xyF60t7Odz1XfTmSRWulHW6p07pxLCbqiot7VEH0k28Me1Vh8eo6JNqQ1LD X-Received: by 2002:a37:e305:0:b0:787:2017:21b2 with SMTP id y5-20020a37e305000000b00787201721b2mr12153772qki.70.1708339542185; Mon, 19 Feb 2024 02:45:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708339542; cv=pass; d=google.com; s=arc-20160816; b=DTKc5ur92dcl+k6yTkLXNxGDtorvaIY4M58wJeraNmFQD5RxIFozJFO9RYDEzod9nh 9RNF6JUdR9Ei79rHoJG+7eyur5nKdJWqoGxSIqnYYH/jeBVy3k1Rf/Vdy4XzjgK8o2Pt iomK00USJh22KHHW9c7zt4trTDf2iGgHAPbDAU7TJB4/TnFod5mTVwZMNkqv0PHoRZjd 45KgqXg7sOVOA3QK2iQTkWNMft+bq2eII3Whe5jDSgP7XfOxufy3kTYaLHcrkPMq/EV1 ORRVDs1JEgjghSXkBQP6pzESL2hkclLL1iL3/rEss9CEq8Qabu7PmVpmmyhc+/0fazwE 0E1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=BEdhFgVqP1aS1mbBLmi4PD00nQJGmWrPACKuqMSlYvo=; fh=8YsbB+eNfBnxpVPeIaBEQKgdv5MpS2ZZx51eoMnaXd8=; b=f3k4YXsB75nfaEtRPZLKldlZDFfB1qF/5YPjRXHWX9l4Dp1HkTN1zyASRg3se1Jqym Yxi1J+JyoSsWf0tK788GO2juPip1BKo/gNgaOeR5im0pFFCjgMvgPLju1MfSvgORn/a3 Ja96P/umFSw3LPghfj1bATnEnkdCeUHFIEIE8B0a3O8zgO/Z6caIVcsmf+Z7dTsEpFNP K658opS0ylPOEdewuEFncsw5ugWaKY/vpLBjcbIjcIZJTvSHujcrcyU/NYdvPbA9GA0j WTPbDhUC1OwQ5sexy6d2v6Ru/BVgpfBxQXg1u8Idss0ysZwlxBUauV7QPT6aX7f7lfsq GJDg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZIJumwB8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-71142-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71142-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m10-20020a05620a24ca00b007859f20c29fsi6622654qkn.616.2024.02.19.02.45.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 02:45:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71142-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZIJumwB8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-71142-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71142-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 014821C21B6A for ; Mon, 19 Feb 2024 10:45:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 09CDC28DD1; Mon, 19 Feb 2024 10:45:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZIJumwB8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF88E25610; Mon, 19 Feb 2024 10:45:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708339516; cv=none; b=szy/5n/Yv7RZHM2isonWBO/qewUOlZ79FXak6mdC7WSCJI2yHwUAWTmDkaGZWpAAhRmfbIcPi98u2Hnm6D/PQl4TkjA4JnBttnkGxBw5ZFg9uUzUuqtNiNNnaNF6yfPX6VHZUYhsL8cYzPHyvGZNPl0Fhz2WQ82SkTEOBNK4L4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708339516; c=relaxed/simple; bh=9QblGuBQMTRAxMtLQSmfipyT83uQRzyTThIhaJdzMpk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=f8jStiDDb8c1wz4eigDKbSz2APXDgZoQJZ8BLm9yZFORwZsh1CEWUhkm72tqHRtYbF7ktFft8xa8VKLaucRmrQ7dC1CTudOKF1qMuRN+KRtK5s0da2jq3386qHE1sRkVo7l8q8IE6H/6UQ8tNjwBr8Gn7L5C99p+ojr/iYkCrjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZIJumwB8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6987C433B2; Mon, 19 Feb 2024 10:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708339515; bh=9QblGuBQMTRAxMtLQSmfipyT83uQRzyTThIhaJdzMpk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZIJumwB8R7eqK60oBr6HKlh5JwvXfpAWD/GV6rAjoPva0gCmMfTvjmup+QgCN9W4B 4QFZq86BaQvNwDnqpmhcbkDoYbyw+ewKWzVML75MmhrGtgJTmUl6WYc/DOSQY+BmFU RTKL/R/HVPB4V10pnEU7fdcgssxA8XmmNdKGn7QQJo2eAeH2FUdqXae6/RQO5rznLi Srryh0ClDisBEIrH93xRdkt5EiuBtEIWAhYH/290R1eYJGuGSmGzOpdZw/WzuJFI20 k4H8GlizlvtQ9hAARbzFmH4zfzqtDRWHSaWA4FNqx4BdNwH6vtv4n9ZgTcY1dbTuVO gEGKgfjlmA1BA== Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-512bce554a5so341026e87.3; Mon, 19 Feb 2024 02:45:15 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVEA2eckF7jdfu5AHlDPTOX5m1R0kMQzksnMthEyfyrzKGl6nscc3fVOMIKmPaXbZSc7cpDcu9VUIRRYSOp/otRktSxTFLpAJF2dCEK234uWVNMvw5+VL84Y6iPXFpzAW5Biwf9RiRmPQ== X-Gm-Message-State: AOJu0YwZJWyrgZNJmf93SupTjzChQNAjTdS8UXQ2R+I4oYKeMfckGf1u 3EyPwIFj8nFuK+4rZJbV3hZL264YVzFcOUSjbz4Q0ta2YqKDO2pfTQAQbzm1eE2ymrYkoGxec0v ugrixA9CxxqXh/axzu9DcVxY7rTY= X-Received: by 2002:a05:6512:2150:b0:512:be4c:b532 with SMTP id s16-20020a056512215000b00512be4cb532mr211883lfr.59.1708339513934; Mon, 19 Feb 2024 02:45:13 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240213124143.1484862-13-ardb+git@google.com> <20240213124143.1484862-15-ardb+git@google.com> <20240217125102.GSZdCrtgI-DnHA8DpK@fat_crate.local> <20240219095530.GBZdMlkgf_jzDxM8XR@fat_crate.local> In-Reply-To: <20240219095530.GBZdMlkgf_jzDxM8XR@fat_crate.local> From: Ard Biesheuvel Date: Mon, 19 Feb 2024 11:45:02 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 02/11] x86/startup_64: Replace pointer fixups with RIP-relative references To: Borislav Petkov Cc: Ard Biesheuvel , linux-kernel@vger.kernel.org, Kevin Loughlin , Tom Lendacky , Dionna Glaze , Thomas Gleixner , Ingo Molnar , Dave Hansen , Andy Lutomirski , Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Justin Stitt , Kees Cook , Brian Gerst , linux-arch@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Mon, 19 Feb 2024 at 10:56, Borislav Petkov wrote: > > On Sat, Feb 17, 2024 at 05:10:27PM +0100, Ard Biesheuvel wrote: > > Maybe this is better? > > Yap, looks better. > > Btw, when you paste those diffs ontop, can pls make sure you paste them > in applicable form so that I can apply them and look at them in detail? > > gmail mangles them: > > > + > > + pgd[pgd_index(__START_KERNEL_map)] = (pgdval_t)p4d | > > _PAGE_TABLE_NOENC; > > For example, linebreak here. > Yeah, sorry about that.