Received-SPF: pass (google.com: domain of linux-kernel+bounces-71208-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Thomas Gleixner <tglx@linutronix.de>
To: Feng Tang <feng.tang@intel.com>, John Stultz <jstultz@google.com>,
 Stephen Boyd <sboyd@kernel.org>, paulmck@kernel.org, Waiman Long
 <longman@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
 linux-kernel@vger.kernel.org
Cc: Feng Tang <feng.tang@intel.com>, Jin Wang <jin1.wang@intel.com>
Subject: Re: [PATCH v3] clocksource: Scale the max retry number of watchdog
 read according to CPU numbers
In-Reply-To: <20240129134505.961208-1-feng.tang@intel.com>
References: <20240129134505.961208-1-feng.tang@intel.com>
Date: Mon, 19 Feb 2024 12:32:05 +0100
Message-ID: <87msrwadvu.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Mon, Jan 29 2024 at 21:45, Feng Tang wrote:
> +static inline long clocksource_max_watchdog_read_retries(void)
> +{
> +	long max_retries = max_cswd_read_retries;
> +
> +	if (max_cswd_read_retries <= 0) {
> +		/* santity check for user input value */
> +		if (max_cswd_read_retries != -1)
> +			pr_warn_once("max_cswd_read_retries was set with an invalid number: %ld\n",
> +				max_cswd_read_retries);
> +
> +		max_retries = ilog2(num_online_cpus()) + 1;

I'm getting tired of these knobs and the horrors behind them. Why not
simply doing the obvious:

       retries = ilog2(num_online_cpus()) + 1;

and remove the knob alltogether?

Thanks,

        tglx