Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752539AbXL1VMB (ORCPT ); Fri, 28 Dec 2007 16:12:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752234AbXL1VLu (ORCPT ); Fri, 28 Dec 2007 16:11:50 -0500 Received: from jurassic.park.msu.ru ([195.208.223.243]:60584 "EHLO jurassic.park.msu.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbXL1VLu (ORCPT ); Fri, 28 Dec 2007 16:11:50 -0500 Date: Sat, 29 Dec 2007 00:12:19 +0300 From: Ivan Kokshaysky To: Loic Prylli Cc: Arjan van de Ven , Daniel Barkalow , Linus Torvalds , Kai Ruhnau , Robert Hancock , Jeff Garzik , Linux Kernel Mailing List , gregkh@suse.de, linux-pci , Benjamin Herrenschmidt , Martin Mares , Matthew Wilcox Subject: Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in Message-ID: <20071228211219.GA10475@jurassic.park.msu.ru> References: <47742498.1060900@tragetaschen.dyndns.org> <20071228103451.GA28694@jurassic.park.msu.ru> <20071228081418.08b60228@laptopd505.fenrus.org> <20071228163841.GA9409@jurassic.park.msu.ru> <47753525.3010701@myri.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47753525.3010701@myri.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1704 Lines: 33 On Fri, Dec 28, 2007 at 12:40:53PM -0500, Loic Prylli wrote: > The only quirk I see removed is a bitmap with an arbitrary size (that we > don't really know is sufficient for every system), and that is only > built using comparison between mmconf and type1 accesses. IMHO, there > is zero knowledge in that removed code (no knowledge about specific > chipsets that work or don't work, or misleading BIOSes). Precisely. As a side note: that code also has zero knowledge about what the generic PCI probe code can do later, like it fails to detect this ATI/CRS breakage. > One thing that could be changed in pci_cfg_space_size() is to avoid > making a special case for PCI-X 266MHz/533Mhz (assume cfg_size == 256 > for such devices too, reserve extended cfg-space for pci-express > devices). There is good reasons to think no such PCI-X 266Mhz/533 device > will ever have an extended-space (no capability IDs was ever defined in > the PCI-X 2.0 spec, no new revision is planned). Such a check would > avoid the possibility of trying extended-conf-space access for PCI-X 2.0 > devices behind a amd-8132 or similar (such accesses would just returnd > -1, but there was some objections raised about doing anything like that > other than at initialization time, even if there is ample reasons to > argue it would be harmless). I agree, we should remove it. IIRC, this PCI-X check was written long ago with some draft (not a final spec) in hands. Matthew? Ivan. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/