Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1087842rdb; Mon, 19 Feb 2024 04:04:39 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV8mOOwcGdNGg8R0pWh+fOSi2xCVo/2QtAZr8jf+5LuyIQ49tnFQGvzI21tpTYJNZEc7elvLhepEyv+CJRnstZhCLn1u3afjO2xqcscbA== X-Google-Smtp-Source: AGHT+IEjCxM8IiV5lgfNs/CB2hKS7hPD54aJQVF6QtunZDImvuEtCAJ9K1WexR6tfWjmQVV64gcr X-Received: by 2002:a17:90b:f12:b0:299:5a55:ef3a with SMTP id br18-20020a17090b0f1200b002995a55ef3amr2618159pjb.4.1708344279059; Mon, 19 Feb 2024 04:04:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708344279; cv=pass; d=google.com; s=arc-20160816; b=n1rrccvYwbQhPSi0YgBtmzVcZishBMV3UglDHD08kRD+HEkVaZdpaoqGcBXikfNENc UzKxm/UIZIU5BtQ/D9Dm8bq54X1xBDD0q6glIxQCZ3r6D4iqR+NTZ8BycwPey3Rwberz IkEssWWy8VeKOG7Bse+En1t+bsu5/o5ZVVB4Yydj+8DDwHxkgaUo4SwpNmmry2zC7srx 57Wpm1lVVQ6kUbOWM1r0SzvY/iZPzi+Jd0q0tpgIr3fMBj2M9dfCowPUuGZhXdVqSN19 XmKYaffy4ESHc7QfiD9mmal/XNcvpna9YqI2uv24zm86IhT9JDvQcSvCpeTMWIQST5TF XAJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gUntlLLADUk9fOwIp7/2ak+sHS72oT6rdDnXj0smozo=; fh=dV5r3aBYxeA1lIt+13H9jJ4bTkq/fMek99VkEEep+Dk=; b=qFi5T6zCPCXySz7KrGr7KVWXjomZVOPxVGU9JHpHLPfe8EuGSFf8h1hiONCH+h2yGm b36mlAtWtKVqe4IQqiO1VQmkmUx0qYGyGdsQrycLQdqRcJPrT+LbBkVujLtZIkH3FZ+1 A1cmbb34CukIdhpnsQHjkDYhpbYUd50JqG8SUavEYDwUF+3e2VVb1EXc24ROWjiJrI/d zTGBbYPodyiYbe2W2CLqACZHrrVWL+swVQ588GfSchgXU5aDkm8/Q01Q/MQXbvDaqboT K+m13meBHC0XSzDfFimfXMLv3y7aXWctNptKqXs+JbBgY8OZI7MBLJdQgKUIX8jMrnC7 CX4A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dry4wvDx; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-71233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71233-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id j18-20020a17090ae61200b00298e4bd2269si4385902pjy.183.2024.02.19.04.04.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 04:04:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dry4wvDx; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-71233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71233-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A504AB244E1 for ; Mon, 19 Feb 2024 11:44:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 72F2F2C857; Mon, 19 Feb 2024 11:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dry4wvDx" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FBF12C19E for ; Mon, 19 Feb 2024 11:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708343067; cv=none; b=D6fAQFgyepglCqiORGBpgus1MOZ5A7O52AJD2V+lDmlMjA7wAVP7fVCG2o83AGEFMM/Q+SpNaciuCLed3xSAoiKg15vJWAWng7OVEh3I/7bFnSmgMXc8k6X3LAkGzucMXZIc4vF+5uP742rDVtwbOCCiKptljLAcXSPu5bT6C3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708343067; c=relaxed/simple; bh=gUntlLLADUk9fOwIp7/2ak+sHS72oT6rdDnXj0smozo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=csP3n2F30MLNio+kBbE09ebFZiQVFXR2EYUVH3fEFDTRwMc+eXYS6YYTRgBteivXxQkxa4QettPG2wdpiWtmcsYvAEylQ8LcRK3Y2FdRwBoXNJj7txexesrfUl5eU61qBBJ8Lw4XTw1sVR13CNE2534Oexwfn7gUMpgMhy8/W6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dry4wvDx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708343065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gUntlLLADUk9fOwIp7/2ak+sHS72oT6rdDnXj0smozo=; b=dry4wvDxtXI7dP3ln4nyKSpqlLi+nqPlKWqM8TJtqpcEcJ6hmtb0zODLGl7HhsqIbbMOe8 h7joAXnrW2IhE9J6ePfGp07lUWlVQdPDC1GfUK2HUZHJt6pTKNE/RgRwiduXUNPYzibSB7 xPYmgvaf34zWd4X82zEo3bOnnljLHOo= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-13-N0uscwNbMzGC3KfbEbLSSg-1; Mon, 19 Feb 2024 06:44:23 -0500 X-MC-Unique: N0uscwNbMzGC3KfbEbLSSg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-68f74a0a3c7so8812916d6.2 for ; Mon, 19 Feb 2024 03:44:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708343063; x=1708947863; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gUntlLLADUk9fOwIp7/2ak+sHS72oT6rdDnXj0smozo=; b=n9u2B5uh5p8pKAWSI+LToGyCm2jAsUBq2uLKxr3yCKJDomhjGIBWgxG6K1jZAAHPw8 5k9LTxe9XObMC8v1imYF3YLi1S3Igf8B8rk8DmFGGYy/+VqhoaVgRKkKtdA5ZAoVLic+ o1O7aSsWgiQISQNDTS+uDhIFQRZxQj+fgB7q3WSLDG0kn/Z0EhtmLgdc5ywHuh4cpZcF mYjwv/R7xzHt+y4wAv/ViuzGGlXxhlaH0cI9QoMF0XWTfOGdWNUleBX30KClSlNCaFcV 8CvWcQ2gk/bdAp3abS41homPZ6MBL7bk0fPeE/XdACwUxvZcJhIKAflQM4vM5Z5+e0uK gnUQ== X-Forwarded-Encrypted: i=1; AJvYcCVBCF2+QMKYjE9J6yLwzQMyizYHf19g9SoZ96TXCm4OLa0hgl5t7yTVbaBpIipnVi7HRNMyy2ElG1iSDOoeLXk1Bx1bcvJw4vB52juX X-Gm-Message-State: AOJu0Yybojf501VuK28z+nUFzKVplRLYI6iGlFggHlEBbIeDLPSKfpYZ gbxXVgH/Iw8FsXrKst9ETD3Dqm4CPxQZk5+DFSK9x+hFj9/WwxjwGcw+i8oVmS1ptfCDjfHLges L/2ytEiMgj6yI/AkK9pGS/rGRUg5XjAlkGINMWVeVOKs3ODzIMJBpeTgqxa9Dgg== X-Received: by 2002:ad4:5d69:0:b0:68f:4645:8cad with SMTP id fn9-20020ad45d69000000b0068f46458cadmr2351910qvb.57.1708343063351; Mon, 19 Feb 2024 03:44:23 -0800 (PST) X-Received: by 2002:ad4:5d69:0:b0:68f:4645:8cad with SMTP id fn9-20020ad45d69000000b0068f46458cadmr2351886qvb.57.1708343063103; Mon, 19 Feb 2024 03:44:23 -0800 (PST) Received: from debian (2a01cb058d23d600e55283140c56efd3.ipv6.abo.wanadoo.fr. [2a01:cb05:8d23:d600:e552:8314:c56:efd3]) by smtp.gmail.com with ESMTPSA id d11-20020a05621416cb00b0068d11cf887bsm3121135qvz.55.2024.02.19.03.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 03:44:22 -0800 (PST) Date: Mon, 19 Feb 2024 12:44:18 +0100 From: Guillaume Nault To: "Ricardo B. Marliere" Cc: Oliver Neukum , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Florian Fainelli , Vladimir Oltean , Roopa Prabhu , Nikolay Aleksandrov , Loic Poulain , Sergey Ryazanov , Johannes Berg , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux.dev, linux-ppp@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 05/12] net: ppp: constify the struct device_type usage Message-ID: References: <20240217-device_cleanup-net-v1-0-1eb31fb689f7@marliere.net> <20240217-device_cleanup-net-v1-5-1eb31fb689f7@marliere.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240217-device_cleanup-net-v1-5-1eb31fb689f7@marliere.net> On Sat, Feb 17, 2024 at 05:13:27PM -0300, Ricardo B. Marliere wrote: > Since commit aed65af1cc2f ("drivers: make device_type const"), the driver > core can properly handle constant struct device_type. Move the ppp_type > variable to be a constant structure as well, placing it into read-only > memory which can not be modified at runtime. Reviewed-by: Guillaume Nault