Received-SPF: pass (google.com: domain of linux-kernel+bounces-71280-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <96bb914c-79be-4867-b59d-62f80dbcdace@oracle.com>
Date: Mon, 19 Feb 2024 12:08:24 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] [v2] scsi: mpi3mr: reduce stack usage in
 mpi3mr_refresh_sas_ports()
To: Arnd Bergmann <arnd@kernel.org>,
        Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
        Kashyap Desai <kashyap.desai@broadcom.com>,
        Sumit Saxena <sumit.saxena@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
        Johannes Thumshirn <johannes.thumshirn@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Ranjan Kumar <ranjan.kumar@broadcom.com>,
        Tomas Henzl <thenzl@redhat.com>,
        Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
        mpi3mr-linuxdrv.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20240123130754.2011469-1-arnd@kernel.org>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240123130754.2011469-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Q2tIUGxQYjl0cFc1TDVKWDFtRVFMQVRFaDVaM1Z5WW5QV2xqYWV3dXJhNldD?=
 =?utf-8?B?bEgyZXNtMVlSVy9acGY1TGFpOXZDc1BBZ3lJMCtvVFNlMUhPVVBBMDBhUGdr?=
 =?utf-8?B?NmlIS2FYeTVDM1FzYUxBU1RLM2lUZ2h5ZFdKcmRCbk1CZ3g5MTJyOGx2YjJF?=
 =?utf-8?B?R3N3ZkxUdi9tY2VZV2pJdXJLc3RhSzEya2hoZng3cDNRQ1ZuODVheHl2a3A5?=
 =?utf-8?B?V25yWktseVZVMExmcXBsU2psbFMyTGdqZEh4RHZacjJsVGZKTDMyT1Y4cGxo?=
 =?utf-8?B?aDRtdVVtSTd2NEhOVVFOUlBMNHp4OEZ5VVdxV1BaNHF1bzA3QkttRGRpMTVB?=
 =?utf-8?B?amcxSzhEVENUT2Z6NGR6WVpKb1MxS3U5VGZjdUt5TjNrWWlEd1Zzb1NWRkU2?=
 =?utf-8?B?QkdrVnpNQmthZFFoYVpCRUdDZHpIZmU5a2lnSXpjM3FEclJHdktyaGlsbUN5?=
 =?utf-8?B?bWVvR1dtUjN0dTRIOFY1ZFFUaGNPbzVBamZ3b0hUdWtOWkM0TDVEa2ZlaWEr?=
 =?utf-8?B?ODVGeVV2cVl4Vld6dmd3ejZGaUU4UW8zYnlxTVVDZ2Z1cmc2U3VNd0lBbmkz?=
 =?utf-8?B?VzFSVVA0aytqdFpuQkxmZ1l5YWdTcVJpeTJDQ0R2NU1kOEIyRkFhb1JkZ1kz?=
 =?utf-8?B?elFkcTBERklLNFlDUFFzVFRnaUU5bklQZEJPa0J4bXNPb21YeE9BM3VEYTFV?=
 =?utf-8?B?Z2VPVVdqM0xNR1F2ODBTSDdwYytCTXBXaGZZeU9yM0ZXOFdDMlhqOHpwNGVn?=
 =?utf-8?B?V21vT0NpOC8yaUpQMU92Tk50cTZ2VXZHdGpQSFI3NzZJOEpjUWxqdTd3bnNm?=
 =?utf-8?B?MUNiQ3NTN0pKUU5XdmJCUTh5clhDa3E3VG5jOU8zWDFrZ0dITEVSMWgyMU9P?=
 =?utf-8?B?Z2xMMDhqOXlrcjBzemVpRWhDQVlqc2w3V1B0UDZlVHdKZDhFMUVTemlwdnV6?=
 =?utf-8?B?MGRzaGlQb09BTTBiQ2t4QlRPbVQrMEhWUFh3Y2J5aHNwZzNQQjhDQW15d3ZU?=
 =?utf-8?B?cmk1SEZzcGVBVktnSmkvd3JSMTdNVjF2UWJ2dWtxV3g4Sm5KU0RtdkppNlU5?=
 =?utf-8?B?ZHRnQlRTZmI5U013VnhvOWhyS1JWR2lGRzdIVEUxMERuVlRVaUl2U2dJR3la?=
 =?utf-8?B?RjJsWnQ5NW5WbXdLL0d5eFVVZlJIUWgxMFBadExtZkhibEh5VGNrb241OEdj?=
 =?utf-8?B?UFJLa2tRR2tJTUlZVkh4c08rb3VQYkZvZS8yTjc3bktmWWNibzVxNVFVV2hz?=
 =?utf-8?B?eDZWajYrLzhabFRiMlFJN2RMT1BiTmNEcEFBdTdpT1lNeXNkekRJUnpqbm5P?=
 =?utf-8?B?VHNOTFF6R1c3L1JqRHVBbGtjak9qYVJiYUsvMUpKT2ZiRkNKdVltWURsNmhl?=
 =?utf-8?B?TEVxRnFKN1M5aXlrQXdBMjl5SDBlbEFtd0x0V1BQb2c0Sm9yVjd1SGJTSVNE?=
 =?utf-8?B?c0NYU2U5Y2cxcUZrOTBhbWo0YWxFZUpYM05ETnB5MUxkNjJZVFBpZGlVckli?=
 =?utf-8?B?cFZoMHJyZGVwYVpVWWpmUnBBY2xyVDBscFlOMzRRZHBLQzhTcmpBa3ZYNGdz?=
 =?utf-8?B?ZmlqVWw1ejNsSHZVWDA4OVIxUEl5WnVYdVdVYitENll6MFoyNkE0dmdWbTVy?=
 =?utf-8?B?VnI5aUpNQzFZaXkrWTBvaytlaEppUzQyZVZQNk5naVpmUkpOVTVqWXVCZjZZ?=
 =?utf-8?B?V1pMbmEvZmxtTnhQRmM3Q0diZ1hoVG4vanVVN0NwdVMySWNxNnZvRDNSRkkw?=
 =?utf-8?B?VkJENndMRlN2SjdjSVV1OUpvbUF5RkVBSFpFamZLYXB1ejFKbWVjYytid2xG?=
 =?utf-8?B?SGFsRGxST1AzdEd6aElIQnpYRkhnNHRscitoQjBRV000QUJGc1pOWndjSzNm?=
 =?utf-8?B?eGIxaEdMM0l0aitDeWE0STAvbkRSQ0lVOGtXRmlSWkVPUFlsOXo2MlUyY1pO?=
 =?utf-8?B?UGlpWTBOYWd0dU9XcUFOeHN3KzJ0TGxmMUtmOG1nOGc2UFJ2bnZEOHBZQmdI?=
 =?utf-8?B?MmhFWk9ReElLVHh0RWN4aVRURzFWR1Bxd2pBSXpweHRwT0lkdlhKTDNxK2xH?=
 =?utf-8?B?VFNFK1RadGlLakwzRmJDRVRxVXBCaDdXZ2pYaGJIcmZITlFod2l3ZzRKV3Jm?=
 =?utf-8?B?YTFYNGtSakYrNUx0V21DV1BneHkwbFJESVd6eG93RVpMa05DTEc3aUFRNkgx?=
 =?utf-8?B?MHc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Cm6bjyPwrq/JYMaQZSoBFMlYRGR06EvpDMGApU0UqPAGuA2fy3RJXFgrGiliJQaQuLaf30GXTVWCXehLrnktZT1ZXjtal0KLcvcLGJXx9K/YEbqEvYe0AeblN4ULhHzTVe+Ebt6VAwKGdmievzyti8pm+X8putHt34M51+VIZRTqNFc2SiqtpQullXjB3HjAXRIW4WoUtG0hn6kml9uVmEcXS3OlucaGenkxQatXthuHxkos8L6WNDYCu2BjyvIDIRdjiibGu0yJFT/v4acjcHEQTnnUaJR6hJvz3dgf8hnGuNgJGeqZxo0YX2HsQ2jaseeyFkIGy/XHR5dNiYGStMdV29lFTfNEzwHZkWpNu25uuwFrHofS2gmD3z46jFAqLQn2TmP9tkXHr096uGcd1W/3UVkySULWX1HTIAL9R8iCG/dgT84FaDsDBDX21dE6jtQTAY9zlaNOKW7D0XEhjNtgl/FMZPTy2r4KkqL1ok+9TaNk0iOPSLcY7GhmcnXULbA/mm4B7pdtgn8ELNJLhmDJAXnNgBcUg5oAfCasH3k++DLq/JdJ6HXF/iydlx8gB5lrJG78mmQTO1hcjn6rP6YCRvwBfx/o+dBZB+14fKg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48700eed-184d-4bd6-827d-08dc31437be0
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 12:08:29.2776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kfe5cUOKAAIXQJ7U50w8+PyZFAqtH8Hge6Z9rMTlbu7Ui51qFiODlelIhwW8t10nJ+t+D7LW6Sv7HeS6jKH2eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6883
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-19_08,2024-02-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402190091
X-Proofpoint-GUID: ZdeYyIJYv24-mMBt5s8KyKWfSnxOfxDn
X-Proofpoint-ORIG-GUID: ZdeYyIJYv24-mMBt5s8KyKWfSnxOfxDn

On 23/01/2024 13:07, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Doubling the number of PHYs also doubled the stack usage of this function,
> exceeding the 32-bit limit of 1024 bytes:
> 
> drivers/scsi/mpi3mr/mpi3mr_transport.c: In function 'mpi3mr_refresh_sas_ports':
> drivers/scsi/mpi3mr/mpi3mr_transport.c:1818:1: error: the frame size of 1636 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 
> Since the sas_io_unit_pg0 structure is already allocated dynamically, use
> the same method here. The size of the allocation can be smaller based on the
> actual number of phys now, so use this as an upper bound.
> 
> Fixes: cb5b60894602 ("scsi: mpi3mr: Increase maximum number of PHYs to 64 from 32")
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Cc: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Has this patch been missed?

I have this same build issue for i386 allmodconfig on v6.8-rc5 and earlier

Tested-by: John Garry <john.g.garry@oracle.com> #build only