Received-SPF: pass (google.com: domain of linux-kernel+bounces-71368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>
To: Samuel Holland <samuel.holland@sifive.com>, Palmer Dabbelt
 <palmer@dabbelt.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Samuel
 Holland <samuel.holland@sifive.com>
Subject: Re: [PATCH 4/7] riscv: Simplify text patching loops
In-Reply-To: <20240212025529.1971876-5-samuel.holland@sifive.com>
References: <20240212025529.1971876-1-samuel.holland@sifive.com>
 <20240212025529.1971876-5-samuel.holland@sifive.com>
Date: Mon, 19 Feb 2024 14:03:18 +0100
Message-ID: <874je4fvxl.fsf@all.your.base.are.belong.to.us>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Samuel Holland <samuel.holland@sifive.com> writes:

> This reduces the number of variables and makes the code easier to parse.
>
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
> ---
>
>  arch/riscv/kernel/patch.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/arch/riscv/kernel/patch.c b/arch/riscv/kernel/patch.c
> index bccd9ed04a05..7f030b46eae5 100644
> --- a/arch/riscv/kernel/patch.c
> +++ b/arch/riscv/kernel/patch.c
> @@ -155,7 +155,6 @@ NOKPROBE_SYMBOL(__patch_insn_write);
>=20=20
>  static int patch_insn_set(void *addr, u8 c, size_t len)
>  {
> -	size_t patched =3D 0;
>  	size_t size;
>  	int ret =3D 0;
>=20=20
> @@ -163,11 +162,12 @@ static int patch_insn_set(void *addr, u8 c, size_t =
len)
>  	 * __patch_insn_set() can only work on 2 pages at a time so call it in a
>  	 * loop with len <=3D 2 * PAGE_SIZE.
>  	 */
> -	while (patched < len && !ret) {
> -		size =3D min_t(size_t, PAGE_SIZE * 2 - offset_in_page(addr + patched),=
 len - patched);
> -		ret =3D __patch_insn_set(addr + patched, c, size);
> +	while (len && !ret) {
> +		size =3D min_t(size_t, PAGE_SIZE * 2 - offset_in_page(addr), len);
> +		ret =3D __patch_insn_set(addr, c, size);

While you're at it, do:
  ret =3D __patch_insn_set(addr, c, size);
  if (ret)
          return ret;
  ...
return 0;
}

and simplify the while-loop predicate?

>=20=20
> -		patched +=3D size;
> +		addr +=3D size;
> +		len -=3D size;
>  	}
>=20=20
>  	return ret;
> @@ -190,7 +190,6 @@ NOKPROBE_SYMBOL(patch_text_set_nosync);
>=20=20
>  int patch_insn_write(void *addr, const void *insn, size_t len)
>  {
> -	size_t patched =3D 0;
>  	size_t size;
>  	int ret =3D 0;
>=20=20
> @@ -198,11 +197,13 @@ int patch_insn_write(void *addr, const void *insn, =
size_t len)
>  	 * Copy the instructions to the destination address, two pages at a time
>  	 * because __patch_insn_write() can only handle len <=3D 2 * PAGE_SIZE.
>  	 */
> -	while (patched < len && !ret) {
> -		size =3D min_t(size_t, PAGE_SIZE * 2 - offset_in_page(addr + patched),=
 len - patched);
> -		ret =3D __patch_insn_write(addr + patched, insn + patched, size);
> +	while (len && !ret) {
> +		size =3D min_t(size_t, PAGE_SIZE * 2 - offset_in_page(addr), len);
> +		ret =3D __patch_insn_write(addr, insn, size);

Same comment as above.


Bj=C3=B6rn