Received-SPF: pass (google.com: domain of linux-kernel+bounces-71371-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: John Garry <john.g.garry@oracle.com>
To: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com,
        jack@suse.cz
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ojaswin@linux.ibm.com, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com, ritesh.list@gmail.com,
        Prasad Singamsetty <prasad.singamsetty@oracle.com>,
        John Garry <john.g.garry@oracle.com>
Subject: [PATCH v4 04/11] fs: Add initial atomic write support info to statx
Date: Mon, 19 Feb 2024 13:01:02 +0000
Message-Id: <20240219130109.341523-5-john.g.garry@oracle.com>
In-Reply-To: <20240219130109.341523-1-john.g.garry@oracle.com>
References: <20240219130109.341523-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?S4zbKl4B3bPlhk5iYW4EL7U1PuYh2mpuDHWpRffi3hN7pCf4tw0/EMe34ZeH?=
 =?us-ascii?Q?+pTknZ6lvyp8RV+c0b3uwmk/7ly+Zw764mUy3kjk9sEGWGiviK/kvxhtRHfw?=
 =?us-ascii?Q?Ul37XfA5dcEmBqLQ3gTc3eLefSrz8zGiHmqEbypbIxv5ZGUotEe6AfqUiPIL?=
 =?us-ascii?Q?CvM/m+yMRCxDnxSDhfCWuBOOxn9FOtTwNnfLW/+Sz7EJIz4Put1xnwGNY9Ym?=
 =?us-ascii?Q?7VTWQuQLAaqJc3AJi5WVx07PPhfhgzZ9sra05dMR69GPcY+pebVW08NZVuQr?=
 =?us-ascii?Q?ZDWQi7dTgA4JewWYj4Knb68waIe+WIsd5gDqEDHqGVWRpGVi4xc9gUAzpMNe?=
 =?us-ascii?Q?tVvxG5CGVo1BFSr6+OMaN4GU9wVjTvGyD7Pj0dbuOk19I/rcVWuFyh4mh+sp?=
 =?us-ascii?Q?pMk4ezpLDdDZvbtT1UCFVKe2pslV2vGaxDkw0aEEWIfAtjMjMxlsI1a4F3Qf?=
 =?us-ascii?Q?WlurqcD3LDkwML4/JZVc/80LkViZ8P732s9bu0qbSBeEQ45WQkUrhqxyswEX?=
 =?us-ascii?Q?uehLb6V9MBpMHGynnhs5UQgkUp4Rj4SQS8kSw0AzmOKKlrG2iuXjS8nW8rfS?=
 =?us-ascii?Q?QsfRw81EksJRv0OUiZ91isgR5VG+hIevK7bjsHAldCtzntfKRgLXIWttBrZd?=
 =?us-ascii?Q?rCPAPgwVijvmc6uK4rJ6KyDpmIjWUEFWCSi3z3gJGs85JAL2SZFewmqKK2xH?=
 =?us-ascii?Q?GXz7+pLvadJCbXY8A7fRyIp8yqmk24xYM+z+qDlNarlpk3JyZeN9zaUrVRDU?=
 =?us-ascii?Q?0Hsr5bw9JzCBvG4GS6ae6jqqvEJwWk29399CtDt4bV8A//8RbUPYxHW16HLb?=
 =?us-ascii?Q?XH7VUwo2pxHy5wPd9mCstNqDG1sVuINC+EG9TQxGoRhvWWC2ay3QZEylTF3w?=
 =?us-ascii?Q?uHKEOKzKMX3Pj1uOBDa4SQiYm6WO4jxy/2OKFagosFXVjdYeotKjuggTyGSR?=
 =?us-ascii?Q?iImG1LidI34aYKFhocE2VM/+19MLCJpTPRZV3hJ8e9aHRAb8IHvSLqdt0UzN?=
 =?us-ascii?Q?ohnUgNcYxbPxq+PzkC//ZUWVeLvn08c8zd1GA3ctiv+TJ7jgl2jnxJKJMoT1?=
 =?us-ascii?Q?NYL47x6m9pwLQFnYC2vKDMx7wA5RjscsgD8uGa5g4Y/w791JqNn5faYjJG98?=
 =?us-ascii?Q?c/j1UpfXGO8SuyoLua6Fl0jTTqKehcY9s9kAYMWzCXMeKm1VwCv5cEm9TWla?=
 =?us-ascii?Q?T939gQAWrbaBHAtVItOaekEoay56PwmD/0pi6YB7LUA965+eLcphQijigM17?=
 =?us-ascii?Q?a0JZeOQhuDTY5RE4YB5AEl9y5CZf254fSyiWm65S61F4YhI4LGw/pn6N7Pbv?=
 =?us-ascii?Q?/xnUImJRaP7KoVRWxelkcOfn3f4LoHJO/GCXxGrMAX0u/vbcNgxJ4OUpvY+B?=
 =?us-ascii?Q?ZB9QzLOdB9kHqgt8UyDX+bgNeVXdo+7UyLSUIusKvnfKY9IFMExcR1nPVpxM?=
 =?us-ascii?Q?Pt/qtUg7+RIv0CPLduFM428byG0gJ7o/wbz9/Ky2E5Ube9X0zp5i6gHUbgrA?=
 =?us-ascii?Q?mJMpRlNXc92GK+dTJPg+qNeBf7A6PNRDaR/ZmwHR6xr2W55mYYKupX2bRlml?=
 =?us-ascii?Q?JSE5+ChbXYtm/V6Pgm+CvteghGqeMtBlacgE6AxtRsJIvQczEqk574qrmu74?=
 =?us-ascii?Q?eQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	e/X15lLPFXHjaxQEHwSDzvC6CF/G4NkhariSc8O8hwea2BFYsMY0nnefKCp/cBo4HwSwNlgfMu9Kr3+7FL8PLrssYnkVeu5u/RDEAyec2cnJcOEMpagme0MBApcJUhiKiNgXokk+s5YBTb1unFmtlYfxwrpGB5I5wPv8O8oa/GhiaR2hPGrkhrc9TYjvqvXgJqNH1tKZvGeAlsbHT9LPRA+iruxg5y/d+x8v2PiTewyl9hq4rVKIoxyASIROEBfBuFQtx7Ei0JTGnZPUitNkU8ZzNJDDciEgd49sJEujxVtRIJpaPrZeABOsWD0Dm8N8waGdHG4K2v4JFSnX1xNoLMNsbaQXHGEK/i+StBDKwZEE5qvemSD8MQMkkgmvCJYdTj91j4und7B4unjjw0TwR3Dy32CSfJFYPIK/D2gh6f6xJovs1lxJYQUVFdoixzQEF51Drqr1X1V5v1Z/HqRtpBb0Cz5cmy5LFmT9eQJpsRrFvbjDZQCpWviWdXZzN0k9NpeSE6z05/4mRT7K595v/0TuqU+HkeDX2Hb7TxM28wDB7c39rnwiARoItlooaKWXcajHsl6aXylYJAaXpMq5YT5S7p614h5OSj1z3vfUg1E=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36347baa-c3f0-4623-fd9e-08dc314aea09
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 13:01:40.4775
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jIKWho3pQgIy+/ND/ouViy9d7rkYCrD4Hm0OTcuStcTcp7sZRzs37oZHBWPQ7I7+mbxInsmX7jVBSvOvAqQ5MQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6894
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-19_09,2024-02-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402190096
X-Proofpoint-ORIG-GUID: zHqz47fZzbMjV5r3YvqP9RTIJ5QBYfg7
X-Proofpoint-GUID: zHqz47fZzbMjV5r3YvqP9RTIJ5QBYfg7

From: Prasad Singamsetty <prasad.singamsetty@oracle.com>

Extend statx system call to return additional info for atomic write support
support for a file.

Helper function generic_fill_statx_atomic_writes() can be used by FSes to
fill in the relevant statx fields.

Signed-off-by: Prasad Singamsetty <prasad.singamsetty@oracle.com>
#jpg: relocate bdev support to another patch
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 fs/stat.c                 | 34 ++++++++++++++++++++++++++++++++++
 include/linux/fs.h        |  3 +++
 include/linux/stat.h      |  3 +++
 include/uapi/linux/stat.h |  9 ++++++++-
 4 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/fs/stat.c b/fs/stat.c
index 77cdc69eb422..522787a4ab6a 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -89,6 +89,37 @@ void generic_fill_statx_attr(struct inode *inode, struct kstat *stat)
 }
 EXPORT_SYMBOL(generic_fill_statx_attr);
 
+/**
+ * generic_fill_statx_atomic_writes - Fill in the atomic writes statx attributes
+ * @stat:	Where to fill in the attribute flags
+ * @unit_min:	Minimum supported atomic write length
+ * @unit_max:	Maximum supported atomic write length
+ *
+ * Fill in the STATX{_ATTR}_WRITE_ATOMIC flags in the kstat structure from
+ * atomic write unit_min and unit_max values.
+ */
+void generic_fill_statx_atomic_writes(struct kstat *stat,
+				      unsigned int unit_min,
+				      unsigned int unit_max)
+{
+	/* Confirm that the request type is known */
+	stat->result_mask |= STATX_WRITE_ATOMIC;
+
+	/* Confirm that the file attribute type is known */
+	stat->attributes_mask |= STATX_ATTR_WRITE_ATOMIC;
+
+	if (unit_min) {
+		stat->atomic_write_unit_min = unit_min;
+		stat->atomic_write_unit_max = unit_max;
+		/* Initially only allow 1x segment */
+		stat->atomic_write_segments_max = 1;
+
+		/* Confirm atomic writes are actually supported */
+		stat->attributes |= STATX_ATTR_WRITE_ATOMIC;
+	}
+}
+EXPORT_SYMBOL(generic_fill_statx_atomic_writes);
+
 /**
  * vfs_getattr_nosec - getattr without security checks
  * @path: file to get attributes from
@@ -658,6 +689,9 @@ cp_statx(const struct kstat *stat, struct statx __user *buffer)
 	tmp.stx_mnt_id = stat->mnt_id;
 	tmp.stx_dio_mem_align = stat->dio_mem_align;
 	tmp.stx_dio_offset_align = stat->dio_offset_align;
+	tmp.stx_atomic_write_unit_min = stat->atomic_write_unit_min;
+	tmp.stx_atomic_write_unit_max = stat->atomic_write_unit_max;
+	tmp.stx_atomic_write_segments_max = stat->atomic_write_segments_max;
 
 	return copy_to_user(buffer, &tmp, sizeof(tmp)) ? -EFAULT : 0;
 }
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 7271640fd600..531140a7e27a 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3167,6 +3167,9 @@ extern const struct inode_operations page_symlink_inode_operations;
 extern void kfree_link(void *);
 void generic_fillattr(struct mnt_idmap *, u32, struct inode *, struct kstat *);
 void generic_fill_statx_attr(struct inode *inode, struct kstat *stat);
+void generic_fill_statx_atomic_writes(struct kstat *stat,
+				      unsigned int unit_min,
+				      unsigned int unit_max);
 extern int vfs_getattr_nosec(const struct path *, struct kstat *, u32, unsigned int);
 extern int vfs_getattr(const struct path *, struct kstat *, u32, unsigned int);
 void __inode_add_bytes(struct inode *inode, loff_t bytes);
diff --git a/include/linux/stat.h b/include/linux/stat.h
index 52150570d37a..2c5e2b8c6559 100644
--- a/include/linux/stat.h
+++ b/include/linux/stat.h
@@ -53,6 +53,9 @@ struct kstat {
 	u32		dio_mem_align;
 	u32		dio_offset_align;
 	u64		change_cookie;
+	u32		atomic_write_unit_min;
+	u32		atomic_write_unit_max;
+	u32		atomic_write_segments_max;
 };
 
 /* These definitions are internal to the kernel for now. Mainly used by nfsd. */
diff --git a/include/uapi/linux/stat.h b/include/uapi/linux/stat.h
index 2f2ee82d5517..c0e8e10d1de6 100644
--- a/include/uapi/linux/stat.h
+++ b/include/uapi/linux/stat.h
@@ -127,7 +127,12 @@ struct statx {
 	__u32	stx_dio_mem_align;	/* Memory buffer alignment for direct I/O */
 	__u32	stx_dio_offset_align;	/* File offset alignment for direct I/O */
 	/* 0xa0 */
-	__u64	__spare3[12];	/* Spare space for future expansion */
+	__u32	stx_atomic_write_unit_min;
+	__u32	stx_atomic_write_unit_max;
+	__u32   stx_atomic_write_segments_max;
+	__u32   __spare1;
+	/* 0xb0 */
+	__u64	__spare3[10];	/* Spare space for future expansion */
 	/* 0x100 */
 };
 
@@ -155,6 +160,7 @@ struct statx {
 #define STATX_MNT_ID		0x00001000U	/* Got stx_mnt_id */
 #define STATX_DIOALIGN		0x00002000U	/* Want/got direct I/O alignment info */
 #define STATX_MNT_ID_UNIQUE	0x00004000U	/* Want/got extended stx_mount_id */
+#define STATX_WRITE_ATOMIC	0x00008000U	/* Want/got atomic_write_* fields */
 
 #define STATX__RESERVED		0x80000000U	/* Reserved for future struct statx expansion */
 
@@ -190,6 +196,7 @@ struct statx {
 #define STATX_ATTR_MOUNT_ROOT		0x00002000 /* Root of a mount */
 #define STATX_ATTR_VERITY		0x00100000 /* [I] Verity protected file */
 #define STATX_ATTR_DAX			0x00200000 /* File is currently in DAX state */
+#define STATX_ATTR_WRITE_ATOMIC		0x00400000 /* File supports atomic write operations */
 
 
 #endif /* _UAPI_LINUX_STAT_H */
-- 
2.31.1