Received-SPF: pass (google.com: domain of linux-kernel+bounces-71234-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 19 Feb 2024 13:44:18 +0200 (EET)
To: Vishnu Sankar <vishnuocv@gmail.com>
cc: Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>, 
    Mark Pearson <mpearson-lenovo@squebb.ca>, vsankar@lenovo.com
Subject: Re: [PATCH v2 2/2] platform/x86: thinkpad_acpi: Fix to correct wrong
 temp reporting on some ThinkPads
In-Reply-To: <20240215134102.25118-2-vishnuocv@gmail.com>
Message-ID: <ce399b39-aef8-b911-3575-191a0c1104a5@linux.intel.com>
References: <20240215134102.25118-1-vishnuocv@gmail.com> <20240215134102.25118-2-vishnuocv@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 15 Feb 2024, Vishnu Sankar wrote:

> Added non-standard thermal register's support for some ThinkPads.
> 
> Some of the Thinkpads use a non-standard ECFW which has different
> thermal register addresses. This is a fix to correct the wrong temperature
> reporting on those systems.
> 
> Tested on Lenovo ThinkPad L13 Yoga Gen2.
> 
> Suggested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>

> @@ -6290,6 +6332,8 @@ static int thermal_get_sensors(struct ibm_thermal_sensors_struct *s)
>  
>  	if (thermal_read_mode == TPACPI_THERMAL_TPEC_16)
>  		n = 16;
> +	else if (thermal_read_mode == TPACPI_THERMAL_TPEC_12)
> +		n = 12;
>  
>  	for (i = 0 ; i < n; i++) {
>  		res = thermal_get_sensor(i, &s->temp[i]);

Thanks. Both patches now applied. I did some further cleanups into the 
first patch (which I had requested you to do :-().

This 2nd patch didn't apply cleanly on top of for-next but I handled the 
conflict for you this time, in future, please try to base your work on top 
of for-next branch.


-- 
 i.