Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1145799rdb; Mon, 19 Feb 2024 05:56:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWB9WtkdhbdvkVEZ2OAl/6Pqzv1bT2tby4HRlPDzUf3bSbCs1OoToDR0yVa4UCgzocebNbWSDlHiD7fjIT22cJtVFczbPJi4w9E/3wF2g== X-Google-Smtp-Source: AGHT+IHsbXESIqn4aNnKBUk2EYIVay8LJgSf+XbMlEAj6q296ctD30+fTPNbfhoWQIfkTV2+ZARX X-Received: by 2002:a17:906:faca:b0:a3e:710f:32f6 with SMTP id lu10-20020a170906faca00b00a3e710f32f6mr2802428ejb.18.1708351002028; Mon, 19 Feb 2024 05:56:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708351002; cv=pass; d=google.com; s=arc-20160816; b=lArj8VM82jZvq5hNwmoqM3v0fqSc4rY4sMKrnxjxr3Rs4St07a+GpFzXIp/9byXctP RZAU0GmslN9hlkLoNaYALjAtfoZdsQ3ptVxoVLRa91kbUTH/0GQ5zkpPHiasv4p1F0Nz R+Tk7Kg57f2JYsta5296HPkbavCFXP1qctPSfcAHp76mFJxsf5MB9A417KtaXdoYIV9x dcNTTZyiAq6X5tuEk8QH1104xV6l/kj8fkGTQDiBT7lmuYL7l7DvdH860rWR/HRwdLBe YZ6gAwwHA5fHEowo94ezISAJ3+LW3GU6R834W+isJ4ufZacr9hSBFKv9ZiARzIgx8xga /7hg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature :dkim-filter; bh=v6h+TrhDCcE8IdpFwn9bMKIad9vYrlT3yDGRaM2ZAMc=; fh=ziEw9EDL7uCm3iSkdtCGG1lR1TntjQ21mqpofzJu7yo=; b=JOiyj5iG/KPczzPsZTyKxyhobfjcQUaw5jb4F4YurOkmFSj9D8UPvfSzFUIKlwYRVm xnXIOpQU0R4KyfO7cWvTz55d/r9m/h3VJ8j+d2bVHugSCQcLEwMzoYjyrooLc+CxzbNx AtwKfWfwBfuNEukHJ30n5MG/WBglHiz8Ma0mjRBO6SmApL66sfie83URvI4GIB+f7h0t ChMAXveQYushOvy5Av/oA9OJVkFA6l9cpDz8xXwFTdHB91ieHePly2PXQ3CpQZedzcnA HBzLjwrvamznhJ1pHIyzPmWNihgiK+HEov0mC5r+407UYPEV/Jzw5N8bE5MwXedk68jD tyrQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@uliege.be header.s=ulg20190529 header.b=VbG5kIlD; arc=pass (i=1 spf=pass spfdomain=uliege.be dkim=pass dkdomain=uliege.be dmarc=pass fromdomain=uliege.be); spf=pass (google.com: domain of linux-kernel+bounces-71435-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71435-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=uliege.be Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id he44-20020a1709073dac00b00a3e8ec34952si1016994ejc.884.2024.02.19.05.56.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 05:56:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71435-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@uliege.be header.s=ulg20190529 header.b=VbG5kIlD; arc=pass (i=1 spf=pass spfdomain=uliege.be dkim=pass dkdomain=uliege.be dmarc=pass fromdomain=uliege.be); spf=pass (google.com: domain of linux-kernel+bounces-71435-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71435-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=uliege.be Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DD21D1F2307F for ; Mon, 19 Feb 2024 13:56:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED43436AFF; Mon, 19 Feb 2024 13:56:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=uliege.be header.i=@uliege.be header.b="VbG5kIlD" Received: from serv108.segi.ulg.ac.be (serv108.segi.ulg.ac.be [139.165.32.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D811332182; Mon, 19 Feb 2024 13:56:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=139.165.32.111 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708350992; cv=none; b=VkWbUawf3K1W/tuEX9hagyYIFZJ6thXwocB0Zz8omB+LUSN9Tztic9ezoikUoKwj7+PV49EgFsg3o4i1zxxoGQ6QGAgng2xXcSFqjhXmf+P1VobGdEyqpoPU3aKiULgcZ9QvHBC5KARWSpjvChjNfsFjVS5x5cIo9MLjiLrqHkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708350992; c=relaxed/simple; bh=RgNJprUPPOwhgeZ+/R3P4cQ/LqQ2+TTNR4vf52w2fm8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ph2wmv+LEwpJYs27yOyvvEqXkwyWFoRqAJUCKE+yLiP8nib/doCKBI25GWbU10JjT76UlKSQQn288T4vJ7+UDq0p4INnr9VxiAfQG68nUvtXwykkVjaUmJ18RypsOSR2ILAdSanJO6kaDOY0pru+HhJQp3NYksCQv/wvQF/LM9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uliege.be; spf=pass smtp.mailfrom=uliege.be; dkim=pass (2048-bit key) header.d=uliege.be header.i=@uliege.be header.b=VbG5kIlD; arc=none smtp.client-ip=139.165.32.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uliege.be Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uliege.be Received: from [192.168.1.38] (125.179-65-87.adsl-dyn.isp.belgacom.be [87.65.179.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by serv108.segi.ulg.ac.be (Postfix) with ESMTPSA id 2BFAE2012151; Mon, 19 Feb 2024 14:56:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 serv108.segi.ulg.ac.be 2BFAE2012151 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uliege.be; s=ulg20190529; t=1708350989; bh=v6h+TrhDCcE8IdpFwn9bMKIad9vYrlT3yDGRaM2ZAMc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VbG5kIlDrORQqXvWn0WMs9HpjzrRMevGs7wjEDQih1jP60yCONS7UjsItXmrEIqHl wu+AmuGiwc2oBAoHY6rb/ByUoxHF8Iu1KmoUK3zFx7UfxF6MBoQVFOm5mrnFMtmcz6 NN+9V3SkU2eSqVf5CQhuHLMjwFWdbblor82dQVbvh/5JPv5ItkcDiTopmAkjrbq+P+ GScktonQlaiOhxZGk9BiuiaNirCcp3Y8101S+tmUfN+1BvCDD00/7E0lY4dOniN6Gn aj6h/pjOATGA5Y0ZM04bgHV/iXlwwXdqYscavkADyn8UJfWePE5yokSPa5+XQziL6f XEzPmK760Aytg== Message-ID: <4aa88e30-ea08-44ed-a7a3-602c12b6705b@uliege.be> Date: Mon, 19 Feb 2024 14:56:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 0/2] ioam6: fix write to cloned skb's Content-Language: en-US To: netdev@vger.kernel.org Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org References: <20240219134821.14009-1-justin.iurman@uliege.be> From: Justin Iurman In-Reply-To: <20240219134821.14009-1-justin.iurman@uliege.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/19/24 14:48, Justin Iurman wrote: > v2: > - use skb_ensure_writable() instead of skb_cloned()+pskb_expand_head() > - refresh network header pointer in ip6_parse_tlv() when returning from > ipv6_hop_ioam() > > Make sure the IOAM data insertion is not applied on cloned skb's. As a > consequence, ioam selftests needed a refactoring. > > Justin Iurman (2): > Fix write to cloned skb in ipv6_hop_ioam() > selftests: ioam: refactoring to align with the fix > > net/ipv6/exthdrs.c | 10 +++ > tools/testing/selftests/net/ioam6.sh | 38 ++++----- > tools/testing/selftests/net/ioam6_parser.c | 95 +++++++++++----------- > 3 files changed, 76 insertions(+), 67 deletions(-) > > > base-commit: 166c2c8a6a4dc2e4ceba9e10cfe81c3e469e3210 Sorry, please ignore v2 due to net and version not present in patches tag. Instead, please consider v3. Thanks.