Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1157517rdb; Mon, 19 Feb 2024 06:13:19 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW+A3DancYhsSgErG6HdIyTkQQ/rsENvAKOt39zAQTo0bBhZLTwRVv4NTaA96Er2n+47VKuWq/nxxjMPkl6bQI+rOFd7lwunvX4LmbgaQ== X-Google-Smtp-Source: AGHT+IF/gLDZ8X8OIOT7ImGdpvZe99Mfre/6qC8BKd0zmrElZTSnpHnbpj0NrQOHSUX5/wP9EyXc X-Received: by 2002:a05:6358:989f:b0:17a:ec8c:72cd with SMTP id q31-20020a056358989f00b0017aec8c72cdmr15929120rwa.16.1708351999618; Mon, 19 Feb 2024 06:13:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708351999; cv=pass; d=google.com; s=arc-20160816; b=v6GQgkC6BRV/Aq9kv6RS/eFsQunm9GEXVFFaUAuQM7f2pAcEOpCiPlUa55I4WsWXSc jY9XQKRn/RPvf7HrMf+kypTj6yl/G1Q2crm7EK92L9jQMZApGUS/ianjNtnT9zj083Ik ytwo+lF8ayqGDLybpssIBysCLFHpNXBSaFTJBjEaBK3TWN8dj5a5BA1bGKZLUxGBMKJb a+Kb0MuUETMyVIhwy14RVv3gohOWvR3dfe8DRYFxsJKl3cHAUmSiqiw+Pz5BFLSk9MC5 VQ3xqfv80kEEPFMKZE0MnoyZdV37qNTXjIFPiZMt4AABFjm+XJ2XA5lRzG/EIgf1NsAL q8Mg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=yakgxatxnJj6XQND1mgzVdcVV6fqvQwXLMjVua/FQAA=; fh=Fak7jW7YwtMEbY1LsSiM+ll7uQ/OQMhjMA6iklKCLGA=; b=R3tMac5Q5wDZ8WaMPZMZ7Dq1Ltl3henKrdxa1eRxiYqhwtVtPdCvESuDsMSMSM51uH X1gC74IVSmRum/u8QLrl590FEUOSPc3GM2CIHY7pT323wQH9GtlLtsEjEUIqtyuB68Is KJrmMYhrtUFO9kRXDsRfrhLVr5j3ocooQxTWKvfvNCF2fxXCDmaRRHx8EwygifOqhXqL DqiOVBkEFg3UeWQN3b8P1y4HtvF5TxyVjJBAqYdZ/LJ1dAqfmz0QAzaIwHkFOmAo3AoG 4WFFCF/ng8PxNlZ/B/p9xCDEaV/JTOQlUPSnZd1Yn2N/dFXpAe+7jKw0COcTbaSEEeTi f9Rw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wYjXTyUQ; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-71457-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71457-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ln15-20020a056a003ccf00b006e4751b9565si237030pfb.385.2024.02.19.06.13.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 06:13:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71457-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wYjXTyUQ; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-71457-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71457-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5216D28579E for ; Mon, 19 Feb 2024 14:13:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C424374DE; Mon, 19 Feb 2024 14:13:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wYjXTyUQ" Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4FFF2D610 for ; Mon, 19 Feb 2024 14:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708351993; cv=none; b=i43DtxBAF2XIawMy9t8ZIDp22jeTiSgfvevmA46JoWlBXGUPSwG6RA1Y7orRz+VcS3VWyeNMwvbfuM5skZMHFYt49CufPjeaxjf11veYhfdTjx/s7j+Fcd2ACRhpi+hsPSWgf6BiTd6UCzL6/vIsPsKddUSLX37BT+rxYoaNCl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708351993; c=relaxed/simple; bh=yakgxatxnJj6XQND1mgzVdcVV6fqvQwXLMjVua/FQAA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=iiE1vvEeRAN2zTY0j4BGyqreuuGg7MIDQn7rjkPuy/3ybJBpOObYtpmfx+g7soDU4W17ij39zNVC4kRoT7in8Twq+72hIZiuO29zUpJ2n5coLJF81OkCzSh5FeTxTyWFkszfbhP8jfGowHYPIfXwJr37EY0LL19YtCEbrDNMnTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wYjXTyUQ; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-607e707a7f1so40974047b3.2 for ; Mon, 19 Feb 2024 06:13:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708351990; x=1708956790; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yakgxatxnJj6XQND1mgzVdcVV6fqvQwXLMjVua/FQAA=; b=wYjXTyUQzQFHYJXgyqu4Z4vi7xwEWZZ+hu8Kiga5hpzYDOx1pTJdRMNRfvYfEH04ck SJkY4ofsA1mYs5iguk8IhjlQwwvoYbBQYXFnaTND8d4lJShHllt843PGRBoe9WYJj1At HNw0uV8AYHhOlzeIApUt16BqoFMr+ErR1ew0hVQDXnlliadUemi4iKmjp/pTT/ML/1vt NNy3wlSfnIZ4s142C3Kt3hfUiz1fhLKM9uL+B7sbqTiRDTcFWfjYLXGYCUIQdXgYknh7 1sr4UWPRarOB2GcotIwTlTd0/VTChOCTLwewj3AfR8Oat0GzzvA2ZDUi5+44KMjFwLlh 9KcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708351990; x=1708956790; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yakgxatxnJj6XQND1mgzVdcVV6fqvQwXLMjVua/FQAA=; b=d+ZX6YAvbsl9sjM6/xwMPXZXjoUGpc586vxFFsPdZhGf/q+hL33XJ5ZxY5ABw0WevE nV8qgowdeMynsGUbpcyLszG3KeQLgFW7D7z7DNA9iGnxXMbnhX1Z7Y7hShX+GBxDlWD/ fxE5N+Wnl/CScXsnk2FCeJ22HPNBGOaKw3NDqSCy3HSryY9X/+KlAaxE47clCtiQUkM5 qQAQ8jYWeIjQA+UHNg3FgMhy+AWhk6DHvBWc7zLa3XHmNLcaIezJnO+0tLqrowFCnW1Z 4fQ6Y/geTaVxdUDkKaWRLQG39MLAQyO3rEe3ZVnuNekGKfKrt4gOapjSJlKNrQSYn0cc bfDQ== X-Forwarded-Encrypted: i=1; AJvYcCVlGas0YPPlyHap6RTOQgn0MyVyjLMrFaae4eJm7K6EBDtXFMdKOYBCnIDyZAw6zCtW405qJro5B/z7qB7kdLSS65HxWdybOCNLxuOH X-Gm-Message-State: AOJu0YxrJivqsf4EknSZEEY6rpb1qDd8T3WMwqCAoVIRiWuSSfhdN+tC U9K/jwaMsPrs9JYlmRaf4T1CLWXr6LivHJC8DGSJR+PA9UoaBEgdi+Upk5w08v5zdPbcflP0w4Q Zf2KF77m7fwB1jOQ6r8etKepXkfXxEb1r7XdByg== X-Received: by 2002:a25:2e42:0:b0:dc7:43aa:5c0b with SMTP id b2-20020a252e42000000b00dc743aa5c0bmr11657477ybn.21.1708351989672; Mon, 19 Feb 2024 06:13:09 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240215-mbly-i2c-v1-0-19a336e91dca@bootlin.com> <20240215-mbly-i2c-v1-4-19a336e91dca@bootlin.com> In-Reply-To: <20240215-mbly-i2c-v1-4-19a336e91dca@bootlin.com> From: Linus Walleij Date: Mon, 19 Feb 2024 15:12:58 +0100 Message-ID: Subject: Re: [PATCH 04/13] i2c: nomadik: rename private struct pointers from dev to priv To: =?UTF-8?B?VGjDqW8gTGVicnVu?= Cc: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 15, 2024 at 5:52=E2=80=AFPM Th=C3=A9o Lebrun wrote: > Disambiguate the usage of dev as a variable name; it is usually best to > keep it reserved for struct device pointers. Avoid having multiple > names for the same struct pointer (previously: dev, nmk, nmk_i2c). > > Signed-off-by: Th=C3=A9o Lebrun Fair enough, it's more readable like this. Reviewed-by: Linus Walleij Yours, Linus Walleij