Received-SPF: pass (google.com: domain of linux-kernel+bounces-71458-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Thomas Gleixner <tglx@linutronix.de>
To: =?utf-8?B?6ZmI6aqP?= <chenjun102@huawei.com>,
 gregkh@linuxfoundation.org,
 linux-kernel@vger.kernel.org
Cc: xuqiang36@huawei.com, chenjun102@huawei.com
Subject: Re: [PATCH v2] irqchip/mbigen: Fix incorrect null pointer check
In-Reply-To: <20240219085314.85363-1-chenjun102@huawei.com>
References: <20240219085314.85363-1-chenjun102@huawei.com>
Date: Mon, 19 Feb 2024 15:15:10 +0100
Message-ID: <87il2ka6c1.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Chen!

On Mon, Feb 19 2024 at 16:53, =E9=99=88=E9=AA=8F wrote:
> From: Chen Jun <chenjun102@huawei.com>

As I said before, the subject line does not make sense. This is not
about an incorrect NULL pointer check. It's about using a function which
is guaranteed to return NULL on your platform. Something like:

irqchip/mbigen: Don't use bus_get_dev_root() to find the parent

makes it pretty clear what this is about.

> bus_get_dev_root returns sp->dev_root set in subsys_register.
> And subsys_register is not called by platform_bus_init.

Please use '()' when referencing functions. See:

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#function=
-references-in-changelogs

> For platform_bus_type, bus_get_dev_root always returns NULL.
> This makes mbigen_of_create_domain always return -ENODEV.

This lacks an information how the above problem is solved,
i.e. something like:

Don't try to retrieve the parent via bus_get_dev_root() and
unconditionally hand a NULL pointer to of_platform_device_create() to
fix this.

Hmm?

> Fixes: fea087fc291b ("irqchip/mbigen: move to use bus_get_dev_root()")
> Signed-off-by: Chen Jun <chenjun102@huawei.com>

Needs a

Cc: stable@vger.kernel.org

under the Signed-off-by tag.

Thanks,

        tglx