Received-SPF: pass (google.com: domain of linux-kernel+bounces-71477-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 19 Feb 2024 15:29:11 +0100
From: Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, 
	Michal Hocko <mhocko@kernel.org>, Shakeel Butt <shakeelb@google.com>, 
	Roman Gushchin <roman.gushchin@linux.dev>, linux-mm@kvack.org, cgroups@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Jonas =?utf-8?Q?Sch=C3=A4fer?= <jonas@wielicki.name>, 
	Narcis Garcia <debianlists@actiu.net>, Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH] mm: memcontrol: clarify swapaccount=0 deprecation warning
Message-ID: <ch7mbvyfcvc5yswykpgj5i73okgt4dnovelqhpuv22puw7gpba@6vj6d2z2yhau>
References: <20240213081634.3652326-1-hannes@cmpxchg.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ifpowlilw3jtc7ow"
Content-Disposition: inline
In-Reply-To: <20240213081634.3652326-1-hannes@cmpxchg.org>


--ifpowlilw3jtc7ow
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 13, 2024 at 03:16:34AM -0500, Johannes Weiner <hannes@cmpxchg.org> wrote:
> The swapaccount deprecation warning is throwing false positives. Since
> we deprecated the knob and defaulted to enabling, the only reports
> we've been getting are from folks that set swapaccount=1. While this
> is a nice affirmation that always-enabling was the right choice, we
> certainly don't want to warn when users request the supported mode.

But shouldn't such users be still warned about effectively unused option?
I think `return 0;` from the param handler should ensure that.


> +	if (!kstrtobool(s, &res) && !res)
> +		pr_warn_once("The swapaccount=0 commdandline option is deprecated "
                                                commandline

Regards,
Michal

--ifpowlilw3jtc7ow
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZdNltQAKCRAGvrMr/1gc
juU8AQCiaPhuMzNBRds24LnLkLrdU13FWaz9U416QQSNSADfBwD/SBYoMGN5ze1k
0GP/LNuyKMEMrQa7zSRq6963II7goAY=
=Jopi
-----END PGP SIGNATURE-----

--ifpowlilw3jtc7ow--