Received-SPF: pass (google.com: domain of linux-kernel+bounces-71563-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 19 Feb 2024 10:11:45 -0500
From: Frank Li <Frank.li@nxp.com>
To: lpieralisi@kernel.org
Cc: bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org,
	festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com,
	imx@lists.linux.dev, kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org,
	kw@linux.com, l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	manivannan.sadhasivam@linaro.org, robh@kernel.org,
	s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v10 00/14] PCI: imx6: Clean up and add imx95 pci support
Message-ID: <ZdNvsdao8jbB/52L@lizhi-Precision-Tower-5810>
References: <20240205173335.1120469-1-Frank.Li@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240205173335.1120469-1-Frank.Li@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?DaHrP6Y4xE+Sw4FUmHYi/sj3QMx3O5P+s185XwIcfLfRgjW5Tn2FzZMiAQMd?=
 =?us-ascii?Q?lKtjrFPc0oQqDQ1TNzGdDP+GidRrMV+5Qlew102HAy2JIPNn2CUsuw8+Wxa6?=
 =?us-ascii?Q?CJS3gGxrVjGJ9c2Tbbf5e+XB30YrO1u3fb+vZ7gPpFMBqzwQosFuHj5mNXpf?=
 =?us-ascii?Q?KxW3IXjAjC4AnqujQsbnF+oQFBI9Nriv/6NT6x9I2ke7lgsHmDS9VxCEvkuU?=
 =?us-ascii?Q?QyYqBIA9WhNagqFps7yd9l36aZHu+y9WpMYxAME2mP7YHr04zHJbwNWM5vZ3?=
 =?us-ascii?Q?fL4bARi6lzX/d3eL1+b9GDCsYhORo5Kkpk8HzJr8MGszskI+EMFBZhprmRqz?=
 =?us-ascii?Q?HNC+pF0whwC4v4eRclS/6dSbDLK+rCeplN059C36vO1drMZvzuvwxg7o0rLP?=
 =?us-ascii?Q?PxN/DUpGGKEreXiIVoIPVvkfxfDWJ5k2c0E4m598Ou7LFJsqvxmcTHdKECS0?=
 =?us-ascii?Q?omyWfU+2NE/GzwmbZkhVDlX8+HDUBcEe41tkP6626XoicqYhZ4JMY9tzkz53?=
 =?us-ascii?Q?HDvcuM/CACrtyJCMk6/Mz8f8sGVgeeg0WgWZ16tDg5vV6pvRslp6CnJ9c8i8?=
 =?us-ascii?Q?CBWVqsuvp0i24ZzI3Mxbxpl6oMPA4xVPUFfJFYUO89eoX6p7SZ6VAcyMa+q2?=
 =?us-ascii?Q?D5aw2QCmGXP+woRrbKmubLtj0tZOGB4NzSLJ2XVt4yM3chVV0ALmLBt7HbWa?=
 =?us-ascii?Q?QhTRfd+s3QsuOEsyCSIlElUnk53zM6JKOyKIOu/OMe/qu1HjRRch4YEgev2T?=
 =?us-ascii?Q?sXusnWkBHU8yUr+ynkAHM/jRDzwh/v358o+0UCpssZMNyJpfbGuYqOcEhanM?=
 =?us-ascii?Q?77yJ3qXw7VqfnKV4W6hG+Nsrt8xwGic3ctDeWqvktqgjzEm36faaTw8ywbrj?=
 =?us-ascii?Q?fvJbxkV0m4rq54ceweueZdVy9MAZhhoK4WeubH9Xxn5AkwPy2LCF8JyJ/h/h?=
 =?us-ascii?Q?g4pCdEAHmR5bYvZMUfy/pgsP6hpsgg8SGLiBCaqE1bSBGPT5Sqr5dp+XP/sH?=
 =?us-ascii?Q?upW/lez6wLSno11Y/cdJhVGn2deTFfvvXn83xiHzVkfGKTZY5h7b2rD1X9Rt?=
 =?us-ascii?Q?GVaa5WTWzegL0ZmrvgJh1hYemt/78n+DFm3UrPGrSDYSfaL60Uq+1PgnbhB9?=
 =?us-ascii?Q?Kg0MKKQznHvejolre+mCbFF1JGS9iVR+Htls/Duy2QWI+RyP3u8IRt78GmsT?=
 =?us-ascii?Q?jC3rYJfWWNeRRypo/N5elSGX+d00oOg4+hCMm6BqwEkS0a5RB/YWtF0dHQvX?=
 =?us-ascii?Q?VWO9K2u1vVCgWUbPWbvWMq9rIpMfEsZJmSK+IPpf7luXalwCTajlKuB2BLY1?=
 =?us-ascii?Q?MQsKZtA6NbJI4tR+c711P96tyvhtBj46X4mlZmdAQm2XC2EK11tXtkSNU+YR?=
 =?us-ascii?Q?PtBH10WDa3zMFtNo3eUckkzSAIe4Uwqbu0vQOHCqK2n0x5pQS/8A74/T2+Mh?=
 =?us-ascii?Q?ugMmvlcJ+FRlBs+K/DUVaL8ZS8Lpjzjztzf5/Hs38evC5va/u/PN8vfYMOEg?=
 =?us-ascii?Q?4zWx2D3YV93gKtAlesOAU4FBwBRo6KtPeDmTCDhbcWGohzY2n9AopdD+Cwkv?=
 =?us-ascii?Q?2uSm4NZSgx+FgirDNS0=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac6acd47-9889-4a1b-9ebe-08dc315d1c60
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 15:11:55.8839
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HJmuWC4dfQsTf5RNNrPwnxd4CRhktmETWNlaRsX3mvlyuAqTkQTeK4y6TrLt3Tk/MP9bEXImWHk9C9exBOpcdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8468

On Mon, Feb 05, 2024 at 12:33:21PM -0500, Frank Li wrote:
> first 6 patches use drvdata: flags to simplify some switch-case code.
> Improve maintaince and easy to read code.
> 

@Lorenzo Pieralisi:

	Do you have chance to look other patches?
	Mani's apply EP side change. 
	'PCI: imx6: Add iMX95 Endpoint (EP) support' need be rebased. 

Frank

> Then add imx95 basic pci host function.
> 
> follow two patch do endpoint code clean up.
> Then add imx95 basic endpont function.
> 
> Compared with v2, added EP function support and some fixes,  please change
> notes at each patches.
> 
> Change from v9 to v10
> - remove two patches:
> >   dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ
> >   PCI: imx6: Using "linux,pci-domain" as slot ID
> it is not good solution to fixed hardcode check to get controller id.
> Will see better solution later.
> 
> dt-binding pass pcie node:
> 
> pcie0: pcie@4c300000 {
>                         compatible = "fsl,imx95-pcie";
>                         reg = <0 0x4c300000 0 0x40000>,
>                                 <0 0x4c360000 0 0x10000>,
>                                 <0 0x4c340000 0 0x20000>,
>                                 <0 0x60100000 0 0xfe00000>;
>                         reg-names = "dbi", "atu", "app", "config";
>                         #address-cells = <3>;
>                         #size-cells = <2>;
>                         device_type = "pci";
>                         linux,pci-domain = <0>;
>                         bus-range = <0x00 0xff>;
>                         ranges = <0x81000000 0x0 0x00000000 0x0 0x6ff00000 0 0x00100000>,
>                                  <0x82000000 0x0 0x10000000 0x9 0x10000000 0 0x10000000>;
>                         num-lanes = <1>;
>                         num-viewport = <8>;
>                         interrupts = <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>;
>                         interrupt-names = "msi";
>                         #interrupt-cells = <1>;
>                         interrupt-map-mask = <0 0 0 0x7>;
>                         interrupt-map = <0 0 0 1 &gic 0 0 GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
>                                         <0 0 0 2 &gic 0 0 GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>,
>                                         <0 0 0 3 &gic 0 0 GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
>                                         <0 0 0 4 &gic 0 0 GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>;
>                         fsl,max-link-speed = <3>;
>                         clocks = <&scmi_clk IMX95_CLK_HSIO>,
>                                  <&scmi_clk IMX95_CLK_HSIOPLL>,
>                                  <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
>                                  <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
>                         clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux";
>                         assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
>                                          <&scmi_clk IMX95_CLK_HSIOPLL>,
>                                          <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
>                         assigned-clock-rates = <3600000000>, <100000000>, <10000000>;
>                         assigned-clock-parents = <0>, <0>,
>                                                  <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>;
>                         power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
>                         /* 0x30~0x37 stream id for pci0 */
>                         /*
>                          * iommu-map = <0x000 &apps_smmu 0x30 0x1>,
>                          * <0x100 &apps_smmu 0x31 0x1>;
>                          */
>                         status = "disabled";
>                 };
> 
> pcie1: pcie-ep@4c380000 {
>                         compatible = "fsl,imx95-pcie-ep";
>                         reg = <0 0x4c380000 0 0x20000>,
>                               <0 0x4c3e0000 0 0x1000>,
>                               <0 0x4c3a0000 0 0x1000>,
>                               <0 0x4c3c0000 0 0x10000>,
>                               <0 0x4c3f0000 0 0x10000>,
>                               <0xa 0 1 0>;
>                         reg-names = "dbi", "atu", "dbi2", "app", "dma", "addr_space";
>                         interrupts = <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>;
>                         interrupt-names = "dma";
>                         fsl,max-link-speed = <3>;
>                         clocks = <&scmi_clk IMX95_CLK_HSIO>,
>                                  <&scmi_clk IMX95_CLK_HSIOPLL>,
>                                  <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
>                                  <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
>                         clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux";
>                         assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
>                                          <&scmi_clk IMX95_CLK_HSIOPLL>,
>                                          <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
>                         assigned-clock-rates = <3600000000>, <100000000>, <10000000>;
>                         assigned-clock-parents = <0>, <0>,
>                                                  <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>;
>                         power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
>                         status = "disabled";
>                 };
> 
> Frank Li (13):
>   PCI: imx6: Simplify clock handling by using clk_bulk*() function
>   PCI: imx6: Simplify phy handling by using IMX6_PCIE_FLAG_HAS_PHYDRV
>   PCI: imx6: Simplify reset handling by using by using
>     *_FLAG_HAS_*_RESET
>   PCI: imx6: Simplify ltssm_enable() by using ltssm_off and ltssm_mask
>   PCI: imx6: Simplify configure_type() by using mode_off and mode_mask
>   PCI: imx6: Simplify switch-case logic by involve init_phy callback
>   dt-bindings: imx6q-pcie: Clean up irrationality clocks check
>   dt-bindings: imx6q-pcie: Restruct reg and reg-name
>   PCI: imx6: Add iMX95 PCIe Root Complex support
>   PCI: imx6: Clean up get addr_space code
>   PCI: imx6: Add epc_features in imx6_pcie_drvdata
>   dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string
>   PCI: imx6: Add iMX95 Endpoint (EP) support
> 
> Richard Zhu (1):
>   dt-bindings: imx6q-pcie: Add imx95 pcie compatible string
> 
>  .../bindings/pci/fsl,imx6q-pcie-common.yaml   |  17 +-
>  .../bindings/pci/fsl,imx6q-pcie-ep.yaml       |  46 +-
>  .../bindings/pci/fsl,imx6q-pcie.yaml          |  49 +-
>  drivers/pci/controller/dwc/pci-imx6.c         | 634 ++++++++++--------
>  4 files changed, 436 insertions(+), 310 deletions(-)
> 
> -- 
> 2.34.1
>