Received-SPF: pass (google.com: domain of linux-kernel+bounces-71564-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Daniil Dulov <D.Dulov@aladdin.ru>
To: David Howells <dhowells@redhat.com>
CC: Jeffrey E Altman <jaltman@auristor.com>, "linux-afs@lists.infradead.org"
	<linux-afs@lists.infradead.org>, Marc Dionne <marc.dionne@auristor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: RE: [PATCH v2] afs: Increase buffer size in
 afs_update_volume_status()
Thread-Topic: [PATCH v2] afs: Increase buffer size in
 afs_update_volume_status()
Thread-Index: AQHaXY42ktMjs5Z/0kKi/kDcfp2GrLERUMYAgABCobA=
Date: Mon, 19 Feb 2024 15:07:59 +0000
Message-ID: <208066d6326a428499fa68c5984da62c@aladdin.ru>
References: <20240212083347.10742-1-d.dulov@aladdin.ru>
 <125563.1708338814@warthog.procyon.org.uk>
In-Reply-To: <125563.1708338814@warthog.procyon.org.uk>
Accept-Language: ru-RU, en-US
Content-Language: ru-RU
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Hello!

Thank you for your feedback. I agree with the suggested improvement. I will=
 send v3 a bit later today.

-----Original Message-----
From: David Howells [mailto:dhowells@redhat.com]=20
Sent: Monday, February 19, 2024 1:34 PM
To: Daniil Dulov <D.Dulov@aladdin.ru>
Cc: dhowells@redhat.com; Jeffrey E Altman <jaltman@auristor.com>; linux-afs=
@lists.infradead.org; Marc Dionne <marc.dionne@auristor.com>; linux-kernel@=
vger.kernel.org; lvc-project@linuxtesting.org
Subject: Re: [PATCH v2] afs: Increase buffer size in afs_update_volume_stat=
us()

I suggest the attached instead.

David
---
diff --git a/fs/afs/volume.c b/fs/afs/volume.c index 020ecd45e476..af3a3f57=
c1b3 100644
--- a/fs/afs/volume.c
+++ b/fs/afs/volume.c
@@ -353,7 +353,7 @@ static int afs_update_volume_status(struct afs_volume *=
volume, struct key *key)  {
 	struct afs_server_list *new, *old, *discard;
 	struct afs_vldb_entry *vldb;
-	char idbuf[16];
+	char idbuf[24];
 	int ret, idsz;
=20
 	_enter("");
@@ -361,7 +361,7 @@ static int afs_update_volume_status(struct afs_volume *=
volume, struct key *key)
 	/* We look up an ID by passing it as a decimal string in the
 	 * operation's name parameter.
 	 */
-	idsz =3D sprintf(idbuf, "%llu", volume->vid);
+	idsz =3D snprintf(idbuf, sizeof(idbuf), "%llu", volume->vid);
=20
 	vldb =3D afs_vl_lookup_vldb(volume->cell, key, idbuf, idsz);
 	if (IS_ERR(vldb)) {