Received-SPF: pass (google.com: domain of linux-kernel+bounces-71581-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <67a6c770-8638-4d33-b2ee-faff1dffe3b4@amd.com>
Date: Mon, 19 Feb 2024 09:24:04 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Only update profile if
 successfully converted
Content-Language: en-US
To: Mark Pearson <mpearson-lenovo@squebb.ca>,
 Hans de Goede <hdegoede@redhat.com>
Cc: "platform-driver-x86@vger.kernel.org"
 <platform-driver-x86@vger.kernel.org>, linux-kernel@vger.kernel.org
References: <20240217022311.113879-1-mario.limonciello@amd.com>
 <b37b5e6f-c719-4ff2-b16d-96716e681ca9@app.fastmail.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <b37b5e6f-c719-4ff2-b16d-96716e681ca9@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RHlWMnYwSysxTGxPRVpHbTlzMTZqdExVQ3JHNEtUMXJ0NHpCaVFyRk9HT2JK?=
 =?utf-8?B?d3cvbXVPb2ZkVmRNd2c4S21zVER4Y2dCL1hRQWhBK21ZTTNZTHkvaDRBWEVS?=
 =?utf-8?B?VWFubjBobXFtbUFoT3BNWnRyK2R0dzRiVzdRdVY1Vk1YN3l2cjhvamxiQ25o?=
 =?utf-8?B?UzBVZERoUjllaUlLRUxKL2JzMzNoSTgzdEZzbWFnUGZSbTJIV0ZoY04xT3hy?=
 =?utf-8?B?WEp4Vm9Ka3V1V3JmMVVwSFVyM0dIV2dFai9uYTc5czRQT3kvR25sOWw0OG9o?=
 =?utf-8?B?OHpYRlFwU21mdDI2U3lBRDlOL3FjOVBLZ3FoNHBEWmhIcVAxVGtHOFhBbWI3?=
 =?utf-8?B?VGhPZi9peUhTT2VJOFlmeG8vai8yMFpZUmJrdkgyV2RkekwxQThFSGE0NUVY?=
 =?utf-8?B?UlkvNjl6Wm05WnZsYVZRV0JSVjAyOSsvKzBEREpXbUJ0VXNrSm9KQUViRjJ4?=
 =?utf-8?B?NExUcXdGZXFycGNvdWxrcnhpM242R1pGamtXTWkzdS9SWFNuWVZHc05yWWhL?=
 =?utf-8?B?SHk3R1FqZ09rT01xZUpWR2lWTVMxM3BRNlZXRnRZbDFieU5xa0JuTzZwQmQx?=
 =?utf-8?B?UXVxSWljbmxDM2lmeXlYblI1K2s3c09OZWxHRlNkOU9pVCswV09yOVhEOFlY?=
 =?utf-8?B?QTVFK3huUXFRL0dxTUhsRWNHamZ1RFNVVFZHRHk2aHMrNWFUeFVjMUpxZU1E?=
 =?utf-8?B?LzVsS2Jmb1NEaTJZcTBtdjBsNU9rZnpqaVM2bXl0WTBINWU4MStNcnJ4RTRk?=
 =?utf-8?B?YUUvYVBmMzNKVXlscVVFMk1wWXdQcnFwMkE5OUdNS1dtT0dQOWR4cTFVbVh6?=
 =?utf-8?B?L1dPdnNydk8zRzVEYUhodnhMbXp6MWF3WXQ4aFhMWkR4ZnBxMHlNM0lrSmZR?=
 =?utf-8?B?dUFDbEFVSnFBRkRGUmNuZDR6ZEJEWnl0b2duaXcrTmtoMGtFTzRkcUN5ek1z?=
 =?utf-8?B?S0JTOEg2bG16RDZXdG5kVFhUeFRXSUZRTVlHREZmUkNFWm1sOGk5bkN2bzlx?=
 =?utf-8?B?Mi9sTW8xeWlOS2ZJRE0yTll6SXVHTDBTU2tZUkdtU0NiR1AvbFVUS3dGaHlz?=
 =?utf-8?B?eG9vbHpmNUU1QjZzb3I5YnZVbWEwZHdCczhEeDNNcG5lTjhVMmJPZnJlNFRJ?=
 =?utf-8?B?OG85RVN2R29uR0JJNGl1eHdnM1lnSWppbjdJdHF3UXo3VkVLZ21OTDNBREpO?=
 =?utf-8?B?UWFQMFZhamJ3cCtva2g4NEpjWlkyaDhkTHRyYU9xRktTT2dwQmlqenErVi9B?=
 =?utf-8?B?VnZlNTUvRHZwQ2t1TGxLOHN6aGpPUzNGaDVxK2ZoYWJ0dXFadUpLUUNVZzF1?=
 =?utf-8?B?N0JWdVV2TGtXNkpCeUpmTm9JbkVQRkVmeDJMeGNxTHZsNS9KTzlEelRRNXoy?=
 =?utf-8?B?b0xCdHQyRTVERHQ4bzU4eERZMjF2elo3VzdRWWZ1SVVSSzlsMXFIK3h2RCto?=
 =?utf-8?B?dUFmQ2k5ZGp0NHNFRDFLQ1QrblY3NWdNeENWVG9KWm1HZ0pqSFhlODJ5RFlS?=
 =?utf-8?B?ZDU5ZFJJL2doOFdsVnpYZ25GdS9BY0RmV2F3U1VSNzRZUXZ4M2VHbWhYMi9o?=
 =?utf-8?B?WkVPOE5rRWpuUlV2MjJQWW9XNjZJUlpmTys2VndiUCtFTnpoZFF4Y0VhV1lp?=
 =?utf-8?B?emdjV0sxS3pDT3FpdlF0RGFMM2ttMDFNdFh3ZFRrVmxPNWRtSnE5Sk9oc2hI?=
 =?utf-8?B?NEZMbWpyTUFoSjFpdkJqK1A0M1FzWHRTcE5xN2d2VmREdmRKNy8wbnFoYno1?=
 =?utf-8?B?Y09zNzZEeHd1dkhGZlFtajVSOGE2b002NWdxNVFIa0J0MlpnTlJrRGJRK2pL?=
 =?utf-8?B?Q1BCOEI5a3c1dEFpTWFRdHFkaThkaUpldXFEaVRHUkd0SXBVMnh4a3MvdzlC?=
 =?utf-8?B?K1hBRlVrNEplamRwa2lpaytJSjM4SW5sanJsZ1YvcC9kU2ppM3J3Q2ludUtH?=
 =?utf-8?B?MWJnRVJpUHdCMVpjVlF5ZUFBOHRqd1hmSEpMMDRqOWVWM2xZVDJJR09ZM1JG?=
 =?utf-8?B?cFNpOGxiQUxEREtjdzZWRzNTWWRUMk9Mek96NStRQTAxaFhaUGtEVVlCc1Zm?=
 =?utf-8?B?RndOM3M2RWpkb004ZWNjY2J5OWtNYUV2MnJWY2Z3enlGNFNtNGIzTWUyd2Rl?=
 =?utf-8?Q?hfDMUH4K+ASSupO40NwWS8pA0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1402b40a-c58f-4df9-e5ed-08dc315ecfce
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 15:24:06.4550
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LFzLujW+LEzl1x7Bg/RAKL8WTAknkhbzfsYV7EbEWSBFELlfTCFqf2MlC5KVszjJnfZuV7T2dlMxPLCCzgdvOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5829

On 2/19/2024 09:13, Mark Pearson wrote:
> Hi Mario
> 
> On Fri, Feb 16, 2024, at 9:23 PM, Mario Limonciello wrote:
>> Randomly a Lenovo Z13 will trigger a kernel warning traceback from this
>> condition:
>>
>> ```
>> if (WARN_ON((profile < 0) || (profile >= ARRAY_SIZE(profile_names))))
>> ```
>>
>> This happens because thinkpad-acpi always assumes that
>> convert_dytc_to_profile() successfully updated the profile. On the
>> contrary a condition can occur that when dytc_profile_refresh() is called
>> the profile doesn't get updated as there is a -EOPNOTSUPP branch.
>>
>> Catch this situation and avoid updating the profile. Also log this into
>> dynamic debugging in case any other modes should be added in the future.
>>
>> Fixes: c3bfcd4c6762 ("platform/x86: thinkpad_acpi: Add platform profile
>> support")
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> BTW - This isn't new.  I've been seeing this a long time, but I just
>> finally
>> got annoyed enough by it to find the code that triggered the sequence.
> 
> I've never seen this on my systems - is there anything in particular that can be used to reproduce the issue? I'll follow up with the FW team as setting the profile shouldn't (to my knowledge) fail. Agreed it should be handled if it does fail though.

I think it's mostly at bootup I've seen it.

With dynamic debug turned on I can see the "Unknown function" prints 0x0.

> 
>>
>>   drivers/platform/x86/thinkpad_acpi.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/thinkpad_acpi.c
>> b/drivers/platform/x86/thinkpad_acpi.c
>> index c4895e9bc714..5ecd9d33250d 100644
>> --- a/drivers/platform/x86/thinkpad_acpi.c
>> +++ b/drivers/platform/x86/thinkpad_acpi.c
>> @@ -10308,6 +10308,7 @@ static int convert_dytc_to_profile(int
>> funcmode, int dytcmode,
>>   		return 0;
>>   	default:
>>   		/* Unknown function */
>> +		pr_debug("unknown function 0x%x\n", funcmode);
>>   		return -EOPNOTSUPP;
>>   	}
>>   	return 0;
>> @@ -10493,8 +10494,8 @@ static void dytc_profile_refresh(void)
>>   		return;
>>
>>   	perfmode = (output >> DYTC_GET_MODE_BIT) & 0xF;
>> -	convert_dytc_to_profile(funcmode, perfmode, &profile);
>> -	if (profile != dytc_current_profile) {
>> +	err = convert_dytc_to_profile(funcmode, perfmode, &profile);
>> +	if (!err && profile != dytc_current_profile) {
>>   		dytc_current_profile = profile;
>>   		platform_profile_notify();
>>   	}
>> -- 
>> 2.34.1
> 
> Looks good to me. Thank you!
> Reviewed-by Mark Pearson <mpearson-lenovo@squebb.ca>
> 
> Mark