Received-SPF: pass (google.com: domain of linux-kernel+bounces-71589-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 19 Feb 2024 10:34:02 -0500
From: Frank Li <Frank.li@nxp.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org,
	festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com,
	imx@lists.linux.dev, kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org,
	kw@linux.com, l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	manivannan.sadhasivam@linaro.org, robh@kernel.org,
	s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v10 00/14] PCI: imx6: Clean up and add imx95 pci support
Message-ID: <ZdN06tsJH7A0o6fv@lizhi-Precision-Tower-5810>
References: <20240205173335.1120469-1-Frank.Li@nxp.com>
 <ZdNvsdao8jbB/52L@lizhi-Precision-Tower-5810>
 <ZdNx9op+MhzF5FNB@lpieralisi>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZdNx9op+MhzF5FNB@lpieralisi>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mlnHmUlupXTePFReBxrcYKnSr/gRZdteDJIdA6/rxvsHd8bs/OLxuZ69Xkk/?=
 =?us-ascii?Q?o/Rh+Rpm9oHYscYYw86OD6iHUkcl2W0LlrggCR5EZHAuFufH8oD5XcB6W5l9?=
 =?us-ascii?Q?50RO72DfENJd1Bp2UTbfDm6QSdQeyWuqpubMdFfBnsws7mjQ2h7DGsASWi6o?=
 =?us-ascii?Q?Ozu5x0Jl7CoP3bPV91fjwIA3itdhkkRjvrU1a9aH9AE6PVYRonfu6s4oiCTY?=
 =?us-ascii?Q?Vsi6TsoqsTDPzpkmOEhmN8/WY5JydAEUW/ieH3KEkyGOfrDbZn8T2lPVFCM1?=
 =?us-ascii?Q?N8WJ/oT939perWKm/yufFGIzDjSr8qA+U2rypb8RwdWQNdlSQ1cuDHGxDnJV?=
 =?us-ascii?Q?c5IqcTlcUsHFRQ2dYV6t1FUQAGkvEIXIy6F9ZI83smExSm8vvP2nKGJdZGES?=
 =?us-ascii?Q?Lue3UnFvmjV9RghbuFg+BQeYvpB5S39R9h5ELM2u6AfvkZbuwHVyTQLYLFmt?=
 =?us-ascii?Q?MvRM+1HtV3cowLzNLHiSBmJlnjoe3+nOdUnLccboENmhXVD9/dSjx9PSlLzh?=
 =?us-ascii?Q?NaHAD3chj2phxmjTp94GOoggqsP60gT4dFxO6hrHXXwyWbtjkgCz1tT6HFXW?=
 =?us-ascii?Q?cJanC+8YZWOdkGY2RQtWdAVjnBcyK1bdHcuDBJTn/WopvX9Xc6P+m1ASQPRy?=
 =?us-ascii?Q?SuSRwlhYaTwkuDTPpOQ+FZXBCZ5NPNiZ48OUcMuQgk4mAO4EAFKTaxS7Bj54?=
 =?us-ascii?Q?QySPQHUvQFdm/XCejUI9jLkPqOCk52LKOQrAChvg1pS20Gg8d5+w7jnZV1Zj?=
 =?us-ascii?Q?IH1JsQ/LsI8vhhssAg5wXsTZ211dPxpwbZ79+Ofe/0iv84SO1Zc/ZnHp/X5k?=
 =?us-ascii?Q?SJUc9DYWJQXSjcmMgQnLgkLh9jRK0yRm4MR1gXK8iKEkBQT5zH05I4xy+EJy?=
 =?us-ascii?Q?ZZbT1hBetA/XYneomppM+1mmV0aZ6/fRQbpyk7iXlGvWy5sncQkUUqGx3JjP?=
 =?us-ascii?Q?WU3wdvlHLkrZ4IQZqIAtVCyzORvOSknTSrfVDSXPdF2opDJkR5LcrGG8BRw4?=
 =?us-ascii?Q?ohPrNpgSUdW/4FUBZF6EoP5mPI4uZh4P1GK8vLhdxPFTreJgJngOSGdNopjb?=
 =?us-ascii?Q?64u3QGgpYyy7pDwtOCZ6DcJuTEcpRUahNrrGfmMfUXmaVCT/o0jQOSMNAPUx?=
 =?us-ascii?Q?MWXLnq7J6n371UlaafrhTw/bX3sCjDlqLkyoiffoQ+HNA9+mOKI0bqsh1hPu?=
 =?us-ascii?Q?H38ZLVSfxTifdS/gdgF+G+r9pDuMONPu0QlEyPthm6tRKFghN7I2HMMjsd9/?=
 =?us-ascii?Q?yAkKYPa3zrl1btXGqvbNV0U/rTcv7Q1KvZEvxY4HnksvFXaev16xcM2HZTP9?=
 =?us-ascii?Q?spxZcPbd+I0u9RjE+Yo1r1mmT0dcz3MkE1ghbedXpz4xnUSAiB/pWDx0rdFR?=
 =?us-ascii?Q?iq+qHoVpoGfA/X7Yoo50hX6tS3ByxYK4rVKtnu7y/JVDJqOg/4F+RydubCY/?=
 =?us-ascii?Q?cNikBAn+BJp5YyM96/Cnb35tLErDo/empLooTJPyyTTwivucNo/N9rOphNok?=
 =?us-ascii?Q?O34goX8TvGkL016cPAkCrv8Xmsc62Ksj05gIOHdrtBld1XtIFECJh1WtXZR/?=
 =?us-ascii?Q?Ds/7oZgkKqkTxrr7rCxQ193J7JJjyS05NXwsDByj?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df2c534f-2686-4bb2-c705-08dc3160397d
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 15:34:13.1855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nrGery7/FW1w2vfFz3Aip2ZLgFONizZ7MSKkSZbY421dWi5R/fDNzCzjJJi0q/0ACAXXS9yZebNjd52lNtSZqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9979

On Mon, Feb 19, 2024 at 04:21:26PM +0100, Lorenzo Pieralisi wrote:
> On Mon, Feb 19, 2024 at 10:11:45AM -0500, Frank Li wrote:
> > On Mon, Feb 05, 2024 at 12:33:21PM -0500, Frank Li wrote:
> > > first 6 patches use drvdata: flags to simplify some switch-case code.
> > > Improve maintaince and easy to read code.
> > > 
> > 
> > @Lorenzo Pieralisi:
> > 
> > 	Do you have chance to look other patches?
> 
> Yes, they are fine.
> 
> > 	Mani's apply EP side change. 
> > 	'PCI: imx6: Add iMX95 Endpoint (EP) support' need be rebased. 
> 
> What does that mean ? I think it is best to pull the series in a single
> branch if there are not any dependencies on other branches.

Two options:

Options 1:
	Merge 1-13. Left 'PCI: imx6: Add iMX95 Endpoint (EP) support'.
I will send out later with other clean up patches.

Options 2:
	I rebase to https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=endpoint
	After Bjorn Helgaas merge to next, you can pick all.

I perfer opitons 1.

Frank

> 
> Thanks,
> Lorenzo
> 
> > Frank
> > 
> > > Then add imx95 basic pci host function.
> > > 
> > > follow two patch do endpoint code clean up.
> > > Then add imx95 basic endpont function.
> > > 
> > > Compared with v2, added EP function support and some fixes,  please change
> > > notes at each patches.
> > > 
> > > Change from v9 to v10
> > > - remove two patches:
> > > >   dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ
> > > >   PCI: imx6: Using "linux,pci-domain" as slot ID
> > > it is not good solution to fixed hardcode check to get controller id.
> > > Will see better solution later.
> > > 
> > > dt-binding pass pcie node:
> > > 
> > > pcie0: pcie@4c300000 {
> > >                         compatible = "fsl,imx95-pcie";
> > >                         reg = <0 0x4c300000 0 0x40000>,
> > >                                 <0 0x4c360000 0 0x10000>,
> > >                                 <0 0x4c340000 0 0x20000>,
> > >                                 <0 0x60100000 0 0xfe00000>;
> > >                         reg-names = "dbi", "atu", "app", "config";
> > >                         #address-cells = <3>;
> > >                         #size-cells = <2>;
> > >                         device_type = "pci";
> > >                         linux,pci-domain = <0>;
> > >                         bus-range = <0x00 0xff>;
> > >                         ranges = <0x81000000 0x0 0x00000000 0x0 0x6ff00000 0 0x00100000>,
> > >                                  <0x82000000 0x0 0x10000000 0x9 0x10000000 0 0x10000000>;
> > >                         num-lanes = <1>;
> > >                         num-viewport = <8>;
> > >                         interrupts = <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>;
> > >                         interrupt-names = "msi";
> > >                         #interrupt-cells = <1>;
> > >                         interrupt-map-mask = <0 0 0 0x7>;
> > >                         interrupt-map = <0 0 0 1 &gic 0 0 GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
> > >                                         <0 0 0 2 &gic 0 0 GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>,
> > >                                         <0 0 0 3 &gic 0 0 GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
> > >                                         <0 0 0 4 &gic 0 0 GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>;
> > >                         fsl,max-link-speed = <3>;
> > >                         clocks = <&scmi_clk IMX95_CLK_HSIO>,
> > >                                  <&scmi_clk IMX95_CLK_HSIOPLL>,
> > >                                  <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
> > >                                  <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
> > >                         clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux";
> > >                         assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
> > >                                          <&scmi_clk IMX95_CLK_HSIOPLL>,
> > >                                          <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
> > >                         assigned-clock-rates = <3600000000>, <100000000>, <10000000>;
> > >                         assigned-clock-parents = <0>, <0>,
> > >                                                  <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>;
> > >                         power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
> > >                         /* 0x30~0x37 stream id for pci0 */
> > >                         /*
> > >                          * iommu-map = <0x000 &apps_smmu 0x30 0x1>,
> > >                          * <0x100 &apps_smmu 0x31 0x1>;
> > >                          */
> > >                         status = "disabled";
> > >                 };
> > > 
> > > pcie1: pcie-ep@4c380000 {
> > >                         compatible = "fsl,imx95-pcie-ep";
> > >                         reg = <0 0x4c380000 0 0x20000>,
> > >                               <0 0x4c3e0000 0 0x1000>,
> > >                               <0 0x4c3a0000 0 0x1000>,
> > >                               <0 0x4c3c0000 0 0x10000>,
> > >                               <0 0x4c3f0000 0 0x10000>,
> > >                               <0xa 0 1 0>;
> > >                         reg-names = "dbi", "atu", "dbi2", "app", "dma", "addr_space";
> > >                         interrupts = <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>;
> > >                         interrupt-names = "dma";
> > >                         fsl,max-link-speed = <3>;
> > >                         clocks = <&scmi_clk IMX95_CLK_HSIO>,
> > >                                  <&scmi_clk IMX95_CLK_HSIOPLL>,
> > >                                  <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
> > >                                  <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
> > >                         clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux";
> > >                         assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
> > >                                          <&scmi_clk IMX95_CLK_HSIOPLL>,
> > >                                          <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
> > >                         assigned-clock-rates = <3600000000>, <100000000>, <10000000>;
> > >                         assigned-clock-parents = <0>, <0>,
> > >                                                  <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>;
> > >                         power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
> > >                         status = "disabled";
> > >                 };
> > > 
> > > Frank Li (13):
> > >   PCI: imx6: Simplify clock handling by using clk_bulk*() function
> > >   PCI: imx6: Simplify phy handling by using IMX6_PCIE_FLAG_HAS_PHYDRV
> > >   PCI: imx6: Simplify reset handling by using by using
> > >     *_FLAG_HAS_*_RESET
> > >   PCI: imx6: Simplify ltssm_enable() by using ltssm_off and ltssm_mask
> > >   PCI: imx6: Simplify configure_type() by using mode_off and mode_mask
> > >   PCI: imx6: Simplify switch-case logic by involve init_phy callback
> > >   dt-bindings: imx6q-pcie: Clean up irrationality clocks check
> > >   dt-bindings: imx6q-pcie: Restruct reg and reg-name
> > >   PCI: imx6: Add iMX95 PCIe Root Complex support
> > >   PCI: imx6: Clean up get addr_space code
> > >   PCI: imx6: Add epc_features in imx6_pcie_drvdata
> > >   dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string
> > >   PCI: imx6: Add iMX95 Endpoint (EP) support
> > > 
> > > Richard Zhu (1):
> > >   dt-bindings: imx6q-pcie: Add imx95 pcie compatible string
> > > 
> > >  .../bindings/pci/fsl,imx6q-pcie-common.yaml   |  17 +-
> > >  .../bindings/pci/fsl,imx6q-pcie-ep.yaml       |  46 +-
> > >  .../bindings/pci/fsl,imx6q-pcie.yaml          |  49 +-
> > >  drivers/pci/controller/dwc/pci-imx6.c         | 634 ++++++++++--------
> > >  4 files changed, 436 insertions(+), 310 deletions(-)
> > > 
> > > -- 
> > > 2.34.1
> > >