Received-SPF: pass (google.com: domain of linux-kernel+bounces-71586-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 19 Feb 2024 17:30:16 +0200
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Sean Anderson <sean.anderson@seco.com>, Arnd Bergmann <arnd@arndb.de>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Roy Pledge <roy.pledge@nxp.com>,
	Camelia Groza <camelia.groza@nxp.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Scott Wood <oss@buserror.net>, stable@vger.kernel.org
Subject: Re: [RESEND PATCH net v4 1/2] soc: fsl: qbman: Always disable
 interrupts when taking cgr_lock
Message-ID: <20240219153016.ntltc76bphwrv6hn@skbuf>
References: <20240215162327.3663092-1-sean.anderson@seco.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240215162327.3663092-1-sean.anderson@seco.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?us-ascii?Q?duyNXTje1KBLOFK50JHbm8zCI7oisEVm3qTFv6BVVzyrzX2StyO3pKlzI4UH?=
 =?us-ascii?Q?mD5KpXi3dE5DXZvXUZ9ayiFM7hIjWxtzLV7k/OcoogmthhDQIKlOW06H0lYW?=
 =?us-ascii?Q?VOn2H9H+HufGN3cy9j/xiOmIPO1gbsXb6PEYYgeP67BC07zG4YjIN/haUNr7?=
 =?us-ascii?Q?YpUMAN34k9mzCrS+oBVFVAbd/Mjb+VxLhDl0eUXyTF1RpscCaJe0zc+d263U?=
 =?us-ascii?Q?QDfFEBxVcvy8OWaw9SBqEbbI4B/sYxqJekKBXmf3HVFVktAj27es//rwu94T?=
 =?us-ascii?Q?FBmFjosYeswo/xVq3KqpmJYTbkX7fces2hhfzvjbdmP30T5WxV46YMBFUEsP?=
 =?us-ascii?Q?BEPO0oIF4mgMqG2sPWW2iNgZQnWxurAY2x32ABx/N2+7rSUyd0LyUE1hzg3m?=
 =?us-ascii?Q?BAxMOyzudZzK5XjUNRju+pAxPDujn2hhKo0+YoUkpLrCgBy1EuNYa1w9XorF?=
 =?us-ascii?Q?QQYFufe94Vl4CoZW9miaju508pZiuYekY2D7fPix49JGP7HYx+bXPk+DMkAd?=
 =?us-ascii?Q?sWVe8gei1B8zKMt7OHDFbIiUfL9i7A2OEox9G2TjPbE9sQJSnoD7DxBwPMjE?=
 =?us-ascii?Q?p7RmbOuRRA5NMGE6AokV8KDDKGqJH0lLuemcq0sFu2vRJc3m1LE7elaWp15t?=
 =?us-ascii?Q?JXEkQwoSPjTFlyzro8gCU3HZa8a7eGjpf9Gtbvf1kAMzPI0vnhUEGbvqujqk?=
 =?us-ascii?Q?pgtOxH6L0O7YSNwB8Moypa3bqoChUfu3yeFYx0/hw8kE/1TfWrdKouXbQ1nU?=
 =?us-ascii?Q?U/viDHUn3SCbhEce0VLH5wAYgz0HQdh2e/v/0ui3BTRabaLWW9b1jzfKkthc?=
 =?us-ascii?Q?Zh7L8LQxcDWmPHBhU5TXgTh85PiFkoul1H+8hpdL/2aMWihOH/GhAEjSczkU?=
 =?us-ascii?Q?BNA4FqQOyV1GkwZWqPh4J6jJWJhu5jgleH0yuG0nCM0B314h63rbpoc6PQum?=
 =?us-ascii?Q?mToucdRe+efAlxyoR0cxPU8GDI5BjpL9Pc54T8AB/Y+yicV2M4Ggp0JEIHMk?=
 =?us-ascii?Q?nYUe4jmofehd+jikxvgv7s4FVMneDFPZs1P+etCy0ep+aVTkwPolZ1a9jFGc?=
 =?us-ascii?Q?B+7DP7MJiUVqxG93CnD/rnnATiIbn3r+Qxfh0rnUX84IdvsT1aZ+9PAz3Goe?=
 =?us-ascii?Q?Ps42myc29IfVfKY6+K2mIKfAgc5/bEEg5v2uFIjot2fQ0Bd5/V43oUaZfAX8?=
 =?us-ascii?Q?tWmnBVbHMSSakwPqfOyMdcsRppOAn9CIgS+TtCQw/wf3CbbMfAxv9mUvuYrJ?=
 =?us-ascii?Q?LF1mbfY9yITLDADZPHtjYUghs+JKPNs9iKRGNPJOUR1vgl4I2gb9/qxz9D+s?=
 =?us-ascii?Q?ZxoZKMCnfAq0JArAF8n3k67P0R+PU+sNGRJv5QacYwTAQT/1G2eEZxUuu1ns?=
 =?us-ascii?Q?LGIDHFUutsnL9oWfzfF7n57UCgycaR6uDfiIHMUV32nmgKBAOdkl9U+gmLou?=
 =?us-ascii?Q?S36h/CWZu1FoePSJWE5S0AgwlY/Q0a0dnNIFGMRkym10blgJOygjE7vnQbAa?=
 =?us-ascii?Q?4Cw48nwSlSPVXO8aVwGyMj3I+UG1VpgO9ayXetiYFh7u3PQg+8CbqcyGFd6n?=
 =?us-ascii?Q?gDFpCouDhdyJnu1bOoNQaviL/ekW7Ej6QrVbsTBDcFcAnxWQ+CDxE4lTbh4J?=
 =?us-ascii?Q?Z+90m0UWccDo9D8gcZcj6Yc=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e440ee9-e411-4150-7864-08dc315faed3
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB7374.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 15:30:20.6660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2E9sK+4hGoKnVJNT8RdjJUcFyaKAnjjxczrnnosBpcb58J8ghtIjDdNzIXJHdCknDhk3enOkn4l28O32iL8xQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7874

Hi Sean,

On Thu, Feb 15, 2024 at 11:23:26AM -0500, Sean Anderson wrote:
> smp_call_function_single disables IRQs when executing the callback. To
> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere.
> This is already done by qman_update_cgr and qman_delete_cgr; fix the
> other lockers.
> 
> Fixes: 96f413f47677 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()")
> CC: stable@vger.kernel.org
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> Reviewed-by: Camelia Groza <camelia.groza@nxp.com>
> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> I got no response the first time I sent this, so I am resending to net.
> This issue was introduced in a series which went through net, so I hope
> it makes sense to take it via net.
> 
> [1] https://lore.kernel.org/linux-arm-kernel/20240108161904.2865093-1-sean.anderson@seco.com/
> 
> (no changes since v3)
> 
> Changes in v3:
> - Change blamed commit to something more appropriate
> 
> Changes in v2:
> - Fix one additional call to spin_unlock

Leo Li (Li Yang) is no longer with NXP. Until we figure out within NXP
how to continue with the maintainership of drivers/soc/fsl/, yes, please
continue to submit this series to 'net'. I would also like to point
out to Arnd that this is the case.

Arnd, a large portion of drivers/soc/fsl/ is networking-related
(dpio, qbman). Would it make sense to transfer the maintainership
of these under the respective networking drivers, to simplify the
procedures?

Also, your patches are whitespace-damaged. They do not apply to the
kernel, and patchwork shows this as well.
https://patchwork.kernel.org/project/netdevbpf/patch/20240215162327.3663092-1-sean.anderson@seco.com/

Please repost with this fixed.