Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1218077rdb; Mon, 19 Feb 2024 07:57:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUNr5iVqxEHBup8hZeTl7GRoiHK8UPueHIt1R8fichYi4BSUBh5mj/0j3fvTQ1LCHhULaqptabkEdl2my3VYQNQe+Vuikw6qbO8Kqo1Nw== X-Google-Smtp-Source: AGHT+IH+7D6okw9irtQJR5jDEGLBgfUa9QQfflC2DwGKApjSPxpW5Yg7Nm/Ngus3H10Y7pOy8KCf X-Received: by 2002:a17:902:ce82:b0:1db:f8ef:a9e2 with SMTP id f2-20020a170902ce8200b001dbf8efa9e2mr3299286plg.47.1708358262870; Mon, 19 Feb 2024 07:57:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708358262; cv=pass; d=google.com; s=arc-20160816; b=qVi7VcXwHZYfiIm0Y53fRuaNfP5Y/OzGmQylZte4N0aLlksksIQta/zpP/qjd0mCiF gm4Qh1IDScBB7skSrIKodMBlJDvpdhi7nYkYgbbo+ZT3wu695xpdtaJb2Du9Ivklk5vL YKZDo0l/RMnQd+zp/XMbe4QmPmQXScLfGDsIrOSOIORRJbq2CiRJmBMWd9soFD7VgkwW BB8mXifsJfWBs3Fz9ZJaCPVVtXxYZcvAdsIvxxHpKo5KhqNHmqdOZ6j1Sji2B9oDdvdB iwCUkRNu2QrG8ckL+07IX5Gu3wkcR6y2gxdHSuDHEbQRWFUleXsOCHhIKR4kcHmOzeIb XR2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=98In5UygfGzOw+y93nI31bPBjEnqkQiXZ4OUGvaY8BE=; fh=VsQx/pVkYwk2KBLEN3vMavEQPowpoaayayH9X0uBLGI=; b=rgWqlOlioDfzaN9xnJIdPC+3leZo4UOyUdaEXpPn4g8dRo6pyj7vlJqeKAct2/NqXz AgFCyKj2q3Cu3lcXiSoBfzMy1Hm7+RQmTAPD8KvcsisP43Egr4AMnpx7kHo8VQrPKCBc 8djbGccE6qe6bIf5pGF4mGweZAG+WFehVvsckUgAPbarYN724rWthw1GPln+9O6lkKHl LI4VRW27RlACwft6BcvP8jX37pRsOPPKls7QG6FjFAys8vPIxsNQWwAW66tKqiWAGhtp V5cyrkuThD23SQ9uwwO2mJYnP3Gwci7qPoH3+xJx/uTq9BuVutLlud6WFjPISGE6pMSs 7Yig==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GIbaVIyX; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71625-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71625-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j8-20020a170902da8800b001db45d5fb12si3431830plx.378.2024.02.19.07.57.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 07:57:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71625-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GIbaVIyX; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71625-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71625-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8CF732834E9 for ; Mon, 19 Feb 2024 15:57:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 854183A8FB; Mon, 19 Feb 2024 15:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GIbaVIyX" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CEDE38F98; Mon, 19 Feb 2024 15:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708358249; cv=none; b=RnMvC2WWfriKyZmpyaxRLJvq+CvORkaXYvtZtXlIBM2wQ+dEKjbQf0qLosm40y71WVJ/ksUU3UZ1KbgAL1hYkKHphCkLym5iDfo8ltsIaSQS3Vd9EZpPxHwcuzJUE/RHUyPudRmGrD6iH98Bp3cNhdOQHcU2JFuuHR4SRv9GUqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708358249; c=relaxed/simple; bh=QxzA0sWbtJ1971nGvDV76Q3FY8LZ3iFXNaFcbvQwYYk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i3Y2R+puBbcp6jCCXTfgtENUpF7ipzz5hhdopGB9yrL/BIF0cYm8p8/61E/cBXCLx9YL3JfuTU+SZaKngst7vIoPO+3fA9bsWmHBAlhb/vJQg/Ua4uQ3CrqdzEfoJ2Ju4zNtNmfouKpp9J4bnkxCpmaQXUf+/LLiFR7kNVEMllY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GIbaVIyX; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708358247; x=1739894247; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QxzA0sWbtJ1971nGvDV76Q3FY8LZ3iFXNaFcbvQwYYk=; b=GIbaVIyXeaO0K+zMngg3jAWMnfIRiTjHvmysnwoi4GwVeRVpEQPXshmq VKhbdMn0nmlKbbk8wJDpg6oZCoxzMaxNEmpziVTYv/BnyLNH1E9GxMDLa 5fb9bPVvS68CEzQ7Y9XA5Wad/ktq2n7dII3WI3v3f8jJvjTxuvjmlq5ck mXp5yoj2hewxzhqgl+gJzmGdC0xnH6xTHSPJfPMKme9xjTvJq6eCr+INN Qr23qEgQrNJxEjj/1thpHBsNDQ8OIbPtAQ3q3dafBWVkzPLv7GC1/xSBG iyqBXC9pypWDlAgRNIoGWLSahOy+vHekVe5uLLs7Ha2jXBTDtC5iTAVTE g==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="13151568" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="13151568" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:57:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="912896951" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="912896951" Received: from unknown (HELO [10.209.34.48]) ([10.209.34.48]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:56:59 -0800 Message-ID: <40f95b90-8698-42dd-89d7-cd73d1e311b1@intel.com> Date: Mon, 19 Feb 2024 07:56:58 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] x86/sgx: Remove 'reclaim' boolean parameters Content-Language: en-US To: Haitao Huang , jarkko@kernel.org Cc: anakrish@microsoft.com, bp@alien8.de, cgroups@vger.kernel.org, chrisyan@microsoft.com, dave.hansen@linux.intel.com, hpa@zytor.com, kristen@linux.intel.com, linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org, mikko.ylinen@linux.intel.com, mingo@redhat.com, mkoutny@suse.com, seanjc@google.com, sohil.mehta@intel.com, tglx@linutronix.de, tim.c.chen@linux.intel.com, tj@kernel.org, x86@kernel.org, yangjie@microsoft.com, zhanb@microsoft.com, zhiquan1.li@intel.com References: <20240219153957.9957-1-haitao.huang@linux.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240219153957.9957-1-haitao.huang@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/19/24 07:39, Haitao Huang wrote: > Remove all boolean parameters for 'reclaim' from the function > sgx_alloc_epc_page() and its callers by making two versions of each > function. > > Also opportunistically remove non-static declaration of > __sgx_alloc_epc_page() and a typo > > Signed-off-by: Haitao Huang > Suggested-by: Jarkko Sakkinen > --- > arch/x86/kernel/cpu/sgx/encl.c | 56 +++++++++++++++++++++------ > arch/x86/kernel/cpu/sgx/encl.h | 6 ++- > arch/x86/kernel/cpu/sgx/ioctl.c | 23 ++++++++--- > arch/x86/kernel/cpu/sgx/main.c | 68 ++++++++++++++++++++++----------- > arch/x86/kernel/cpu/sgx/sgx.h | 4 +- > arch/x86/kernel/cpu/sgx/virt.c | 2 +- > 6 files changed, 115 insertions(+), 44 deletions(-) Jarkko, did this turn out how you expected? I think passing around a function pointer to *only* communicate 1 bit of information is a _bit_ overkill here. Simply replacing the bool with: enum sgx_reclaim { SGX_NO_RECLAIM, SGX_DO_RECLAIM }; would do the same thing. Right? Are you sure you want a function pointer for this?