Received-SPF: pass (google.com: domain of linux-kernel+bounces-71634-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9427c0fd-f48a-4104-ac7e-2929be3562af@web.de>
Date: Mon, 19 Feb 2024 16:57:04 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Niklas Cassel <cassel@kernel.org>,
 Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
 Damien Le Moal <dlemoal@kernel.org>, Jens Axboe <axboe@kernel.dk>,
 Michal Simek <michal.simek@amd.com>, Philipp Zabel <p.zabel@pengutronix.de>,
 linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, git@amd.com
References: <ZdMp+QBiays6fprk@x1-carbon>
Subject: Re: [PATCH v3] ata: ahci_ceva: fix error handling for Xilinx GT PHY
 support
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <ZdMp+QBiays6fprk@x1-carbon>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Z5xuQVR5D3s=;KNcmfynmW+sNHysCEHwpCQStPRZ
 pdnqcgbpuIgdUNxYxMSLajE01VRdbF+HGWWtdFHjwBd0Z6h1B+DmhyhU3LnxLQXgNlWxq3h6e
 4NfopGQNzZd6iaaEJ9LKOA9w3tI+OkihBR8HTlyTfnEBijfjWJDckglN0yZFRmJtAhTAMHi/8
 gJu3uADKqqDUCFdOkBNBfip7YQtF4sE3l5WJvpFTuyA5vXpJbkqxq20VzGi0s6BlQzQKmfPTj
 GKBCBjGQQcolZM52h3HWHJlDCcP9EyFHOCKRRUIIFUkWbuueFFzB/rUeI9StMEMPkqdNSXOwP
 1wSfbJWLXU5cz88oIvgv9WPbUsN07l7dgIFIBzxUzTL9gfoqU5PK4sUSXyECWwh9TH4msvjDl
 RylTWLsquVGe/uUNaHpSgMeWGN+A/ZM4LchUzoCe8Elok1KGAN/uJEmgoRNuX8k12+JgIcRfT
 qutvdDWPDT8lcD7P3ULplJuE6iS9p3pJZPfKU7263deybEwL62UHPDo/ncGHAMUSrpIbpjKbY
 QNMRJ6Zx171tK9DbdU+NI5MO5X+iIqqeetXF9x3QEmLR/lVQRTMgdWeOj9uHnuuQTemm/4l96
 EudWJ1LAYLHwJSXs4nLOW7psAWm7UZAwPG8dX5SZJwFCRjGYhwVKQfbg6IN0fJYhT6har5lQR
 6DMZijbRT367FPzsBSm5ngz/iAJ0vq7cQcMG4RP5f5Viso/eSzWIJtvFtn2ETM7jwQ8rKtKWm
 ulhXHNH6OA86NC+RJaQuofeLCihE0oKJvWfVkUbOzEGmmdIVhpichQEwC5X3bV7BB4ZvIejyQ
 3fhXmJJOjWtlYVH08b47kaQvfxSb0OcKPnb9e/DPsI+Jo=

> > Platform clock and phy error resources are not cleaned up in Xilinx GT=
 PHY
> > error path.
> >
> > To fix introduce the function ceva_ahci_platform_enable_resources()
=E2=80=A6
> Applied:
> https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/log/?h=
=3Dfor-6.8-fixes

The error code =E2=80=9C-EINVAL=E2=80=9D was set before the statement =E2=
=80=9Cgoto disable_resources=E2=80=9D
multiple times in the adjusted implementation of the function =E2=80=9Ccev=
a_ahci_probe=E2=80=9D.
I suggest to add a jump target so that a bit of exception handling
can be better reused at the end of this function.


How do you think about to apply the following script for the semantic
patch language (Coccinelle software) accordingly?


@replacement1@
identifier rc;
@@
 <+...
 if (...)
 {
    ... when !=3D rc
-   rc =3D -EINVAL;
    goto
-        disable_resources
+        e_inval
    ;
 }
 ...+>
 return 0;
+
+e_inval:
+rc =3D -EINVAL;
 disable_resources:
 ahci_platform_disable_resources(hpriv);

@replacement2 disable neg_if, drop_else@
identifier replacement1.rc;
statement is;
@@
 if (...)
    is
 else
 {
    ... when !=3D rc
-   rc =3D -EINVAL;
    goto
-        disable_resources
+        e_inval
    ;
 }


Regards,
Markus