Received-SPF: pass (google.com: domain of linux-kernel+bounces-71653-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Hans Peter <flurry123@gmx.ch>
To: tiwai@suse.de
Cc: flurry123@gmx.ch,
	linux-kernel@vger.kernel.org,
	linux-sound@vger.kernel.org,
	tiwai@suse.com
Subject: RE: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP 840 G8 (MB 8AB8) 
Date: Mon, 19 Feb 2024 17:00:57 +0100
Message-ID: <20240219161240.3840-1-flurry123@gmx.ch>
In-Reply-To: <874je4q2h0.wl-tiwai@suse.de>
References: <874je4q2h0.wl-tiwai@suse.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:acXfCcZT+3A=;j1CvMKjM4MMwZq73kt0BvvHvLPA
 t9iKJA3KV5L0F5LDSM5XqwODh1UfmRbkirRRLyYpY9fXgWc0iv7sVqvZHNtwo+iUt6w1DcUWc
 lwz10DAW2jkUbjLIi/gHeT1fXOkSu8OghCHhJjMZGdsK84rvW4WYCH7O4xW9BBaBdZ1u3oqP6
 BeDBAk/W3pylXJFl2xNXr8uRDi16AH7XU9dKDEP/EH8s3ZfLkqtQVtZc3SEYOUyhuKkXK9Ocp
 QVhuIx0H9wsiVrXbgf1KP/AJbbygn0iX3X3ng4n9RW/L+baem1XhVUhpQLfC2YSJhzRCWqnlj
 yZL2YgtkPklU99ksgAVYMh99TlYucpPbP8xDLKY+/JZ0yju5r/IeHamid/mUsqurnDbGdnnYW
 doT+jwWjvnDX+Kku1wjlivdUmT/+Y/FEEoBJfWtjRVT/CF/njyR4VUlWzNlLfzACKYAJUJWDl
 a0nj14yri/G5E6tYbwM9qxEbnkLokLrU1j8ZjhAI88RA4vfVXC2ic1PHa+YIFtqisLPcB/jWP
 xdDs6ic6rCetrR1DkHHBfxTrp84inqsna5TYFNjgd0pExPFwMo0ianrBRTyVVQMouMQAit6Fa
 mLTOjYtPHoCrgXgxhxOv4XYHG+xPscH4oa7C1DmoVjwmOBNcMv95EwdaNhcv8tGdc0Aaw2+2k
 S0szbt6ppfA/E9EP7h+MwWatK6HKEqVbQfyv6GxV2MxHxkJoT35hf9x70Wp3fDFbOZBgnWd/s
 mnATF4KBnmz+uELEGyS4GA/HqfreUMO9Veq04FSRwD6gewbjNpHi2H08dIWK4pMRc1tiDk1+q
 iilxYnIyxuo3Of5eGnNZilwMvK8xMyvgpuQ1lWdoDCoBY=

I apologize, this is my first patch ever.

On my HP EliteBook 840 G8 Notebook PC (ProdId 5S7R6EC#ABD, built 2022 for
german market) the Mute LED ist always on. The mute button itself works as
expected. alsa-info.sh shows a different subsystem-id 0x8ab9 for Realtek
ALC285 Codec, thus the existing quirks for HP 840 G8 don't work.
Therefore, add a new quirk for this type of EliteBook.

Signed-off-by: Hans Peter <flurry123@gmx.ch>
=2D--
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 0ec1312bffd5..26a90c92c3b8 100644
=2D-- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9927,6 +9927,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[]=
 =3D {
 	SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXU=
P_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)", ALC236_FI=
XUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aab, "HP EliteBook 650 G9 (MB 8AA9)", ALC236_FI=
XUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8ab9, "HP EliteBook 840 G8 (MB 8AB8)", ALC285_FI=
XUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS3=
5L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC",=
 ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC",=
 ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
=2D-
2.43.2