Received-SPF: pass (google.com: domain of linux-kernel+bounces-71656-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Content-Type: multipart/signed;
 boundary=e43bc9b7547ba2fb2d75f0caf653f23939e188d8e14bbe063075b337bdb3;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Mon, 19 Feb 2024 17:17:26 +0100
Message-Id: <CZ96VR54894Z.TIAQI1OXCH2Z@gmail.com>
From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Pohsun Su" <pohsuns@nvidia.com>, <daniel.lezcano@linaro.org>,
 <tglx@linutronix.de>, <jonathanh@nvidia.com>
Cc: <sumitg@nvidia.com>, <linux-kernel@vger.kernel.org>,
 <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] clocksource/drivers/timer-tegra186: fix watchdog
 self-pinging.
References: <20240216210258.24855-1-pohsuns@nvidia.com>
 <20240216210258.24855-3-pohsuns@nvidia.com>
In-Reply-To: <20240216210258.24855-3-pohsuns@nvidia.com>

--e43bc9b7547ba2fb2d75f0caf653f23939e188d8e14bbe063075b337bdb3
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Fri Feb 16, 2024 at 10:02 PM CET, Pohsun Su wrote:
> This change removes watchdog self-pinging behavior.
>
> The timer irq handler is triggered due to the 1st expiration,
> the handler disables and enables watchdog but also implicitly
> clears the expiration count so the count can only be 0 or 1.
>
> Since this watchdog supports opened, configured, or pinged by
> systemd, We remove this behavior or the watchdog may not bark
> when systemd crashes since the 5th expiration never comes.
>
> Signed-off-by: Pohsun Su <pohsuns@nvidia.com>
> ---
>  drivers/clocksource/timer-tegra186.c | 27 ++-------------------------
>  1 file changed, 2 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/t=
imer-tegra186.c
> index 8f516366da86..acff97da138a 100644
> --- a/drivers/clocksource/timer-tegra186.c
> +++ b/drivers/clocksource/timer-tegra186.c
> @@ -175,7 +175,8 @@ static void tegra186_wdt_enable(struct tegra186_wdt *=
wdt)
>  		value |=3D WDTCR_PERIOD(1);
> =20
>  		/* enable local interrupt for WDT petting */
> -		value |=3D WDTCR_LOCAL_INT_ENABLE;
> +		if (0)
> +			value |=3D WDTCR_LOCAL_INT_ENABLE;

We probably shouldn't proliferate this scheme. In retrospect I should've
removed the two other similar blocks back when I submitted the driver at
the time since they don't really serve a purpose. The intention at the
time was to keep them there and eventually replace the condition with
something that could actually be toggled, but it's been almost four
years and this hasn't happened, so I suspect that we just don't need it
at all. So perhaps you could remove this line along with the comment in
this patch and then add another patch that removes the other unused bits
so that we don't carry around stuff that we just never use.

Thierry

--e43bc9b7547ba2fb2d75f0caf653f23939e188d8e14bbe063075b337bdb3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmXTfxYACgkQ3SOs138+
s6FFEg/7BXMzLKa4WV2MSGtBdio1idtwClBrHumI9gexB9N8RX7Cfcjq/SS7KAge
X9q5BpU9wfis60LnMFmfYZGXa2ml5CsjzNY0qf8t8z++eTfvFcfICMpL0ObW0kIA
ZXDpyFCGlOXEA/KD+OJT2p9HokwwfJYm1yTfvQYvDom3S45RYYP+E1nF8ouH6DCm
V08ynrpLmm3dnI5YTBP+M4PvwsRFKCNyV3dgio6t0SaVj60vGnMNISq/kn/2T5bi
01+H/usbwsWNkOM3BnXjlPqMkjugN/LfktB8a/YCeR6bLrQAi1bgBojmEOwbkueJ
FKxVmwpPZ9ZUboa1+3xMPuGJ+uH45yCCHj4F8PrL8VMhhIrOcjIIsSwhjT54PVED
k0Ge1PhY22oAFWXuMytB/CM9sXIhvp5ZBwaH4KeFll8rIJmdB/15HrPVaowYojT5
hehtorUpcYwF315sTzZ9pxaGEsMGaDWkO06YGxp5/DskgUAyhdi8wI1XwV1jCcHO
Q0VJbKooCrrzCPOa41k8BBOH9YRv3QTw9JpfCL09/fFtejJAeEm+EJWwPw05NVjr
9Vac+0EQ/FeNVo8d8/QSMoAaEYwES4PN/U2Ye92qB6/4zzny7Ao6JLutSJfx6bwD
S7/VWP11vM4eCheAy4vBhrbxBsFFSMJpKfA+FA3RpK4VfGXj4Mk=
=18jf
-----END PGP SIGNATURE-----

--e43bc9b7547ba2fb2d75f0caf653f23939e188d8e14bbe063075b337bdb3--