Received-SPF: pass (google.com: domain of linux-kernel+bounces-71661-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: multipart/signed;
 boundary=5c88819ce2d668f2ae4936a9cee5d50b46dfdf026a77d46f159ba4c5cd91;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Mon, 19 Feb 2024 17:18:46 +0100
Message-Id: <CZ96WS1F2H67.CCTTAWAZX7PF@gmail.com>
Subject: Re: [PATCH v2 1/2] clocksource/drivers/timer-tegra186: add
 WDIOC_GETTIMELEFT support
From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Pohsun Su" <pohsuns@nvidia.com>, <daniel.lezcano@linaro.org>,
 <tglx@linutronix.de>, <jonathanh@nvidia.com>
Cc: <sumitg@nvidia.com>, <linux-kernel@vger.kernel.org>,
 <linux-tegra@vger.kernel.org>
References: <20240216210258.24855-1-pohsuns@nvidia.com>
 <20240216210258.24855-2-pohsuns@nvidia.com>
In-Reply-To: <20240216210258.24855-2-pohsuns@nvidia.com>

--5c88819ce2d668f2ae4936a9cee5d50b46dfdf026a77d46f159ba4c5cd91
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Fri Feb 16, 2024 at 10:02 PM CET, Pohsun Su wrote:
[...]
> diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/t=
imer-tegra186.c
[...]
> @@ -234,12 +239,49 @@ static int tegra186_wdt_set_timeout(struct watchdog=
_device *wdd,
>  	return 0;
>  }
> =20
> +static unsigned int tegra186_wdt_get_timeleft(struct watchdog_device *wd=
d)
> +{
> +	struct tegra186_wdt *wdt =3D to_tegra186_wdt(wdd);
> +	u32 timeleft;
> +	u32 expiration;

One more thing I noticed: you could put both of these declarations on a
single line to make this a bit more compact.

Thierry

--5c88819ce2d668f2ae4936a9cee5d50b46dfdf026a77d46f159ba4c5cd91
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmXTf2YACgkQ3SOs138+
s6E30w//RlBSnLCPyQUCIOSqMYVuZUurdNauTPP7qqPY/IIOiqNIekmR+XRVjEDZ
A7pk4k1xqy8W9hfDYptB+F+3FpAgwT6Zk0kuIlD8lQgBhuHdfLXEmLyv+ZIBJJ1/
MNPXk89CIL3MDz5LDveTIVFG9jr8PO9WpPXjKFY+bN0tV/XAqAH7GKpW/ViUzE+w
dCIiN0GsH1/K8MxhOyl/juWZCAF7FpCxkWJ/CCJM5D6tQlP5qpw2bAwoFmlRD8PB
h92WRSlXCs2oiS58curADylcOvGFS8K26EJoP7vaAjGx//UiYBPrC0q1MfReROyx
Nd424Uv1jMPWbWpS4rRLwLsLTg3hlxGVHkkeXBvHtd5PF1JCvu9HXwzpIbP9X+nP
XWW0ksjeb+kQFoeXNTnYSHI8VsJXy3bnhM76U6TQZGXAOkQdF+uoP0VH1Nj9JGwo
SHSXfYWrXvVscWo1rQNDMZ6S2OmzRLpzLAr0cPQ6EEJ+cHZyFMShWMN5HwuaI4KA
Rvj24XY5z00kZFDPD7m590pqyWfbxakj9Q43oOSLMcs1B27REH1efAtiaQMIRe40
CxiFK7ayjesBpNz22hN4L9iCm0QtNcDZiiAW/f1+jq419fUkIQPox6S1h8v4C3iJ
IZ+NiKstX7lczpyFv2t3AuCfmQyHfrAt475aCitHZJGCWTvLMkA=
=ZlBV
-----END PGP SIGNATURE-----

--5c88819ce2d668f2ae4936a9cee5d50b46dfdf026a77d46f159ba4c5cd91--