Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1235420rdb; Mon, 19 Feb 2024 08:21:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUJHdM0qcOU6HQiN58cFJyXvgufPUz2JF/4LSYenWnCceQhbC9nHHXVTrJTPSEFi1Zqq7b3AwrR9wiSwDfjBkjdZhZ8iHTHq3lnSyY0dQ== X-Google-Smtp-Source: AGHT+IHblM3K8sVlWSbsTjqcgrYi5KbOOkdkIzA+kCzfoCdWKrkUo3w/Zu5rK4D6NLbsUu39sEyt X-Received: by 2002:a05:6e02:1567:b0:365:2f29:a98f with SMTP id k7-20020a056e02156700b003652f29a98fmr4799231ilu.15.1708359717285; Mon, 19 Feb 2024 08:21:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708359717; cv=pass; d=google.com; s=arc-20160816; b=uxHt7Yt91qOOoiABskMvKAzg9v2hvjrqltmj4rkWMDr0XbNxjJkykmFhY1Pvd4LPyd yXjiBZvv8MdM53D+iRNidRL1DqF2FsLP2OkG82vtfZ5Mo+8pQx9GyjFtBUmaDMUdKefF KRHQb1XoyO1Dnf5lps2csZjq/QJKFkQSdYXXaMlaHyZbOyLDAH1id560v/SvHs3mQrLm 1p9K0bjX9f6CANwqKaOOp2fhT9zj30fcEjoNAjyFuqvX/Q2Ik7Se9BTeeuuafLmCa3ol lkJOvM4MhjcIRyxHnAQ6hxSvZaxxwYbYtTsDOC6dat1CYhP4eqxueXqn7mVSJVfKexYV G5eQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:cc:references:in-reply-to :from:organization:dkim-signature; bh=6KnJ0wJsYP4PPL5k3hrJckmE7GZOMlUN8YoSAyFXLQA=; fh=Em5XtkH5tJowfSz9RlsJR57hUFqc8O9sBdZImLzmQaU=; b=eZ29bshxv4yXhDMJiOQjTur9eEfLsWn9s7UO0Yzlf7zdIUHYUcONP5PfBBQ1hj8Of9 JqIukfUIGvZUNx0qV6Uo6ez/bce8nHBp9S1Qlsyq93ADh2TtvPki3WphXjWUbcFRSr7m 7ItOLI0wMMybu+SLbbyZlKQLx+gMWOUOwB7ILksCUXm+YqZ+wrkvzIJvBDmqQyRCnvLr AO1GXbTkngqLP0Sq8jaoV/9L4sDot5DhSPh/kVXLm1sfeSzFt6CxCgqQs9YZFYABDzOh 3t4SRfct5guLNp7pw7klf85aWiNyS7U2a65KooROmkSlZCZdkhDXRl3jHJas82HlCskB /1Kg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Qe7RHQof; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-71651-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71651-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l4-20020a63ba44000000b005c658bf30aasi4765298pgu.412.2024.02.19.08.21.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 08:21:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71651-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Qe7RHQof; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-71651-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71651-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6BC6D28745C for ; Mon, 19 Feb 2024 16:12:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3DF023DBB7; Mon, 19 Feb 2024 16:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qe7RHQof" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F277A3D54F for ; Mon, 19 Feb 2024 16:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708359144; cv=none; b=aXhsHVjiUy9UbHGge5+y30bnKJL244cqLN0/C+Nwk1ejo7Vpi/9UAphRTyg+ii5kOeXa0ZWT0FJRou29OuxL/5ZRrnJ33OQ0muw36jCCnPT1UVZTiS1lEIchh/HtKWSff8MP5xIldaSREw4SYSpxcKSwIU4vshVAHObw7RbvU5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708359144; c=relaxed/simple; bh=6KnJ0wJsYP4PPL5k3hrJckmE7GZOMlUN8YoSAyFXLQA=; h=From:In-Reply-To:References:Cc:Subject:MIME-Version:Content-Type: Date:Message-ID; b=qWwkJq+msKEoUAIcCi66CZ+F/1vGWA0AC7mAs0fcCpY+X+QqFksy73SjRsFlBB3LaSiZgxH0NEIH1ctCQ/awb/UZ2HBKuLtK/yFkpr2cyiRwMUI6KBYErHUPtIu7YhlNtIWU+mc/H47hHEmLI09zsTfh2vf/0G3pvo0KkC0+mcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Qe7RHQof; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708359141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6KnJ0wJsYP4PPL5k3hrJckmE7GZOMlUN8YoSAyFXLQA=; b=Qe7RHQofIjf/+bYDCoge0As8MYxAytx6wXMM3L/HwB9BUEK2pAvTnDwDPvAjOtRCBOmlxp Rp1KO626z7WC2jf/V/ksq36tSVuAYTCNIHAQbdgfKlsTAzCLAp91W+Wo8YqIVpVoGOYjdl zCiK7+KLzpOBYFxVFKSAwLNplfDS5p0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-dv6PHkUGNxe-PkviZ87TXQ-1; Mon, 19 Feb 2024 11:12:17 -0500 X-MC-Unique: dv6PHkUGNxe-PkviZ87TXQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B6AB2185A781; Mon, 19 Feb 2024 16:12:16 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 01DEB492BC6; Mon, 19 Feb 2024 16:12:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <187507.1708357334@warthog.procyon.org.uk> References: <187507.1708357334@warthog.procyon.org.uk> <187136.1708356611@warthog.procyon.org.uk> <20240205225726.3104808-1-dhowells@redhat.com> Cc: dhowells@redhat.com, Steve French , Jeff Layton , Matthew Wilcox , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Christian Brauner , netfs@lists.linux.dev, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 00/12] netfs, cifs: Delegate high-level I/O to netfslib Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <229264.1708359134.1@warthog.procyon.org.uk> Date: Mon, 19 Feb 2024 16:12:14 +0000 Message-ID: <229265.1708359134@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 David Howells wrote: > so the reversion is probably unnecessary. Removing the iov_iter_revert() fixes the problem. David