Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1235461rdb; Mon, 19 Feb 2024 08:22:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVz5RoXwdoCJvB8X83nf1eyu9noaCEMFo0v5WTo+/GzzspP9YmGxnwk9tp3s+XchHPlvuroMcD6AoFqFk49g+I2rnx0CcpRPp1HaHkaYA== X-Google-Smtp-Source: AGHT+IHsgEJ+8ZoT8iMLIOT4dVUQubD1PRWUw0FFb83KL/j/MPFA5ehvSibMJdyk1L6ZtREVv1+7 X-Received: by 2002:a05:6a21:3a94:b0:1a0:694c:c467 with SMTP id zv20-20020a056a213a9400b001a0694cc467mr21519016pzb.14.1708359723046; Mon, 19 Feb 2024 08:22:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708359723; cv=pass; d=google.com; s=arc-20160816; b=TdCjicC+FuFHvAsi5gTJcaiu028CvfrXjRMj+yVHmFsmaOpoKALvDp1IwX+oiyi47B r1YDfe3Qr/Jmp1uJcw+WHgCnGPYZ7g7wt7AAg/Hd0zli3XkbM4hg1g3tNH3xYhmYCU5c sd5OsIb1bZtjAZUowwtqvT2WmQotncY74H8npeFlzhIJKSTK2uTC9rrlCvYDF5VoJY4/ izC+yfB8yR417y8/uwWg8x9HBNp4+RvRyF6wK9xssR1IplMMgfS2mM4NKSWncFupsVtX 3DRdYcHaawJ+1GnNDa6KDpJnEuf+isi6pfQRFIAxxVNecHN0aSDprNBOJSPP/VHRGvoq 1BGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:cc:to:references :in-reply-to:from:organization:dkim-signature; bh=Qw1Zo0E33/fdGs8X8g9v7Lf2Wcxxz6qcLyaGW55/s6Y=; fh=yEijYbzpCEXoG2lgClUy8rX9AhsIcIVLtByI1rAaPzE=; b=f7HI5ZTG5H7c4yF8Qg2NeVT02MNq7jBFDIEQhOfdIA77gEzsdpLj0bVwUOlvuYRHAa 0eN7wWry01IdDEuIVDIgdH5uEykj2znkrwMqFBsSpeeryq9Ymr4lbrSb/Nfe/p6U/DVO VdEYf5QlqfSYP8rR6nhT9tyXxsjA5uvm8DTy1jRCVxraI+CQcTFjZDjKbexKZ175AKbG 9OdcMlsni7nZKvaD0sexpLkwtI6nhs/MB199M4ZUzdSWmpciCIIp9rNinPvmTD857bzc ACStIENKsqsA+u2Or/vkEta66pv3s/uhfX0TvYcNIgNIiQg2a+6pAIVrUj5lJLzg2Ov6 Mn4g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LYHqNiE2; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-71652-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71652-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a26-20020a637f1a000000b005ceca1094c3si4599810pgd.853.2024.02.19.08.22.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 08:22:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71652-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LYHqNiE2; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-71652-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71652-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 101262879F2 for ; Mon, 19 Feb 2024 16:13:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4F2433CF56; Mon, 19 Feb 2024 16:13:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LYHqNiE2" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE9993CF53 for ; Mon, 19 Feb 2024 16:12:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708359179; cv=none; b=GIgyD3Exy6iGz0JJlkwXclNBLB4V37B3MSCQbE4inC77SmH3HB1jhpevJ+MBeG88NfVFCPAccFeE3JPhgqoazYDr2wcWiw0l37QLxfBcVE5TGQMC6APNKucPPcUMmeqTSZD61JgRxbSwBNO8olBTLCrmexnDEreK+F1tQJSD3ZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708359179; c=relaxed/simple; bh=TEbeuKi1D4WwK34OueQCHICSRhZ5+jaTYtBPp4NOkog=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=tIsZFLMZtFN84MlMJrbjK2bN3BuD1NyvUZlXi+3IP6gkL65C/v5EgQQGsHR3A8jErq6OWUEt1YIz7NuWv4bhL8vh/XHLi6tfqQy/ZB5pzj4W1FjLM8WPpeRsEipBztGgCVSdf3gWHvQymW/8YFUPzTbSewolSDMsS8G4bvuqbww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LYHqNiE2; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708359176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qw1Zo0E33/fdGs8X8g9v7Lf2Wcxxz6qcLyaGW55/s6Y=; b=LYHqNiE2/BMrF+3EVe4nctYc9Ew6wIgEPhNxECy/AmTqB/GaVfxLkA4p/yf8wjDkp9HmUz TdF69HoOyN/G8SQ4V+8Lj+dbJSuftXbIjKnl1kM6qKWhKrew9yZFox/0nCnOAchQH14kia I78TQkJZjYfuodgO+S+LsfWcdqNpHAA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-3bJK7h8bOYeO_1GkDHJOeg-1; Mon, 19 Feb 2024 11:12:52 -0500 X-MC-Unique: 3bJK7h8bOYeO_1GkDHJOeg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B26D2882087; Mon, 19 Feb 2024 16:12:51 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0EFA71121306; Mon, 19 Feb 2024 16:12:48 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240209105947.GF1516992@kernel.org> References: <20240209105947.GF1516992@kernel.org> <20240205225726.3104808-1-dhowells@redhat.com> <20240205225726.3104808-10-dhowells@redhat.com> To: Simon Horman Cc: dhowells@redhat.com, Steve French , Jeff Layton , Matthew Wilcox , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Christian Brauner , netfs@lists.linux.dev, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Steve French , Shyam Prasad N , Rohith Surabattula Subject: Re: [PATCH v5 09/12] cifs: Cut over to using netfslib Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <229304.1708359168.1@warthog.procyon.org.uk> Date: Mon, 19 Feb 2024 16:12:48 +0000 Message-ID: <229305.1708359168@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Simon Horman wrote: > Nit: this hunk would probably be better placed in the > patch at adds cifs_req_ops to fs/smb/client/file.c I've moved that to the patch that adds cifs_req_ops. David