Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1239194rdb; Mon, 19 Feb 2024 08:28:36 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUbnEMXLfu/8RVA+YWeQ22cwVz2LbNY32/YI0oqS0cDlCIZEWe8Wn1Y5ZiH4i/2aJXeiBxrvW6in/nguJ7OVBeR9n0nlbRbNSNnKypPXA== X-Google-Smtp-Source: AGHT+IHufmjNyKhVvUgcLnPfoYzopF5lXiiEKLXbcjAiby0jeW/5fd5XqgBWh/NPhaeLLB4XyXH8 X-Received: by 2002:a17:906:13d3:b0:a3e:b0b4:a838 with SMTP id g19-20020a17090613d300b00a3eb0b4a838mr1800300ejc.39.1708360116481; Mon, 19 Feb 2024 08:28:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708360116; cv=pass; d=google.com; s=arc-20160816; b=ujrQjBwQK9WHW95hA/Q0x0Z5b1hGsMWiW84E8WL7IoTjDATW56YeJpuDUShtIwxVIT f2nnVqxuunqRxUdYyg0O5X9a9DkjeVzrnG2ZvcYMA0eOGmbaH0fzVJUZGPJu9S46jpR0 26K5PU/uN9MgUN6V1BkW62LhlCk4fpXx2+o1WrK9JNxXQMKFnqqYkQsB5ax3zLw8tedR yraSAdr/JIGT9yff1IYRdFjEYV/2NSSFBrGnbf0qVP2Z7WuDFQMq0aQT+UC+kEgzdH0f MMg+/bEJXuXR0xeV04OTJVea8/X9AWZsfEonmGBFpBUIeFfyUaOarcSinv91t8rv0gBW YlhA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:in-reply-to:subject:cc:to:from:message-id :date:dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=13HhidbPpoIts7Hq4/4TUjOdAZJMflmnTuIfI0fm7Qw=; fh=mlXySnSoP42JNGOrWGc0tRt+HC5VCdWvfAsSLjzZzcE=; b=reMK7Du9WLYl627ra6QMbPYZ8FXTA2cyp41UUC6A51MkmwfrHHS1JRg++Qpy7i/InY tMOWE7gOeDrOKOKfokLr8AsbTuczjOR9J46zZ1ZbbjorBh/vGD9yE5aEa/XKcSm3KAWU 99hVuVIF0k3kKyhBcAKos2S7Ze0dUuXTOIJOnUcfPf0o95UdFiowJWCvFKHO8hxxtqHS YsYli3RMRJCWqMxZNHjloldffaObsckmSggvMJgV1enuDywKGZhTBeAHiOFdDQESZsT4 veZtGafUmDMSAc73xq3hlmrS4bdF9DszhmO5R82Q8Q3gRG8WzWAjUq/hi0fBPSaGTacc KTMQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=rzYDlyl2; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=rzYDlyl2; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-71682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71682-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id si5-20020a170906cec500b00a3d14566c9bsi2610115ejb.169.2024.02.19.08.28.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 08:28:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=rzYDlyl2; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=rzYDlyl2; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-71682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71682-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 27D841F21E1F for ; Mon, 19 Feb 2024 16:28:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0DFDF3F8CA; Mon, 19 Feb 2024 16:28:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rzYDlyl2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5sanQCU8"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rzYDlyl2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5sanQCU8" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D42A3D54E; Mon, 19 Feb 2024 16:28:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708360087; cv=none; b=eQjKMZZUdFRMQ3wPcFuh7jW8nne6+Fjw5Ixk9m54gThAqqXEhM3KhkL0cBHIcOnAMhFgjLWW0Nrrx7FDjTlkQu+7KtyXHkEfufdBcdL0GL07XNT5n34z41WRr3qWY0oyNZrL3VcDSlSFSwJkCUm+2aCcfJX3y06Z7/4yzgXSzvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708360087; c=relaxed/simple; bh=wenKmRMWCQcXIEBiuJKWht34XyvUOfgSErz+melCPE8=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=t+BtHDbvDA4oL1ulMgP3ZCjE/YExukHG/OABS6kEYTW84AAJQwkG/eNih5zU1/bf2DZ1eLJx/vob8zmq1ZrGd2FQDcHpVY1ol0v6KIPNVszIG0mPKhFNCaz4ymYw9Hz4Hn8wk1gGqA+f1IqnM/m/2eKTBgEKGpQW5Xff9KVIQck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rzYDlyl2; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5sanQCU8; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rzYDlyl2; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5sanQCU8; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4A77A1F806; Mon, 19 Feb 2024 16:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708360083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=13HhidbPpoIts7Hq4/4TUjOdAZJMflmnTuIfI0fm7Qw=; b=rzYDlyl2OF28oP51oMd8AJmVnJIxcqqdLJCF8TTBp4gY6p2ZKWtaVS/QgYSblcjQiYYTaQ 4btKOc5uT5toqCG4gDNutEJt+YtdcHRPnbR/TxcvHJn58ruVeulM+21Q/46B2G2Y944MCi rHB8+p4iDY6hkM86Wr5BB9j51nycMyw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708360083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=13HhidbPpoIts7Hq4/4TUjOdAZJMflmnTuIfI0fm7Qw=; b=5sanQCU8YvYZCdwwcCfedyarzaOWOI5NQPO1FkTG8fvtgZEWH+uJpi/jl6kWgZFg2KVxAE Px/UU7HncS10oVDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708360083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=13HhidbPpoIts7Hq4/4TUjOdAZJMflmnTuIfI0fm7Qw=; b=rzYDlyl2OF28oP51oMd8AJmVnJIxcqqdLJCF8TTBp4gY6p2ZKWtaVS/QgYSblcjQiYYTaQ 4btKOc5uT5toqCG4gDNutEJt+YtdcHRPnbR/TxcvHJn58ruVeulM+21Q/46B2G2Y944MCi rHB8+p4iDY6hkM86Wr5BB9j51nycMyw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708360083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=13HhidbPpoIts7Hq4/4TUjOdAZJMflmnTuIfI0fm7Qw=; b=5sanQCU8YvYZCdwwcCfedyarzaOWOI5NQPO1FkTG8fvtgZEWH+uJpi/jl6kWgZFg2KVxAE Px/UU7HncS10oVDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 14B26139D0; Mon, 19 Feb 2024 16:28:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id l0GaA5OB02X4fwAAD6G6ig (envelope-from ); Mon, 19 Feb 2024 16:28:03 +0000 Date: Mon, 19 Feb 2024 17:28:02 +0100 Message-ID: <871q98o1v1.wl-tiwai@suse.de> From: Takashi Iwai To: Hans Peter Cc: tiwai@suse.de, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, tiwai@suse.com Subject: Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP 840 G8 (MB 8AB8) In-Reply-To: <20240219161240.3840-1-flurry123@gmx.ch> References: <874je4q2h0.wl-tiwai@suse.de> <20240219161240.3840-1-flurry123@gmx.ch> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [1.38 / 50.00]; ARC_NA(0.00)[]; SUBJECT_ENDS_SPACES(0.50)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmx.ch]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[alsa-info.sh:url,gmx.ch:email]; FREEMAIL_TO(0.00)[gmx.ch]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.02)[52.91%] X-Spam-Level: * X-Spam-Score: 1.38 X-Spam-Flag: NO On Mon, 19 Feb 2024 17:00:57 +0100, Hans Peter wrote: > > I apologize, this is my first patch ever. > > On my HP EliteBook 840 G8 Notebook PC (ProdId 5S7R6EC#ABD, built 2022 for > german market) the Mute LED ist always on. The mute button itself works as > expected. alsa-info.sh shows a different subsystem-id 0x8ab9 for Realtek > ALC285 Codec, thus the existing quirks for HP 840 G8 don't work. > Therefore, add a new quirk for this type of EliteBook. > > Signed-off-by: Hans Peter Thanks, now it's better, but could you rather resubmit without hanging on an existing thread? Keep the subject without reply prefix (at best put "v2" in the patch prefix, e.g. [PATCH v2] ALSA: hda/realtek: ... Takashi