Received-SPF: pass (google.com: domain of linux-kernel+bounces-71711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 19 Feb 2024 17:53:23 +0100
From: Maxime Ripard <mripard@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Frank Binns <frank.binns@imgtec.com>, 
	Matt Coster <matt.coster@imgtec.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, 
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, 
	Daniel Vetter <daniel@ffwll.ch>, Sarah Walker <sarah.walker@imgtec.com>, 
	"dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
	Javier Martinez Canillas <javierm@redhat.com>, Nishanth Menon <nm@ti.com>, 
	Marek Vasut <marek.vasut@mailbox.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3
Message-ID: <olsxsviy5w2guinmc33mqtqn36kakanf6i644nzuk5d7mp2ywt@cn5zhr6qxcgy>
References: <CAHCN7xJ65RP8TO7cS0p5DwE6zru5NEF0_JA+8siT_OpSeLD7pA@mail.gmail.com>
 <CAHCN7x+EnSU8qk5dBFco=0vkeknGq18qEN7vFmZs0_q83T_3+w@mail.gmail.com>
 <CAHCN7xKffJ29zyjoJVAcy3b_d=-zkFzbL=URj4yWJWzYvRdB_Q@mail.gmail.com>
 <TYCPR01MB11269CBE8429A31DE5002A5A5864C2@TYCPR01MB11269.jpnprd01.prod.outlook.com>
 <nzrkujogauvn262ucxippwidyub6ikcohcjpbpn4hzj7rymctm@4owntgrmcquf>
 <TYCPR01MB11269CBAA20275E11D9AD6500864C2@TYCPR01MB11269.jpnprd01.prod.outlook.com>
 <wxwad77x2mxhhwdsbgiytzn6x54t4sywodjhzefwldo277njiz@ru7z54wxgelu>
 <CAHCN7xJi-6W6x+OJmkNwOX45SM4WHD5zkN42ZOp8ZxFnp3YL5w@mail.gmail.com>
 <TYCPR01MB11269B2104687F091CFA3405F86512@TYCPR01MB11269.jpnprd01.prod.outlook.com>
 <CAHCN7x+BVYoeDC+Rt4PV-dxyMZ-0GyYfiRcXwmVWwursz5NAfg@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="n34ceiql5xopfxiw"
Content-Disposition: inline
In-Reply-To: <CAHCN7x+BVYoeDC+Rt4PV-dxyMZ-0GyYfiRcXwmVWwursz5NAfg@mail.gmail.com>


--n34ceiql5xopfxiw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 19, 2024 at 10:38:12AM -0600, Adam Ford wrote:
> On Mon, Feb 19, 2024 at 1:45=E2=80=AFAM Biju Das <biju.das.jz@bp.renesas.=
com> wrote:
> >
> > Hi Adam,
> >
> > > -----Original Message-----
> > > From: Adam Ford <aford173@gmail.com>
> > > Sent: Sunday, February 18, 2024 11:26 PM
> > > Subject: Re: RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should d=
epend
> > > on ARCH_K3
> > >
> > > On Fri, Feb 16, 2024 at 8:14=E2=80=AFAM Maxime Ripard <mripard@kernel=
=2Eorg> wrote:
> > > >
> > > > On Fri, Feb 16, 2024 at 09:13:14AM +0000, Biju Das wrote:
> > > > > Hi Maxime Ripard,
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Maxime Ripard <mripard@kernel.org>
> > > > > > Sent: Friday, February 16, 2024 9:05 AM
> > > > > > Subject: Re: RE: [PATCH v2] drm/imagination: DRM_POWERVR should
> > > > > > depend on
> > > > > > ARCH_K3
> > > > > >
> > > > > > On Fri, Feb 16, 2024 at 08:47:46AM +0000, Biju Das wrote:
> > > > > > > Hi Adam Ford,
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Adam Ford <aford173@gmail.com>
> > > > > > > > Sent: Thursday, February 15, 2024 11:36 PM
> > > > > > > > Subject: Re: [PATCH v2] drm/imagination: DRM_POWERVR should
> > > > > > > > depend on
> > > > > > > > ARCH_K3
> > > > > > > >
> > > > > > > > On Thu, Feb 15, 2024 at 11:22=E2=80=AFAM Adam Ford <aford17=
3@gmail.com>
> > > wrote:
> > > > > > > > >
> > > > > > > > > On Thu, Feb 15, 2024 at 11:10=E2=80=AFAM Adam Ford
> > > > > > > > > <aford173@gmail.com>
> > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > On Thu, Feb 15, 2024 at 10:54=E2=80=AFAM Geert Uytterho=
even
> > > > > > > > > > <geert@linux-m68k.org> wrote:
> > > > > > > > > > >
> > > > > > > > > > > Hi Maxime,
> > > > > > > > > > >
> > > > > > > > > > > On Thu, Feb 15, 2024 at 5:18=E2=80=AFPM Maxime Ripard
> > > > > > > > > > > <mripard@kernel.org>
> > > > > > > > wrote:
> > > > > > > > > > > > On Thu, Feb 15, 2024 at 01:50:09PM +0100, Geert
> > > > > > > > > > > > Uytterhoeven
> > > > > > > > wrote:
> > > > > > > > > > > > > Using the Imagination Technologies PowerVR Series=
 6
> > > > > > > > > > > > > GPU requires a proprietary firmware image, which =
is
> > > > > > > > > > > > > currently only available for Texas Instruments K3
> > > > > > > > > > > > > AM62x SoCs.  Hence add a dependency on ARCH_K3, to
> > > > > > > > > > > > > prevent asking the user about this driver when
> > > > > > > > > > > > > configuring a kernel without Texas Instruments K3
> > > > > > > > Multicore SoC support.
> > > > > > > > > > > >
> > > > > > > > > > > > This wasn't making sense the first time you sent it,
> > > > > > > > > > > > and now that commit log is just plain wrong. We have
> > > > > > > > > > > > firmwares for the G6110, GX6250, GX6650, BXE-4-32, =
and
> > > > > > > > > > > > BXS-4-64 models, which can be found on (at least)
> > > > > > > > > > > > Renesas, Mediatek, Rockchip, TI and StarFive, so
> > > > > > > > > > > > across three
> > > > > > > > > > >
> > > > > > > > > > > I am so happy to be proven wrong!
> > > > > > > > > > > Yeah, GX6650 is found on e.g. R-Car H3, and GX6250 on=
 e.g.
> > > > > > > > > > > R-Car M3-
> > > > > > > > W.
> > > > > > > > > > >
> > > > > > > > > > > > architectures and 5 platforms. In two months.
> > > > > > > > > > >
> > > > > > > > > > > That sounds like great progress, thanks a lot!
> > > > > > > > > > >
> > > > > > > > > > Geert,
> > > > > > > > > >
> > > > > > > > > > > Where can I find these firmwares? Linux-firmware[1]
> > > > > > > > > > > seems to lack all but the original K3 AM62x one.
> > > > > > > > > >
> > > > > > > > > > I think PowerVR has a repo [1], but the last time I
> > > > > > > > > > checked it, the BVNC for the firmware didn't match what
> > > > > > > > > > was necessary for the GX6250 on the RZ/G2M.  I can't
> > > > > > > > > > remember what the corresponding R-Car3 model is.  I
> > > > > > > > > > haven't tried recently because I was told more
> > > > > > > > > > documentation for firmware porting would be delayed unt=
il
> > > everything was pushed into the kernel and Mesa.
> > > > > > > > > > Maybe there is a better repo and/or newer firmware some=
where
> > > else.
> > > > > > > > > >
> > > > > > > > > I should have doubled checked the repo contents before I
> > > > > > > > > sent my last e-mail , but it appears the firmware  [2] for
> > > > > > > > > the RZ/G2M, might be present now. I don't know if there a=
re
> > > > > > > > > driver updates necessary. I checked my e-mails, but I did=
n't
> > > > > > > > > see any notification, or I would have tried it earlier.
> > > > > > > > > Either way, thank you Frank for adding it.  I'll try to t=
est
> > > when I have some time.
> > > > > > > > >
> > > > > > > >
> > > > > > > > I don't have the proper version of Mesa setup yet, but for
> > > > > > > > what it's worth, the firmware loads without error, and it
> > > doesn't hang.
> > > > > > >
> > > > > > > Based on [1] and [2],
> > > > > > >
> > > > > > > kmscube should work on R-Car as it works on RZ/G2L with panfr=
ost
> > > > > > > as earlier version of RZ/G2L which uses drm based on RCar-Du,
> > > > > > > later changed
> > > > > > to rzg2l-du.
> > > > > >
> > > > > > IIRC, the mesa support isn't there yet for kmscube to start.
> > > > >
> > > > > What about glmark2? I tested glmark2 as well.
> > > >
> > > > It's not really a matter of kmscube itself, but the interaction with
> > > > the compositor entirely. You can run a headless vulkan rendering, b=
ut
> > > > an application that renders to a window won't work.
> > >
> > > I have made a little progress.  I have Ubuntu running on an RZ/G2M (R=
ogue
> > > GX6250) with a device tree configuring the GPU and the GPU loads with
> > > firmware.
> > >
> > >   powervr fd000000.gpu: [drm] loaded firmware
> > > powervr/rogue_4.45.2.58_v1.fw
> > >   powervr fd000000.gpu: [drm] FW version v1.0 (build 6513336 OS)
> > >   [drm] Initialized powervr 1.0.0 20230904 for fd000000.gpu on minor 0
> > >
> > > drmdevice lists card0 and renderD128
> > > --- Checking the number of DRM device available ---
> > > --- Devices reported 2 ---
> > > --- Retrieving devices information (PCI device revision is ignored) -=
--
> > > device[0]
> > > +-> available_nodes 0x05
> > > +-> nodes
> > > |   +-> nodes[0] /dev/dri/card0
> > > |   +-> nodes[2] /dev/dri/renderD128
> > > +-> bustype 0002
> > > |   +-> platform
> > > |       +-> fullname /soc/gpu@fd000000
> > > +-> deviceinfo
> > >     +-> platform
> > >         +-> compatible
> > >                     renesas,r8a774a1-gpu
> > >                     img,img-axe
> > >
> > > There is more to this dump, but it seems to repeat. I wanted to show =
that
> > > it seems like it's trying to work.
> > >
> > > I think I need to modify the powervr code in mesa to recognize the
> > > renesas,r8a774a1-gpu and associate it with the rcar-du, but I am not =
sure,
> > > and I am hoping someone might be able to provide some guidance, since=
 I
> > > think I am missing something somewhere. I modified pvr_device.c in the
> > > mesa driver to attempt do this:
> > >
> > > /* This is the list of supported DRM render/display driver configs. */
> > > static const struct pvr_drm_device_config pvr_drm_configs[] =3D {
> > >    DEF_CONFIG("mediatek,mt8173-gpu", "mediatek-drm"),
> > >    DEF_CONFIG("ti,am62-gpu", "ti,am625-dss"),
> > >    DEF_CONFIG("renesas,r8a774a1-gpu", "rcar-du"), };
> > >
> > > When I run modetest -M rcar-du, I can see the encoders and connectors=
 and
> > > I can display test patterns, so the rcar-du is working.
> > >
> > > I built Mesa 24.0.1 with the following options:
> > >
> > > meson setup builddir -Dvulkan-drivers=3Dimagination-experimental
> > > -Dimagination-srv=3Dtrue -Dtools=3Dall -Dgallium-drivers=3Dzink,kmsro=
,swrast
> > >
> > > I have tried to set PVR_I_WANT_A_BROKEN_VULKAN_DRIVER=3D1 the Mesa
> > > documentation for the powerVR, and I have exported the variable for
> > > VK_ICD_FILENAMES to point to the powervr json file.
> > >
> > > when I try to run glmark2-drm, I was expecting the GL reddered to be =
the
> > > powervr, but it keeps using the
> > > GL_RENDERER:    llvmpipe (LLVM 15.0.7, 128 bits)
> > >
> > > I realize this driver is still in its infancy, but I was hoping someo=
ne
> > > could give me some guidance to let me know if the work to do is on the
> > > Mesa side or the rcar-du driver side, or something else.
> > >
> > > I rebuilt both libdrm and mesa.  While I don't get any errors, I also
> > > don't get the hardware acceleration I was hoping for.
> > >
> > > I even tried  PVR_I_WANT_A_BROKEN_VULKAN_DRIVER=3D1
> > > MESA_LOADER_DRIVER_OVERRIDE=3Dzink MESA_DEBUG=3Dcontect glmark2-drm
> > >
> > > ...but it only renders with llvmpipe
> > >
> > >     glmark2 2023.01
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D
> > >     OpenGL Information
> > >     GL_VENDOR:      Mesa
> > >     GL_RENDERER:    llvmpipe (LLVM 15.0.7, 128 bits)
> > >     GL_VERSION:     4.5 (Compatibility Profile) Mesa 24.0.1
> > >     Surface Config: buf=3D32 r=3D8 g=3D8 b=3D8 a=3D8 depth=3D32 stenc=
il=3D0 samples=3D0
> > >     Surface Size:   3840x2160 fullscreen
> > >
> > >
> > > I am not as familiar with the Mesa side, but if I can get this workin=
g to
> > > a point where something is rendered, even if it's not 100% compliant,=
 I'd
> > > like to push patches to the kernel and/or Mesa if necessary.
> >
> > FYI, the glmark2 I tested on RZ/G2L with panfrost is with wayland windo=
w system [1].
> >
> > Maybe there should be an panfrost equivalent package for powevr is avai=
lable in mesa??
> > That is the only difference w.r.to panfrost.
> >
> > PACKAGECONFIG_append_pn-mesa =3D " egl kmsro panfrost"
> >
>=20
> I am not using Yocto, because I am using Ubuntu, but I have build Mesa
> per the instructions they provided, but the glue that connects the
> powervr to the rcar-du isn't as clear.  I looked at the panfrost
> implementation, but I didn't see anything obvious.   It looks like the
> panfrost integrates with the kms driver, which I was rather expecting
> powervr would do.  I can tell the mesa library is build built and
> loaded but it's not attempting to use it for some reason

I think the reason is what Matt was hinting at: the driver doesn't
support OpenGL at the moment, and you're trying to use an OpenGL
application.

Maxime

--n34ceiql5xopfxiw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZdOHggAKCRDj7w1vZxhR
xfIaAP41zvmkOPFe3gc+9fStEHohe5m5PkqcyJbHnJBNYpZBFwEA1ZzPg6dJj6Gv
Bbh4YQUUzMoS+3Yy2oLL9CRVF52LpgY=
=QFmn
-----END PGP SIGNATURE-----

--n34ceiql5xopfxiw--