Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1252924rdb; Mon, 19 Feb 2024 08:54:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVqr8nrZfI0njZUFy5oTSjQdBFHc6SGSYKuihYgafwnTiEtMfI7VrHC6Q5x0NAl48cp3O1ZGxiEtM0DuKaR9bJRUBZkR88J9vEHkwbL1w== X-Google-Smtp-Source: AGHT+IGLI/g5Ex9vTMGNUV6S9L1boRBh5pcdghBGxwcpDa8YDi2RJP3S9tiEgX6Klbl0PFB/cE0j X-Received: by 2002:a05:620a:3956:b0:787:2bc5:b455 with SMTP id qs22-20020a05620a395600b007872bc5b455mr15983443qkn.6.1708361655185; Mon, 19 Feb 2024 08:54:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708361655; cv=pass; d=google.com; s=arc-20160816; b=YGD1T1MrBxSJwmofq6FDxVjNgVubUZIBdf0ynyJiPzQB81OKL0y6JP49r0ydjTjVpV m90Y1Y6v8qb0wXdNeV9JSUPlfEE5hRA2F48qcS4xAiRozocfDavJzWoOq3O/OpVCFVA8 vbk+2Xk0ieaYrxg635IUyqJyRHk5fIFGUZtruuirCKenNdUGb7rwadtWg4fZlV+tZZ1K gBPxzU+IzMrIWhFZeBCZv3+kTxffFpw0qyoZ19irYtR78SNT3puaKd2D0tafa+a4mrJt 4owWqIFlY1CHrXgHMAbQXKhtqGWbyE+CncTZ6o43QlJK8QcmHy+iVLXLo3AONyhsgn4v 0CxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=jNG2UBlz0AARR7JcjYI2bdU4AslUQ5qXdKsNm7iVCJY=; fh=PUnrZv8ysi7lx0ujto8Y9HeR5qVjwtPmGz2n1+n0Q14=; b=TOCNw81dvwhBOS2g23oJft+MUzCTBWPcEGAeNkJdNQp5DH3nXWgyOFpWx5JM9F7WQG 1VY6GuwImMdWzzQGsvK4JAiZrufg8JJ8HDG0iwsmB2zb6uYiSgbl730OnovHPEAXHdrM YeVlp3t2pFX/jWsosmqiTnLXlw/TIh9C2nhLlsMy6MbEKhoJsFPGI5nG4WzORfeW7VXK AL+4i9UHP3ZtzUw2fbSloFwIh8oOLsUKJWaPfvPk+zdf6CF7sSfvqtG+oApoLi6knTcl ML0gRiJ762uX+dgHeTcK+h+WFlx8vH4YKQvuAwZqdDTEj7apKr02dOUEYLUyVG7plGD5 aPyw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-71714-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71714-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t15-20020a05620a0b0f00b007872df79a97si6365155qkg.273.2024.02.19.08.54.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 08:54:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71714-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-71714-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71714-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DF9171C229D2 for ; Mon, 19 Feb 2024 16:54:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EB3D14438A; Mon, 19 Feb 2024 16:53:54 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F32464437E for ; Mon, 19 Feb 2024 16:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708361634; cv=none; b=AVurDfC8catdZ2sDzMKeBEbVssas+NtUgxdmv/dwCtJ+WOBoElhZGowGGNdRrrjZdfZ7hq35O0qZwctu2M+/8vTYCLyjgpADyaY7zrb/PX6vzGQPeS+WOSsWtUgUNRUyDfMMrBXSF/r3hAtfHemgHA45IbqP6heg5rlq8qvPFMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708361634; c=relaxed/simple; bh=jNG2UBlz0AARR7JcjYI2bdU4AslUQ5qXdKsNm7iVCJY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CmNNdRE3oAj0ZO2Qc7I0oQ64oh1AemYbm1xlJ/tBbtY6MssRaKNSlV2zxYdP466aSdHTL41U4j7sJyzV7aSxP/L4K9gdv+OFdz+br88+f755jNWxZKKjwPHlcESyZ7X7Hua9aTs6r20/yOb2suOoL/B6Q+4h3pNPulOoKggvctE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D59B91042; Mon, 19 Feb 2024 08:54:31 -0800 (PST) Received: from [10.1.197.60] (eglon.cambridge.arm.com [10.1.197.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 09A6C3F762; Mon, 19 Feb 2024 08:53:47 -0800 (PST) Message-ID: Date: Mon, 19 Feb 2024 16:53:47 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 02/24] x86/resctrl: kfree() rmid_ptrs from resctrl_exit() Content-Language: en-GB To: Reinette Chatre , x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand References: <20240213184438.16675-1-james.morse@arm.com> <20240213184438.16675-3-james.morse@arm.com> From: James Morse In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Reinette, On 13/02/2024 23:14, Reinette Chatre wrote: > On 2/13/2024 10:44 AM, James Morse wrote: >> rmid_ptrs[] is allocated from dom_data_init() but never free()d. >> >> While the exit text ends up in the linker script's DISCARD section, >> the direction of travel is for resctrl to be/have loadable modules. >> >> Add resctrl_put_mon_l3_config() to cleanup any memory allocated >> by rdt_get_mon_l3_config(). >> >> There is no reason to backport this to a stable kernel. > Reviewed-by: Reinette Chatre Thanks! James