Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1299318rdb; Mon, 19 Feb 2024 10:21:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXxbp1lYh1pfisTbm3n4T5M+dfqREY95OvQ0TjxGFBM7ifr/9UfE7WYAUSXZhtpE+hySYoYFRoNfrrHOx+6RR6xeppILOtyoQglmf83pA== X-Google-Smtp-Source: AGHT+IHdyjpqixgKCLOzqOW/wB0SOCYGzl9s1CZcxh2ZpOAjj7LuFAiFMcVwjmeoMI4D4KLtfwzg X-Received: by 2002:a17:903:445:b0:1db:917f:5a42 with SMTP id iw5-20020a170903044500b001db917f5a42mr11308105plb.3.1708366860249; Mon, 19 Feb 2024 10:21:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708366860; cv=pass; d=google.com; s=arc-20160816; b=mj+9VZDvKZ4uf2rQVqMNfaZyThwhWAkIL5x2LICrfqEHNEvUmtZXKZXiws95F6i84D fbqxH2OplTu2gpl5M9WlbWvybcg9WUbYaBEGSQ7dP8xyXDuem+hfc72vGm27vYnk9Tmz Gm5s9fR5LTjRf8gUya1hcTJv3AwCaZPtj7djLOcU+ozoi2+EKZ+Gf5qARXi2SMJawmiA lX5vOdNq9MYKMsnNm8N+YtwPJcewImkf1VPLF/HiHsuJiq/78kmSaJl4BJO30GovD6EU 7D0EUhxqaPdIpZUajffSbCjBRVlTEC4qeVkW4x0QhKiuBd53ip2MXO94/1jpwSl0oMsW GUwg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date; bh=38A8agGcOXabYdkES45LukWBfdOlcYhQ9YLtWHbWuT0=; fh=AdbslQO0k+AnvEfX3vMM2zR0Ci/sn0BMuAHQ8jbhQKE=; b=yJ4gDoV4iqfQcwrHHjO1gWurUihupndF2XkMFWnogErqzmUOmkNrKJeqXRXPFwqIrC 3RtcwxLmYR5paWFDt7cdxXzNXpCysleL1iZrixUtCsgzm3JAva/C+E1ehIZnEYUJOALi LKoGTwxNhcTpkRg2ybXXfN2+Y7Bx4fQ5L40Je6luVNnc+wWzU7UPvrTH/qLi3/Rc5gEp Rji7+HA+hqq06sKilgoU7JR/TXMaMionVy+5G6bCmTDzuSkzQU+NOMgOvglQRGTi81qA mDszRd9TM9F3K3gIFN/TW8NrolhI4AfWtkjj2ifZau5iYtGihkwfOLTJhzwjsorSM64l BU+w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-71803-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71803-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d9-20020a170902654900b001da177b0630si4644705pln.365.2024.02.19.10.20.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 10:21:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71803-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-71803-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71803-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EEA7EB21043 for ; Mon, 19 Feb 2024 18:16:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 77276481B3; Mon, 19 Feb 2024 18:16:12 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 002B74779C; Mon, 19 Feb 2024 18:16:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708366572; cv=none; b=Ro/d708vKqE1EPG21ZiEbUCgpBUWRlsq1E1ks4HuvwbwGD/6/lEOnsrwYcE8dIpOAQR9+HplYSsYdSPR8ZdTPO+Ol1l8qcDnsmHaxiwT7p0nof2XodMgi3QTsGrisWYfi5waROh6IY6HptTUjai+lkik9HkVP8ixFVoJs5NkSDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708366572; c=relaxed/simple; bh=EpljsEzrG9dama9fboFOPoy9uxObmu3qwV9wBqAh3M0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=V51AhBjjoEzddL4JTwmUk3LmIxZR4f0+cnqwCSC6tRxgIm63EOVHUzC5s1Cf3e5OMGjHfwFPmN5CaiqTf8Pod6OZrMNZROSX/Pg88LgxRx79e71ACZEphQn1u/bs7aD9R2Wvxm3QB5ydzSl9+CWKcB8rxB3NUSj514eFUTMj08g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8301C43390; Mon, 19 Feb 2024 18:16:10 +0000 (UTC) Date: Mon, 19 Feb 2024 13:17:54 -0500 From: Steven Rostedt To: Vincent Donnefort Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, kernel-team@android.com Subject: Re: [PATCH v17 3/6] tracing: Add snapshot refcount Message-ID: <20240219131754.5d26f4e6@gandalf.local.home> In-Reply-To: <20240213114945.3528801-4-vdonnefort@google.com> References: <20240213114945.3528801-1-vdonnefort@google.com> <20240213114945.3528801-4-vdonnefort@google.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 13 Feb 2024 11:49:42 +0000 Vincent Donnefort wrote: > @@ -9678,7 +9739,9 @@ trace_array_create_systems(const char *name, const char *systems) > raw_spin_lock_init(&tr->start_lock); > > tr->max_lock = (arch_spinlock_t)__ARCH_SPIN_LOCK_UNLOCKED; > - > +#ifdef CONFIG_TRCER_MAX_TRACE Oops! I'll fix this too. -- Steve > + spinlock_init(&tr->snapshot_trigger_lock); > +#endif > tr->current_trace = &nop_trace; > > INIT_LIST_HEAD(&tr->systems);