Received-SPF: pass (google.com: domain of linux-kernel+bounces-71805-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 19 Feb 2024 13:22:54 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com,
 kernel-team@android.com
Subject: Re: [PATCH v17 3/6] tracing: Add snapshot refcount
Message-ID: <20240219132254.484fde37@gandalf.local.home>
In-Reply-To: <20240219131754.5d26f4e6@gandalf.local.home>
References: <20240213114945.3528801-1-vdonnefort@google.com>
	<20240213114945.3528801-4-vdonnefort@google.com>
	<20240219131754.5d26f4e6@gandalf.local.home>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, 19 Feb 2024 13:17:54 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 13 Feb 2024 11:49:42 +0000
> Vincent Donnefort <vdonnefort@google.com> wrote:
>=20
> > @@ -9678,7 +9739,9 @@ trace_array_create_systems(const char *name, cons=
t char *systems)
> >  	raw_spin_lock_init(&tr->start_lock);
> > =20
> >  	tr->max_lock =3D (arch_spinlock_t)__ARCH_SPIN_LOCK_UNLOCKED;
> > -
> > +#ifdef CONFIG_TRCER_MAX_TRACE =20
>=20
> Oops!
>=20
> I'll fix this too.
>=20
>=20
> > +	spinlock_init(&tr->snapshot_trigger_lock);

And this too:

kernel/trace/trace.c:9245:9: error: implicit declaration of function =E2=80=
=98spinlock_init=E2=80=99; did you mean =E2=80=98spin_lock_init=E2=80=99? [=
-Werror=3Dimplicit-function-declaration]
 9245 |         spinlock_init(&tr->snapshot_trigger_lock);
      |         ^~~~~~~~~~~~~

-- Steve

> > +#endif
> >  	tr->current_trace =3D &nop_trace;
> > =20
> >  	INIT_LIST_HEAD(&tr->systems); =20