Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1308917rdb; Mon, 19 Feb 2024 10:44:20 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXggY4p/lZixoM/2TKWxSannFuUBJvW+GSkpHmpsHjWYCjoNd8WX+nmZwWcj9zZzWW5KocG60XJbrhD2paS5ZkG5MrBujR7YKweVtLEBQ== X-Google-Smtp-Source: AGHT+IHE3IpysRwJj9nKSuXIdYbjOlTh0gqQvaTx8UwbuQiR2uN3fHxrpZhyz/ERi4GcN+ZIZ3XF X-Received: by 2002:aa7:9802:0:b0:6e4:148e:2933 with SMTP id e2-20020aa79802000000b006e4148e2933mr3942557pfl.13.1708368259853; Mon, 19 Feb 2024 10:44:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708368259; cv=pass; d=google.com; s=arc-20160816; b=LoEqzw/Se4BOx0gAKV+dqHUIve1ITwOZ0XQmGoOwBHVloeY8Awrb+aQnVD2125gvVc NPyUt3y+pSLKe5UFA1zbDCdQdatZqKgY3w0ZUijFoqa9hOap/4KF86SWsuRg5sbYckgs sMDyNo8ELRw5AxgsjHSfxDrAKaVvkPMgaT7x7xBITwQY5fNnkWHykNpEglDXX8Ll3w+V x/2SrGJwDNG374erSPIhEn2Qt4wvOZkRNFcMpvR8bHuuhNwml6ROSfNrk0Fm4hGnsR/B 4s0rFVVLbJ3hFmxOYEq/Gq3IPHEWfbjSBq4IbJTTw3YsTF4im6dJvvtbzHYTeedgMgO6 Nehg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pcTPuo6GV3W0H7qdUsYsZOLgcPNlQ24pV3rYw6LLRVc=; fh=s5uhl5vi3XdGOzT+EWONIuNjCwcBKo0TQDaSXvDVep4=; b=CHxTH++1msNeEyPAYZopXcoPAiu2UaG+58bs6v8qDvYAmcfy9gBZc39rVhfASxJ82a moHxVezNubOhxRJhuPgCULsEiea+KyErc4+uI1pLdQQ8zXSt8WQAD9JbirhF+9KhZYsy DMLDPdSg8CinXlVKtZ8E2z7irueK7El6af5kFeLGePvMVsiwDVbBaM5OKhszCaEQdxiH d90888kShCJFGwqiUnrmUB3safIWFX9N5/ErKO6mltD3d9OF59Sw9kfZYVYAjKCtvwFS ENMYty+8/v65tJdUXAT9EDfe/T2fibKxg/7e3RLO+6r4vW+iprvIIlcRbIRHQiuC6e6W nDHA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hWRG4KI+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-71838-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71838-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id c23-20020aa78817000000b006e0695e6a68si3895321pfo.388.2024.02.19.10.44.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 10:44:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71838-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hWRG4KI+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-71838-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71838-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 901D7283C43 for ; Mon, 19 Feb 2024 18:44:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6B766482EC; Mon, 19 Feb 2024 18:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hWRG4KI+" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94C001D53C for ; Mon, 19 Feb 2024 18:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708368250; cv=none; b=QpchMb2EIsb6GYOs+WKOXez9DpUuWhpJ+tO+E/MtaO4QHzcqRvKy4i49By+D/VuHdEF4qhNrkUIUEcnZ0K2+tBIS60EW/mzZnCzgr1CpbHQYgbJg5e0UzbDnH5zK1HAW+b7LWPMZjJqYDWIPnaLfPUAOa4Xu61K7lHXGeKxeF1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708368250; c=relaxed/simple; bh=A+skSn5EGS8bpzAxHlYWC66tyc9qRmaHyrFHFKuAz6k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nwn/WhkfMDbjtLQ4i3tMWiR3lG4MV246kYzxNuN/fPqtimrNd50y+/C+Uona3lfMU3V3xoZHIGL1Guoi2/RmdEAgE64M01+G45tYWnjTZDh2rSad/nmtp/9HW5FWPQBxzpO0olbTjOdMF/z3PngrFxFxh/3BcG+c07nhHAN6y0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hWRG4KI+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07B27C433F1; Mon, 19 Feb 2024 18:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708368250; bh=A+skSn5EGS8bpzAxHlYWC66tyc9qRmaHyrFHFKuAz6k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hWRG4KI+8bAKVYukLPfmN2JxynpqPCs19YmhE/Sf4lcIMfU5uL85zLUa9LJy7HBSq mKpB8QmLAX+OtA9xBgXtBhZT61FT59UdF7TF9Ql7t826DSuNMw4MQLw3jk3MB+tg/C DC+0fdDdgstI8BXMAgNk3MvR6kKU4Lt2Av6c8PynIGdQXHI3+akxHAzSb+vlpzUetB 3qi3+eDr3v5i+V91rn/Om5OmD8X5xJxoGbe62I0yMi+nqom1Nfmip5RgU5p0ANbkAh fIwH0TwUFX/08Fqq5SJbWPOWUuGhOxTvcQB/k7hIoTXdO0hEjg0gMl57MIzjpzB8pp iI0vl5Cm+Wd9Q== Date: Mon, 19 Feb 2024 11:44:08 -0700 From: Keith Busch To: Daniel Wagner Cc: James Smart , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/6] nvme-fabrics: introduce connect_sync option Message-ID: References: <20240219131531.15134-1-dwagner@suse.de> <20240219131531.15134-2-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219131531.15134-2-dwagner@suse.de> On Mon, Feb 19, 2024 at 02:15:26PM +0100, Daniel Wagner wrote: > The TCP and RDMA transport are doing a synchronous connect, meaning the > syscal returns with the final result, that is. it either failed or > succeeded. > > This isn't the case for FC. This transport just setups and triggers > the connect and returns without waiting on the result. Introduce a flag > to allow user space to control the behavior, wait or don't wait. The series looks good to me. My only feedback is this patch doesn't change anything without patch 6, so I think these two go together.