Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1314164rdb; Mon, 19 Feb 2024 10:58:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXI71fCHsHecnW1J18RD6N4XQlMLZTjEAIZmw/eyFGpLQsGw21eUgkUImspAkOfNpUfFU9iF65OOap/Nm+nL4z0J+63cCEOJPDEIzIa4Q== X-Google-Smtp-Source: AGHT+IFLPJ16jx9I5566pvtC50rgNTeM3y9ueOcalCGEAq9199OJVB3H0cZsKOPUH6zbrqNKJThx X-Received: by 2002:a05:620a:4708:b0:787:4024:a673 with SMTP id bs8-20020a05620a470800b007874024a673mr12110366qkb.23.1708369114392; Mon, 19 Feb 2024 10:58:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708369114; cv=pass; d=google.com; s=arc-20160816; b=lpDi7+lADr8BNzg87ZpZH7CyPHutq0gB2doawUv9S6k3I9zrh0R8HfmwBrRDrNwGSA J3JIHe9sZr78wVTMDNUksBGh1g9xJSfuVZWaH3jc5N305wngr7ZA7NERlNstxkw6DrlC NGyfi1zG4M2c9v5kwOG2VQa+q2hSST6dO615Qdu2stLtU1LKKmFIDxW+NPxdH+JesaGw qlAvsdpMKkpMAX/uckdJXNhnuzRwmfDxFgZxSig1eqH3Amqx5Z9wZxV3URbzz1VQbD5f nVTq6CnDtYigJAh5d/5+CmAE9LWhp7AT8Q6MmUbvTyF8UiA3ZPSzJ5CuRRQBm3PEje/S MFRQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=E5253epWr/zaC4e7F0X77wkVCHTrLNx/UNbcR3b4RXY=; fh=SRr6913gH9jRvLVA7Ptd0kRA9D23buURych6Wg68MR0=; b=CRI3Uju44eUL50SJ9T7lD0fWf3KHZ+odAb76gigHRbHTrt0Dr3zq5P4FoDlpwixUmx 90gu4JAbZHNmy5dp658sD2XLBuXBwQLpRHUYlfmTPjn7NBtzF0ouA+m7QukVF85OYSdp SN+pecxIsaoYFMUBjkYPuaV2eIIU6YEI1ChNRCXIPzZF3zWE8414XB56gjG0K2mb+Qf8 2ZQ/yZHQPwSzsAgTz0WAh8xIW2HxQzy3gdiz5pZl6AfwkZFwBFMBoyhqxtWMcHqEGmMO 8SudCYN2f4HHEInXdPocQztRDVsSKilb9mL6Blpgr56UChsWCgKSL7ReQxu9ouTZEbin Ep6w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ByWPm0we; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-71845-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71845-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id g2-20020a05620a13c200b0078715367700si6554551qkl.64.2024.02.19.10.58.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 10:58:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71845-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ByWPm0we; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-71845-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71845-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 16A331C21819 for ; Mon, 19 Feb 2024 18:58:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AE5B04C60F; Mon, 19 Feb 2024 18:58:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ByWPm0we" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB3A4878A; Mon, 19 Feb 2024 18:57:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708369079; cv=none; b=HlGnKrGG8hQo3gEgVoLS/4Pm376n93lCgMBWkYtOVT55cx9InZzIDmI+M/u7rKUuWmAuFZxjvUbltVbuyz36sJicm9evQpbizaPwgE0Sl/S9jn+74sOIX+IYLozjCZrmC52nc2qJjk2thUqMET8DO3bE0wzjnJhsyfi6isoACkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708369079; c=relaxed/simple; bh=WX+/BwKaMoi4eZrIDNE+tT6bRVlFBx1G/86vGVtXqD4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t6q0jRk83u0MfQIMuu10jp9MLjmBTIzwmWkyqKE23hO2YBYII9pJtdf6kwFT7qQf0dSxit6+uFsfDW/oOF0ZOm/RpiI/VYNGdZvrlC/rAZU35KA9tVPyPCk5yBVU+S1AhT4+iuidSYUhFSH0KrrOcenogMB9FYUEj9WzXqZOKeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ByWPm0we; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D104AC43399; Mon, 19 Feb 2024 18:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708369079; bh=WX+/BwKaMoi4eZrIDNE+tT6bRVlFBx1G/86vGVtXqD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ByWPm0weIZLIZDkeu9F7U3wLzNAxvJ0wCc0RX9kGhgdhcJfvd6woVFl/GnXE1TSmM COFe07bO2b5emaS1mCXplG7Nyp/lAlqeDf6IoQ9f8bPe+rUntxpHDqCnExMiY7kJ47 KiwTKH06LtDIHzNkYCwqAsiuJvnjz4kdzONe4y5nqyZ40xBUm010Vz30bGq053wPcE +ONYB1Np8G22L8MxHL7VziiI7QiaCYtoXbZ21PR0m6EN4hIiN9NUFXFLyO6dqrPXPJ gBrd6UUtBmYPhuyFFd3uerXJdoDrUxB06wlm4ih5guvURtYgzliLa/DRz5pLQJVpJx RB9hrKDCMCVDg== Date: Mon, 19 Feb 2024 11:57:55 -0700 From: Keith Busch To: John Garry Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com, jack@suse.cz, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org, ojaswin@linux.ibm.com, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org, nilay@linux.ibm.com, ritesh.list@gmail.com Subject: Re: [PATCH v4 01/11] block: Pass blk_queue_get_max_sectors() a request pointer Message-ID: References: <20240219130109.341523-1-john.g.garry@oracle.com> <20240219130109.341523-2-john.g.garry@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219130109.341523-2-john.g.garry@oracle.com> On Mon, Feb 19, 2024 at 01:00:59PM +0000, John Garry wrote: > Currently blk_queue_get_max_sectors() is passed a enum req_op. In future > the value returned from blk_queue_get_max_sectors() may depend on certain > request flags, so pass a request pointer. > > Also use rq->cmd_flags instead of rq->bio->bi_opf when possible. Looks good. Reviewed-by: Keith Busch