Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1324477rdb; Mon, 19 Feb 2024 11:17:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXXRVTs0Irwd/hdghq7xPRQUIZtAlQfi3g0yOBu++s4zwfffwuXh+d1ZDhQsNVwbAVLHrca4LnR8vgsvHgEafbV1OxTVtByiqzPZZnR0w== X-Google-Smtp-Source: AGHT+IFf0zVAODU81xim6sCMF89EKw0gDO9WP24NSZXMzhBBYoiMOkar6UJUsH62g8EBvZtEkBki X-Received: by 2002:a05:6a00:13a3:b0:6e0:51e3:909d with SMTP id t35-20020a056a0013a300b006e051e3909dmr17975885pfg.17.1708370278202; Mon, 19 Feb 2024 11:17:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708370278; cv=pass; d=google.com; s=arc-20160816; b=wHrB8rw41QpT+88/5mvH19Uj5vPAfMMsyzuq9rbM5J8RbBeCs4iJoiBJDALzhqbhOY K8je7FVgmVJbl2RoKjaqN2K/+PhjobzlT/jvZOXyUdGa3nMQQ2sndce+B5PiV4InHmrp VFPsniD2bJFlbtLV6bhaOxUg9yMh6+fG9gtPUpKsvUYJ95GsRLlIH2G35IHPAC991gaT BdWe3LHe2LfTIh33ArmowuLc3bJNYitJj5i+Swn78PWMpR8rJC6541wMh+JGVO+abZ75 cqvMG/WteI791SKpkax5ADpaSzSJpK+JJ1oNKdVUvXd1bI7B/yMYdSMPI5SKu9wDaa24 OCXg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :reply-to:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=hP0JzOSxa8Ak34PkLlYrH+BW+BeCI1kfUuoJPW8HusA=; fh=ioJjkNUqCPpp/LDIpsFfrOxq639d0MI0k8qe4FJzm68=; b=CSFIApvdwZaHru0KMQ+ZI/w//QAKmOVpuPGe97Ka1cvDP4VD4u1Z4sz40YxQTLa+7Q tEaJ7rImYM94clsSkivetEggqi6zxFcHHBgVUi+Uvk97LUynhM1kKZkWcpdVLqXyVR26 nxRsGu40IQfezJBYzDr1tsD3hHdfopCcLAx9oAtrzGfuZYjvcdh+az04IUadlEXTU5GD 3FYcfwGxqNTqRh1blpvsU2H3r8j1jFg894a4c5pP+h4zzx45Nfx5L2rKDdpTbQxHYvfq UHJn2CN8G0mVX4Feblmb2n56LVHxsuAP52QNdS08sHr+l/XFGgjY5SNLN56j4DmvNCce vMZw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=L+vMdNx5; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=L+vMdNx5; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=s7FAO35e; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-71859-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71859-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id i21-20020aa79095000000b006e05260e1easi4930948pfa.100.2024.02.19.11.17.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 11:17:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71859-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=L+vMdNx5; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=L+vMdNx5; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=s7FAO35e; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-71859-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71859-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E66BD2843E3 for ; Mon, 19 Feb 2024 19:17:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E5EA0524D9; Mon, 19 Feb 2024 19:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="L+vMdNx5"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="s7FAO35e"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="L+vMdNx5"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="s7FAO35e" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 277FE5026E; Mon, 19 Feb 2024 19:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708370242; cv=none; b=EuuZK7hDt8/a6fztLghV0ppviae0JfjjYv4xV20lCmjj/5xnSpOSYMDYRqaD/I5IrwAV7ycLeh0qAXyZ8TjdxgW8jeBGWjeq9QpB47yQ9JU6xJKv/0SD6ofwHiFjkfeoSbWwvfr/tGYt4tk6WnBlca7bzbgJrULcSI/u9jP+d3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708370242; c=relaxed/simple; bh=sRfczU3h38e9XwnW/0H/0VrVNL08337uFZQFx5xcBrg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uvFdRoSfwXKhsZCpsa/22r1ZD0Z0voSXhBbmsHQk1yvG8gifli5AG8aM+FhtYaeoKOXUQ+wANE0u9bICbetqmM6ChI2pMrgpWUJiPRgojDhOlNYu6N6XTojoMjCN40772wwLlKa3u5QV+Zo+g6vs5Fb/08S++W0SQ86nhmvrpfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=L+vMdNx5; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=s7FAO35e; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=L+vMdNx5; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=s7FAO35e; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 345AF21CDF; Mon, 19 Feb 2024 19:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708370239; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hP0JzOSxa8Ak34PkLlYrH+BW+BeCI1kfUuoJPW8HusA=; b=L+vMdNx52tHJkwchBcBa001qK+SZbtkZ0/HROkYFTpK0Mp6T669V9VwOkeXDQTpQ2fHujp itj6yObR2GSzdmVyzY6nN++Gzw11Xb9rJnuhobwQBRoOg7xeCeTWPpEjTMyFFVrVdH1zO/ QWJf0rogCt/jib7V0aowiiggrz/iFOo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708370239; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hP0JzOSxa8Ak34PkLlYrH+BW+BeCI1kfUuoJPW8HusA=; b=s7FAO35emUqsBT78ndugZlEtb/uTp91WcAJqAHeiXy2r8Or+q1xNYrwiD46+AOf7djzZ9L PZKkia9ha8+FKbAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708370239; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hP0JzOSxa8Ak34PkLlYrH+BW+BeCI1kfUuoJPW8HusA=; b=L+vMdNx52tHJkwchBcBa001qK+SZbtkZ0/HROkYFTpK0Mp6T669V9VwOkeXDQTpQ2fHujp itj6yObR2GSzdmVyzY6nN++Gzw11Xb9rJnuhobwQBRoOg7xeCeTWPpEjTMyFFVrVdH1zO/ QWJf0rogCt/jib7V0aowiiggrz/iFOo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708370239; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hP0JzOSxa8Ak34PkLlYrH+BW+BeCI1kfUuoJPW8HusA=; b=s7FAO35emUqsBT78ndugZlEtb/uTp91WcAJqAHeiXy2r8Or+q1xNYrwiD46+AOf7djzZ9L PZKkia9ha8+FKbAg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 0B3F5139C6; Mon, 19 Feb 2024 19:17:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id ciGVAj+p02UMUgAAn2gu4w (envelope-from ); Mon, 19 Feb 2024 19:17:19 +0000 Date: Mon, 19 Feb 2024 20:16:34 +0100 From: David Sterba To: John Garry Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com, jack@suse.cz, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org, ojaswin@linux.ibm.com, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org, nilay@linux.ibm.com, ritesh.list@gmail.com, Prasad Singamsetty Subject: Re: [PATCH v4 03/11] fs: Initial atomic write support Message-ID: <20240219191634.GY355@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20240219130109.341523-1-john.g.garry@oracle.com> <20240219130109.341523-4-john.g.garry@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219130109.341523-4-john.g.garry@oracle.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Level: X-Spamd-Bar: / Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=L+vMdNx5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=s7FAO35e X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-0.26 / 50.00]; HAS_REPLYTO(0.30)[dsterba@suse.cz]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:98:from]; TO_DN_SOME(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLpoxz4e4fx16srn3jiqdcgp9j)]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.cz:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.55)[80.88%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RCPT_COUNT_TWELVE(0.00)[26]; DBL_BLOCKED_OPENRESOLVER(0.00)[oracle.com:email,suse.cz:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_CC(0.00)[kernel.dk,kernel.org,lst.de,grimberg.me,linux.ibm.com,oracle.com,zeniv.linux.org.uk,redhat.com,suse.cz,vger.kernel.org,lists.infradead.org,mit.edu,google.com,kvack.org,gmail.com]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-Spam-Score: -0.26 X-Rspamd-Queue-Id: 345AF21CDF X-Spam-Flag: NO On Mon, Feb 19, 2024 at 01:01:01PM +0000, John Garry wrote: > From: Prasad Singamsetty > --- a/include/uapi/linux/fs.h > +++ b/include/uapi/linux/fs.h > @@ -301,9 +301,12 @@ typedef int __bitwise __kernel_rwf_t; > /* per-IO O_APPEND */ > #define RWF_APPEND ((__force __kernel_rwf_t)0x00000010) > > +/* Atomic Write */ > +#define RWF_ATOMIC ((__force __kernel_rwf_t)0x00000040) Should this be 0x20 so it's the next bit after RWF_APPEND?