Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1331816rdb; Mon, 19 Feb 2024 11:35:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUx8Sqx5BS1Vqn+KQTVp+vjNK/he34Y4rCkxUbIApMxQXjKL+gYQhhy4cc0M5sfYMC+LNsIpRKN3hqhvN2fLBDukeci7ZmDcDNkQdXhpQ== X-Google-Smtp-Source: AGHT+IGNkFoHCE3oQNGmIDcbyt9WCl9aFxIRHT9X4Eb2OA79H4W1a6q1hULG5BXf/s60DiPVbFW2 X-Received: by 2002:a05:6870:d08:b0:21e:e7bd:807e with SMTP id mk8-20020a0568700d0800b0021ee7bd807emr2692616oab.58.1708371350135; Mon, 19 Feb 2024 11:35:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708371350; cv=pass; d=google.com; s=arc-20160816; b=i8Q8BLYhvsESYPJyf4xgu2gWY40M9U7B66VJHfi3Ov0CoaBs+Dot+0j3d0EXEqSxfG rl2VgzPXJeNqym/tyLU/WymXkF42BRa7jgC5Jm82gnDiHYJ0cbtmaWJUM7lCQSN9FPfr fXeR1n1zpC1BE2qrTSZufogg9gXknywNiVgFjF8e1c+T9n8XTQNLAYX9rPynQIA6eM5R cV6d3hOajvOxzvst8+YemT26qrfl17onVaV3NT6sRYX3fB7XtWQ/zu6563AtWqJFaWOS JTvfNeiksup+ALQbMTebXJ/SNQ30culBntub+Ik3ZnYyFj/9/9g3VugZkMmtTib8kM4P NfIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=ikhHFMnT6d6htpSem+g4FWz8d7jCkA3C4fCZLet74Jw=; fh=W3pHf90zcOfPBXPnVNpa35j87CBfuQm1NKWGOh5HGqA=; b=d78Kmc+gll+CFFMlLIcSOoZUgX3lk6qq7iQoOPTsinRpnk0V1qXUZUmisbZKj1KiRK +ctmk4xw9ZGoWWCkBYV8LE8SD8pS4n45Z0KvSot1fcuWiHo9NVezWqqBcc5+A14fgsiP 4RYsEHuKKJhnBOGhNwm1VIr1rumKumYZOvPjDCUplGt7p+QHeSPuCeWDJsekbDzzNc1K D66DtbPCCJW0S4up6wDIglq341HB185IQVBwt541k50OLVRcR3NuawVpsz4xfjcrRZMH 2tbO5kdCKQJxl8KYfMFWFxy5dCnG9kBuRRCOrWFCU8w1lNJ8JdH7k8SpDRC90arQTsIE aiUw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Y0zK2vNX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-71875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71875-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s25-20020a656919000000b005c688ef7549si4931199pgq.98.2024.02.19.11.35.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 11:35:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Y0zK2vNX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-71875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71875-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5B9C9282A37 for ; Mon, 19 Feb 2024 19:35:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C1CF851033; Mon, 19 Feb 2024 19:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y0zK2vNX" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E270650A6D; Mon, 19 Feb 2024 19:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708371330; cv=none; b=RJ2Z9qzTvmCjPcaUyKMbdxx477WZGHorG6m+j8laq8Id82YyhkFUzWA3NrsXx4r3LphTNNdHEwF1QGjFKACdHCaPQu96wTa58InDvhIRi/fJVG+/uQRCTy2atFzRq9+OCLpBXGXr5eiun1EvjQdhA0WG4AJ1QY6guIETUtCdI/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708371330; c=relaxed/simple; bh=MtHBN20Imk6FyQFVnXsyakVvR6vcvLdw4T3spvloVPs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Z1cfGAB/gkYg70tFuEcwPosoilmT0DAV0G/V4ZwDkxV14SetqwPKwlW3OJJLFnPmjUgP/HoWAJ8o6e9JYFYW1096U9b0NgNbNOzv7i9tRa0tUy6pldr9KsvwphUHaAyN3ztp0m43kIk8YAwdKVRJ2h/jiomnBIbkb1KIu5oALYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y0zK2vNX; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27EF1C43390; Mon, 19 Feb 2024 19:35:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708371329; bh=MtHBN20Imk6FyQFVnXsyakVvR6vcvLdw4T3spvloVPs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y0zK2vNXyC6JWeO5a3LlTiYGO0k+Su4tGV/xFCDF9CAPAO3PgahUr0OgjJdKYrLZf gnoPuI90yww8I6Fl+xKmJHyLBrZnFnaNgpSoyL6sLQiaCxbAlgQT2K6RUiEF3u7peR /5/44MSQJPL57KsDHksBRQ7JziVRPesJQm99HsJxRGKcmNfjrlVm07tXCIC4lxbv70 N0SDdaByDCk8ZO+duEiMx/TCSFbzkzUvo5HLNZCfBx+Lk3+NhCI4QE7rOm2h+7Tf4Y sCrkRd3qCCs226hDlVxFOhOqaFBj8t67zC1eWNL8VvYPYZQ4XJPYtJ7WNEv8qZS+99 vv16OXYPnfCdQ== Date: Mon, 19 Feb 2024 19:35:12 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: Mike Looijmans , devicetree@vger.kernel.org, linux-iio@vger.kernel.org, Lars-Peter Clausen , Lee Jones , Liam Beguin , Liam Girdwood , Maksim Kiselev , Marcus Folkesson , Marius Cristea , Mark Brown , Niklas Schnelle , Okan Sahin , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/2] iio: adc: ti-ads1298: Add driver Message-ID: <20240219193512.2ff8455c@jic23-huawei> In-Reply-To: References: <20240219065026.578517-1-mike.looijmans@topic.nl> <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.ec4cd694-3b45-4b64-9a96-fc1ccc42fc68@emailsignatures365.codetwo.com> <20240219065026.578517-2-mike.looijmans@topic.nl> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 19 Feb 2024 14:27:57 +0200 Andy Shevchenko wrote: > On Mon, Feb 19, 2024 at 07:50:26AM +0100, Mike Looijmans wrote: > > Skeleton driver for the TI ADS1298 medical ADC. This device is > > typically used for ECG and similar measurements. Supports data > > acquisition at configurable scale and sampling frequency. > > This version seems good enough, > Reviewed-by: Andy Shevchenko > I fixed up the PTR_ERR() thing directly on the tree and added Andy's RB whilst there.