Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1339323rdb; Mon, 19 Feb 2024 11:56:54 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXjFL2/B+hghGWLe82RHOGrGwgUi6oshw1neHheOPk6lLHxyxOrNlUMG4k6oL+szGAcXfoodIGPrxWul1DpF9n42bbqIJKUIgqSLhCBjQ== X-Google-Smtp-Source: AGHT+IFuDCZQuV4sF0cSGvoRiOwRXV2uSi7rhpYz3xbY/iaL4mUTy8G5qvNacQL8JGVGYHf1A713 X-Received: by 2002:a25:f505:0:b0:dcd:30f7:f7d0 with SMTP id a5-20020a25f505000000b00dcd30f7f7d0mr10987466ybe.21.1708372613915; Mon, 19 Feb 2024 11:56:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708372613; cv=pass; d=google.com; s=arc-20160816; b=iRrmHq9MkzUco89ms2WvmGTBINzVY/f4RSGi9aJcwhueBdS4sHXW998p4NoOq3BE1Y riZlUs+eSXa/7erH5peyaY6tOgsF4JeXnVetR2wGqoSFi01JTXyL8PKGXfPDKzN1iH4n 6I5Ethbz1ipedXqa1UQHD8M+gFSQipQz6+YIGexJHKUUj0ceUQaVS3K+dLpmWUStP3Bp cQ32/m2YfRCNde4qUBRuSPlx6K8jX7a2zBHZyyDTu6B4+94QrgxjoHZTFzlabjo8fdRw MySY5XTbR+bdtARBuE8rqqlq34SPFEcnlXGUS9tU4VZH97tftEutoKLvDCjmGy269AvP NDWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wxlz5y8xApNDc+SiH0tvztL2aU9MNzOkQMiLT7Rqqe0=; fh=0zs6CMlAIUyC5JK3HiUvKSUZ0oKjGpg+c1QPAuA1SFA=; b=V0ZazCKE7MPbqFDi0A84oQSIKmTLI5UTjCVwUc24tDcb5s38i+M91651/SIJ337B3R 980/6PjVzZiiZ9dCg2FPurAsT/PiSAnYvZrnCEv/HTtAydF9pyPUqS4jxdoYpEmclRDM /swJCxu9GnhaWTSHdEyExPlliPz3g+U6aSJbmJG5WZkr2zaQ8m1bONZJ+CRH+H0WkYxe x5lui1jPL2p/jhTsKgKFr0SqHunD7rx8pXYfezlttnwbTlQULRwXTRcBqn464OxanMmO 6LvVwuEI+jK6pU1UH3Oegvrh6NA+HMdbIAsLrDQZlHR3shnY2o0ZpirgfyYWAlEZcf7B 38jg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="j/Tf0rg/"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-71923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71923-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id i2-20020ae9ee02000000b00787131efafdsi7011013qkg.538.2024.02.19.11.56.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 11:56:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="j/Tf0rg/"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-71923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71923-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 890941C2167E for ; Mon, 19 Feb 2024 19:56:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2CACA524AC; Mon, 19 Feb 2024 19:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="j/Tf0rg/" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A2824F203; Mon, 19 Feb 2024 19:56:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708372602; cv=none; b=DHLIqOk/1zuzODK1TxZr8HGfHB52qeawYpUb5R33su4WXZ7wdq7O2KolJPgkr2eqLkkWeEvHV8GVRLtQQdsExja5sSo+f0n/e8XW2CN82kSlPyndDGcq0ClHn8UHxy/5/ZU8qRSb0n/Zd7VcoM2HgXXm4qtvBfDPwLB3sqsujww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708372602; c=relaxed/simple; bh=OaAEMFvFDN1qhJ4t5nXfrOCymw4TroM52J1E3WnfAP0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CH4YqlWQDjRZLjxA9JEkwaaOqLi/mrjBUUS/3yaX83WK06PFr8FxyNJBd91I6uSMOnjWDsIJ91rhDKrrmpit9Vhy8jb01pRudRtDZ9VQ3Rq0HhgzI/meluSTxcDYa/e5ovNASbEkGksYmoyofeDx5Fm7G3IfRDji4+O9hTZ2GkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=j/Tf0rg/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BB28C433F1; Mon, 19 Feb 2024 19:56:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708372601; bh=OaAEMFvFDN1qhJ4t5nXfrOCymw4TroM52J1E3WnfAP0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j/Tf0rg/52VRU0RdqcIIbgIp34hsAGhLLM6UEzs4f8XeRAe8Pe0ZnvuYgjEaedKPh XzolqPbpGuyslO57mb26R3nPLHjlPXFweVZOqmQ+StxE+IHfCDJsSFchYOb0ECw4Ej 9bic7JeKdiqsqqJlLXwCDhAwxYe5B/OGUhUOFkGU= Date: Mon, 19 Feb 2024 20:56:39 +0100 From: Greg KH To: Mathias Nyman Cc: Wesley Cheng , srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, conor+dt@kernel.org, corbet@lwn.net, lgirdwood@gmail.com, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Thinh.Nguyen@synopsys.com, broonie@kernel.org, bgoswami@quicinc.com, tiwai@suse.com, robh+dt@kernel.org, konrad.dybcio@linaro.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v17 00/51] Introduce QC USB SND audio offloading support Message-ID: <2024021929-catching-subheader-d51b@gregkh> References: <20240217001017.29969-1-quic_wcheng@quicinc.com> <2024021754-unengaged-saggy-6ab1@gregkh> <96ab6033-2cb9-daa7-ddad-090138896739@linux.intel.com> <2024021922-privatize-runt-495e@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Feb 19, 2024 at 01:03:31PM +0200, Mathias Nyman wrote: > > > > > > Patch 10/10 is based on an old POC patch by me, but it's heavily modified. > > > > > > It looks like it does a few minor things that are not optimal, like extra > > > spinlock/unlock, and wait_for_completion_timeout() with magical timeout value. > > > I haven't tested this version, but I guess any fixes or cleanups can be done > > > later on top of it. > > > > I can revert it now if you want, just let me know. > > > > Maybe reverting it would be better yes. Ok, will do, thanks for letting me know. greg k-h