Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1348335rdb; Mon, 19 Feb 2024 12:16:20 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU1Wp/jKgymMqwldpH+sE6fE/dy0kUQMMGfz3XGf9KGDfzwC6paggs45g1KfBN++WT6J+vSFFnB/pE7ORGR/IkGTjQVNpSwVPL/BVfKTQ== X-Google-Smtp-Source: AGHT+IHha5eZ50DcC9H4lpP2NA+DIWvpuriCDvxgwm7euLJPuu6tLWDIY13YQ/9r6pF6wgLYfNQT X-Received: by 2002:a05:6a20:4388:b0:19e:89ae:9b52 with SMTP id i8-20020a056a20438800b0019e89ae9b52mr14344629pzl.7.1708373779826; Mon, 19 Feb 2024 12:16:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708373779; cv=pass; d=google.com; s=arc-20160816; b=v6r07u6idcjuPjKxnBHen6K/bl4YVNseih9vglm61KezqxKfpQ9TRs5waynF1NFWv4 ChjnEANrTHSZt+io1Jn+roplnF497IfkEAWWT1X5f2G8g31/se4osQEIoD1vpLBgS6Sw fbBXDfu5aWAeeiDURgdKFYszgv0X+xKTHVJ6qQh2ZHzd07iQNjr/u7yGCSWKhbQMlIMl 2A7c1gHFSWPZF2CVfx7TZDz//PpK3/OW5Y6vtB6hU69j26n8/adGT5tKtfgKxSyonPHe bVi6BNIna8QW726AD7k+AWBNWZoY3F/fgIe/s4SstMg2F54Nx17FYjP/pm0uAwjcu2jE 6aWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Nc4Y47w6tT+CagccgD+rZmBZbeKpYW0RX/8K127RERk=; fh=v7CalR9StzBw0oTluQjbypPUaGTSkr6l2sVuPJzO+zE=; b=cY0eihnyl2NDWz5AKQMdCy/hTZF/43x3KjjRe7CO7ncgu94ndx9nGH06BXnnBc3vtV sxuhtKh2d9QUi0uJfqnIM91wfchmfiPlDflFtl0rEEzCRP4ER/Uu9qEqVNF0n1Ufy7TB EAkvvaPXle1yLfON0cN9JSf6KgpBGJqDxK7YvYYgcnGu/s6O5oGMA4CCkMslaPvE3Gbh AL/RDNEomJzmk1v3v4rTzWuvI4Tg0B0ISsTB/nfPHo0sTE+dfizTCEI5YCvQDbG41xLq 2l9t9EJWEoh8XZm7sQrdr8U21M7p39Qw86ah+z1LirqE1QiYrbNxnfV2E5/1+L5Rp+X8 Jnfw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T4pBqOfs; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-71949-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71949-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id n21-20020a638f15000000b005d8d56cd646si4999704pgd.130.2024.02.19.12.16.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 12:16:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71949-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T4pBqOfs; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-71949-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71949-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 46506289850 for ; Mon, 19 Feb 2024 20:16:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7050B537E9; Mon, 19 Feb 2024 20:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T4pBqOfs" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E9D1374DD; Mon, 19 Feb 2024 20:16:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708373762; cv=none; b=GuWptwgmLoVvZMLHNltdN79mwpiw309ZG8LdcOn3/x7ne5KphFbzvjwvFD5TxyLjGhFudDUiOstlWVp2AlmdTJSkmnX6hRuYsrMpKGWFCBnMgzYa0u9tfuvi57gY0HEzUo3g0ves6Yb3alIH7CrsUkZkmWR5e9RbXpUJi1mXm6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708373762; c=relaxed/simple; bh=VsTx0aE2ME+JtPusq/DUKNSQMeV9ej42eo9jPEH59N4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LFyeos0s1WjzxdU+TZXAj60ylrPIJMGZhM1FG9O0EgvkxezC/Ks1CB0UBUuYc7HILnYKVwn4WqIMGdnJ9wMDEyvRBqzooMlA7DETFAz5agNUsuXYBMDyjsT6RA0RkfCTTpGDr8d3LB7c6rb3oxQDAylFho2wCzULdulekp6JMyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T4pBqOfs; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97CB8C433F1; Mon, 19 Feb 2024 20:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708373762; bh=VsTx0aE2ME+JtPusq/DUKNSQMeV9ej42eo9jPEH59N4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T4pBqOfsWnvkFGYilzvk1ALxJ/s+7tEa/dupinkCL1cWtD+KzKwp/LgRo7Low5qBW WxWZqpJkhzXlGgB7GmVNq+nDeagb0RJjS9u02ErzHMUhdAaxL/iAmS7RL/40pQ7rTb Y2sU520ng3CiG1hx4c4fQcboSJ9FnRtBKNBuIkQjibpoh2JbQ/VorDzy7+3VnnPxEy h0BI6+G7DwEzionlPgTb7xwuS0Gs0GcG5I4kNfJeHeLZHG4vVVnKFVl2iqmNJwvf9C h/8Z8JD9qZX3SwlKUy/h1y3TOuuO3MaHcT0B4UiA5JsBdOzN8KMnVH9uTQz5yJPR0+ ojkw8ix8CdnKw== Date: Mon, 19 Feb 2024 12:16:00 -0800 From: Jakub Kicinski To: Stephen Hemminger Cc: Breno Leitao , davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, Johannes Berg Subject: Re: [PATCH net-next v2] net: sysfs: Do not create sysfs for non BQL device Message-ID: <20240219121600.03db3457@kernel.org> In-Reply-To: <20240216092905.4e2d3c7c@hermes.local> References: <20240216094154.3263843-1-leitao@debian.org> <20240216092905.4e2d3c7c@hermes.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 16 Feb 2024 09:29:05 -0800 Stephen Hemminger wrote: > Various compilers will warn about missing parens in that expression. > It is valid but mixing & and || can be bug trap. $ git grep ' & [A-Z0-9_]* ||' | wc -l 855 Let's not sprinkle parenthesis in correct code because some old compiler somewhere may doubt our ability to remember the precedence of 14 operators.