Received-SPF: pass (google.com: domain of linux-kernel+bounces-71953-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 19 Feb 2024 21:19:16 +0100
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Michal Simek <michal.simek@amd.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux-kernel@vger.kernel.org, monstr@monstr.eu,
	michal.simek@xilinx.com, git@xilinx.com,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
	"moderated list:ARM/ZYNQ ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM" <linux-rtc@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: rtc: zynqmp: Describe power-domains property
Message-ID: <202402192019160b9c4120@mail.local>
References: <94726c90ff519185767475f672d70311472ea925.1708073513.git.michal.simek@amd.com>
 <5a81f16b-8ece-4263-b424-4dd6cd6e386f@linaro.org>
 <ed59671f-6e0b-45a2-bae7-38f7b4b7e625@amd.com>
 <ebcfd49d-f810-4d9b-8cba-b55071fc7fa6@linaro.org>
 <96c0f613-7c53-4189-bfc8-7d572b308b9f@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <96c0f613-7c53-4189-bfc8-7d572b308b9f@amd.com>

On 19/02/2024 14:11:50+0100, Michal Simek wrote:
> 
> 
> On 2/17/24 09:26, Krzysztof Kozlowski wrote:
> > On 16/02/2024 10:42, Michal Simek wrote:
> > > 
> > > 
> > > On 2/16/24 10:19, Krzysztof Kozlowski wrote:
> > > > On 16/02/2024 09:51, Michal Simek wrote:
> > > > > RTC has its own power domain on Xilinx Versal SOC that's why describe it as
> > > > > optional property.
> > > > > 
> > > > > Signed-off-by: Michal Simek <michal.simek@amd.com>
> > > > > ---
> > > > > 
> > > > >    Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml | 3 +++
> > > > >    1 file changed, 3 insertions(+)
> > > > > 
> > > > 
> > > > But Versal is not described in this binding, is it? I see only one
> > > > compatible.
> > > 
> > > It is the same IP only as is on zynqmp with own power rail.
> > 
> > Then you should have separate compatible, because they are not
> > identical. It would also allow you to narrow the domains to versal and
> > also require it (on versal).
> 
> I can double check with HW guys but I am quite sure IP itself is exactly the
> same. What it is different is that there is own power domain to it (not
> shared one as is in zynqmp case).
> 
> Also Linux is non secure sw and if secure firmware won't allow to change
> setting of it it can't be required. I am just saying that Linux doesn't need
> to be owner of any power domain that's why it shouldn't be required
> property.

I guess because the integration is different, you still need a
differente compatible so you can forbid the property on non-Versal.

> 
> Thanks,
> Michal

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com