Received-SPF: pass (google.com: domain of linux-kernel+bounces-71709-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 19 Feb 2024 16:52:57 +0000
From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Christian Brauner <christian@brauner.io>,
	Markus Suvanto <markus.suvanto@gmail.com>,
	Marc Dionne <marc.dionne@auristor.com>,
	Daniil Dulov <d.dulov@aladdin.ru>, linux-afs@lists.infradead.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] afs: Fix ignored callbacks over ipv4
Message-ID: <ZdOHaTLPkV8VlU7x@casper.infradead.org>
References: <20240219143906.138346-1-dhowells@redhat.com>
 <20240219143906.138346-2-dhowells@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240219143906.138346-2-dhowells@redhat.com>

On Mon, Feb 19, 2024 at 02:39:02PM +0000, David Howells wrote:
> +++ b/fs/afs/internal.h
> @@ -321,8 +321,7 @@ struct afs_net {
>  	struct list_head	fs_probe_slow;	/* List of afs_server to probe at 5m intervals */
>  	struct hlist_head	fs_proc;	/* procfs servers list */
>  
> -	struct hlist_head	fs_addresses4;	/* afs_server (by lowest IPv4 addr) */
> -	struct hlist_head	fs_addresses6;	/* afs_server (by lowest IPv6 addr) */
> +	struct hlist_head	fs_addresses;	/* afs_server (by lowest IPv6 addr) */

Comment is out of date ...

> @@ -561,8 +560,7 @@ struct afs_server {
>  	struct afs_server __rcu	*uuid_next;	/* Next server with same UUID */
>  	struct afs_server	*uuid_prev;	/* Previous server with same UUID */
>  	struct list_head	probe_link;	/* Link in net->fs_probe_list */
> -	struct hlist_node	addr4_link;	/* Link in net->fs_addresses4 */
> -	struct hlist_node	addr6_link;	/* Link in net->fs_addresses6 */
> +	struct hlist_node	addr_link;	/* Link in net->fs_addresses6 */

Ditto