Received-SPF: pass (google.com: domain of linux-kernel+bounces-71980-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID:
 <SEZPR06MB695964E1A34936F70470A21996512@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Tue, 20 Feb 2024 04:42:25 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v3 3/6] net: hisilicon: add support for
 hisi_femac core on Hi3798MV200
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>,
 Salil Mehta <salil.mehta@huawei.com>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Heiner Kallweit <hkallweit1@gmail.com>,
 Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20240220-net-v3-0-b68e5b75e765@outlook.com>
 <20240220-net-v3-3-b68e5b75e765@outlook.com>
 <29fc21f0-0e46-4d0f-8d4b-c4dbd1689c55@lunn.ch>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <29fc21f0-0e46-4d0f-8d4b-c4dbd1689c55@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|TYZPR06MB5074:EE_
X-MS-Office365-Filtering-Correlation-Id: 7c877b7f-7af2-4628-4c26-08dc318b4a55
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	U5oEKABdRu3idMlkEkP5FE3tlgyY+NgChJyMp9cke9CRdK5cLUT5jr+Gik4ptm0s5mEwVb7vr/CgR6CyKSwe8gznKQJRAKKdGmAA5EHOAHcMCUQeQgOmBygySdE25pwKMCydYtIewXc1mxd/grY3uqrvmn9UDEMnS7diriKWjbcUAUElye6zvJYRzIbVs0e3BScGcEG02/Iq5qIR3h0qveaD/5v2Kny7qq1Aws6KHow2PXXBaqcYyC5/iDXu2w5FqvSaZiKtFEdCUmks6sunQ/6gE6nepqtBSXY9+fstws8jZlzbeqRmZ03zfopUBozfHOpHkOonEfHojBaU/eSGXTBg4sLSuX+r2Lw+CY+yM+K12y4Adsu0qeGR3dUKrsmEMBCOroup2lsK79H0r8+N+BAa8zE+nt6/Oy7aoVYXyNLN+MXlNkxXEyQf4DZZpToF1QzKG7+iqPPHKmTIdsr5JXhxCpdJV8prSfI5mm+riOe74C4NVCiWn5znNlrNI37d66p4h7kV45OJKLAZXkXVDFMwbExLDdD+3D8TIAlfMHBDql/fo5JX5xuzFPRLVInK
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WWFEL1R0MXByVzU1VkJrZDJUYmkyNm1aUUc0bkZxeDdaS3c1ZElueS9UZm1t?=
 =?utf-8?B?SjIrT0k4aWh1U1RjWFd5bkF2ZEFuUDlCNnlDYnlOQ2piTzg5QlgycWsrLzFQ?=
 =?utf-8?B?bTFEV0xPOEp0MDA3SUkzWGlmR0RMSkhBcUdOTC9rYjlJUmg1aFpVUG1VSURp?=
 =?utf-8?B?bnJQbUNkbXJyb3AzNEJBN3VwdmhFNEVYRXJSNW5SMFZFNFRodVYwSDY4ZUpj?=
 =?utf-8?B?cGlsWUpqeFlNZmVoQ2lCQXl2T2p3TVdxaFhvRFlZQXJ6M1lYWjRtY1FITGl3?=
 =?utf-8?B?MnZUTHpwWGo1enJ2U1EyRU92cWdHNXBBSmFMSmhkbmxUUStJVUdmaFp3Nzlr?=
 =?utf-8?B?WDFWc0pkbG44YngyczlOclJKZEtTQ3ZrWnpubVZBODRuWHBUU1hCK25ITmZQ?=
 =?utf-8?B?aFk0OG1UalpaYUNjWVlmV1RZY2p2cUxQNW9pdFVBN1NLZlVma0RkdTJKVzFr?=
 =?utf-8?B?SkdsT2cybUxhOU56d1ZFODcwNkxpQTNlK1NGSFpvLzVpYzgwTjlBd3AyVmgv?=
 =?utf-8?B?VVpjVEtIa21CamMyZFRVd3FtRTladXcxemIzVlRSZ2xPMWw5MzhFcHIrSW10?=
 =?utf-8?B?dlpBRGh0T1ZHbXVlRmFJd1pQSCtvV1o5TFZ3RlZCWEFXMkdxYzRFYUNCZ2g4?=
 =?utf-8?B?NDVyY2dZYnQ2VE1IUkJRSWQrTHdIdmV2M1hhaHVlWG5Cb0ZZVmlpOUYrWEVm?=
 =?utf-8?B?V0dYQTFkdHBHb1orWkNIMTlwdmlTMzFrWXFXdEgxYjl5bjBRVU4yV09hTEhQ?=
 =?utf-8?B?NWNid2lUeHc4U0F6OUd4cGJ3RnNCSC93NVUxQlJrL250VGk1Qm5XWDFna3FJ?=
 =?utf-8?B?bEE5RHFXS2tuQ3lXcHR4MFdnbmhGd1hVM2JRU1ZsK3ExY1dReWtRcmM5cE15?=
 =?utf-8?B?MEZETUhGd25nbGFwVWpqYXkzR2lTc05sN2xHcU1NMW4vTXRKbnI5dEFzTFV2?=
 =?utf-8?B?dm9jSVUrWkNSMitqWXNOL09IZ1JPZGlXWUVDVEpUZ1N1OXgrVXhjZ3VsU3ZF?=
 =?utf-8?B?elZYTnl1eVF2WGRENHVmd0xqZXJ4ZzdGUUdsZTAxYnprYWZlY3U1V1JkdWg3?=
 =?utf-8?B?cVdReXNDR0JKWS9mMnF2aGRDeFFyQXpJM3gvZWRIQjVtUkZXZ3M1d281cGZP?=
 =?utf-8?B?Ty9SSHBYZjBZNjJEK3dnQ2NpZnNkOWdZa2FGTTh5bC9paTB6Z2J6RmZ1NFRi?=
 =?utf-8?B?K2xBeXFYSkZ6TFMxRkpkZ1VKMnRhUlhKeDZpYm9hbjcyaEIwNmpseXBzUXFX?=
 =?utf-8?B?Rm15WUhnSTV1MUt6aXJqcVN5L09sQ3hGWk92YU50WnU5YUpvRW1IUlJ0bnNh?=
 =?utf-8?B?c3JOM3NjUEVrSFdRZllrZG0zaHBuMGdvTGlwZC8yb1lIWldRMStHeFFmYzNs?=
 =?utf-8?B?ZG52SGpRYWZHRWlQcVJoVExVWktQSUY0clhNdENyZFBRVko2MUtaU0Fxekxj?=
 =?utf-8?B?aDRESllMZC93T05xT3RvbGNNaU0zVy8rQ1FwNk1iTWxkUS9IMzBYSWJ2anJG?=
 =?utf-8?B?aEh3ZDZEL25lcnJ0MjN6c3RSNlJJelRYNXpkdTAxS3BtZmdVNUlyM1N6d3B4?=
 =?utf-8?B?N2Qwa2hHMEExKzh1UzVUVEpiODhIdTZDWlFBZTBpMUcweTJFeUNsVkRpdWZp?=
 =?utf-8?B?NGFOWjV2bTBvTktETWZ3T2FadmtVbFY5V2syM2tnWWlpU2JsRDZhcWZ1TFlj?=
 =?utf-8?B?RzF3Y1V6L1hwcTZVSTczTUV0L3FUSTZ6LzBxZmdZM3A1Rit4QkxnRDlHOHdF?=
 =?utf-8?Q?z14cSjDMXcMnQ5F+VU0j1MZsiHjmfA48bgo5+M1?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c877b7f-7af2-4628-4c26-08dc318b4a55
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 20:42:29.8391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5074

On 2/20/2024 4:03 AM, Andrew Lunn wrote:
>> Note it's unable to put the MDIO bus node outside of MAC controller
>> (i.e. at the same level in the parent bus node). Because we need to
>> control all clocks and resets in FEMAC driver due to the phy reset
>> procedure. So the clocks can't be assigned to MDIO bus device, which is
>> an essential resource for the MDIO bus to work.
> What PHY driver is being used? If there a specific PHY driver for this
> hardware? Does it implement soft reset?
>
> I'm wondering if you can skip hardware reset of the PHY and only do a
> software reset.

Can we ask ethernet PHY framework to notify us (the MAC driver) when it 
is going to do the hardware reset? In that way we can add clock 
disabling/enabling code to the callback and let the PHY framework do the 
reset procedure. In this way, we can benefit a lot from PHY framework. 
E.g. make use of dt props like `reset-(de)assert-us`, rather than 
encoding these value in the MAC driver with a custom vendor property.

>
> 	Andrew


-- 
Regards,
Yang Xiwen