Received-SPF: pass (google.com: domain of linux-kernel+bounces-71990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <e9f2c716-51d3-4c03-a447-9fed357669c5@hartkopp.net>
Date: Mon, 19 Feb 2024 21:37:46 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] can: softing: remove redundant NULL check
Content-Language: en-US
To: Simon Horman <horms@kernel.org>
Cc: Daniil Dulov <d.dulov@aladdin.ru>, Wolfgang Grandegger
 <wg@grandegger.com>, Marc Kleine-Budde <mkl@pengutronix.de>,
 "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
 Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>, linux-can@vger.kernel.org,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 lvc-project@linuxtesting.org
References: <20240211150535.3529-1-d.dulov@aladdin.ru>
 <20240216172701.GP40273@kernel.org>
 <12cd0fd0-be86-4af0-8d6b-85d3a81edd2a@hartkopp.net>
 <20240219170038.GH40273@kernel.org>
From: Oliver Hartkopp <socketcan@hartkopp.net>
In-Reply-To: <20240219170038.GH40273@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Simon,

On 2024-02-19 18:00, Simon Horman wrote:
> On Fri, Feb 16, 2024 at 08:47:43PM +0100, Oliver Hartkopp wrote:
>> Hi Simon,
>>
>> I have a general question on the "Fixes:" tag in this patch:
>>
>> On 16.02.24 18:27, Simon Horman wrote:
>>> On Sun, Feb 11, 2024 at 07:05:35AM -0800, Daniil Dulov wrote:
>>>> In this case dev cannot be NULL, so remove redundant check.
>>>>
>>>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>>>
>>>> Fixes: 03fd3cf5a179 ("can: add driver for Softing card")
>>
>> IMHO this is simply an improvement which is done by all patches applied to
>> the kernel but it does not really "fix" anything from a functional
>> standpoint.
>>
>> Shouldn't we either invent a new tag or better leave it out to not confuse
>> the stable maintainers?
> 
> Hi Oliver,
> 
> sorry for missing that in my review.
> 
> Yes, I agree that this is probably not a fix, for which my
> rule of thumb is something that addresses a user-visible problem.
> So I agree it should not have a fixes tag.
> 
> I would suggest that we can just change the text to something that
> has no tag. Something like:
> 
> ...
> 
> Introduced by 03fd3cf5a179 ("can: add driver for Softing card")
> 

Yes, but the "Introduced-by:" tag would be an optional tag for people 
that like blaming others, right?

IMHO we should think about completely removing the "Fixes:" tag, when it 
has no user-visible effect that might be a candidate for stable kernels. 
It is common improvement work. And it has been so for years.

Best regards,
Oliver