Received-SPF: pass (google.com: domain of linux-kernel+bounces-72018-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID:
 <SEZPR06MB6959B40C2B486E52754C98C296512@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Tue, 20 Feb 2024 05:37:43 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC v3 4/5] phy: hisilicon: hisi-inno-phy: add support for
 Hi3798MV200 INNO PHY
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Jiancheng Xue <xuejiancheng@hisilicon.com>, Shawn Guo
 <shawn.guo@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, Kishon Vijay Abraham I <kishon@ti.com>,
 David Yang <mmyangfl@gmail.com>
References: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com>
 <20240220-inno-phy-v3-4-893cdf8633b4@outlook.com>
 <271c7f14-abbe-4922-91ea-809e50be46cd@linaro.org>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <271c7f14-abbe-4922-91ea-809e50be46cd@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|TYZPR06MB4413:EE_
X-MS-Office365-Filtering-Correlation-Id: 2df6b4a4-43e0-49fa-0222-08dc31930406
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9DWADyFCN/zhJ3uPoTtDpQgs1ru3wAIktF7Udy6g8rF3IBzrM/Ylf+aYHnJPVRfnKLMQG+PnmIDfD0zwtl42EHznSy9l57k6rwjVgQHaBjvqcUvPKSTz4nDpx9EAe7Mgc7qLwnf9etOJmp0kbuE53K2ZW1Q3uO0o47U7+dOJEGJO6gwj65SvJ34JVtwFtzPI4xRvTl5sX6UFWGzv3+4WxPgFjI1VMO2CV8kAZxGmZ2BjuyL04ctTAOk7HlpQYdgWYBCvLxMxUl6aqFicPGUbYQ5GSJcczhwgEpZlRuxTZTHR+1hMDqEdGHcUO+74R/633MrdCuTXii+uss4NB8OI82D23Ctyjrj+d8HCd5iKJone+Yc9LI4VEoSdfVHs56s0k7z/MSaE+Q62XWjvu/Chf1jyj0JMPzg+bpDMOusiFwQfgRUoyxV5JbAgbZfU+l4oDR5fpptNHrYjxG1dk0rWIwZfSp6BNP079oc29H6Ohe2to89EjKqWmVZOktralnB7KgRZu2Hee+dDBDPUWcxqqJdbxLUDy8JnF9GdbKWl+CWWm/wYWfEBFwhdZCE4R+tK
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MGtnTWJhWEJSWHZ2WXp1VEw5Wk4zZzd1OVRQQUlNNGYvaDIyVmFkWFZHMXA0?=
 =?utf-8?B?U2pKb0tqdUdWWGVtQjF4SEpLV3JJYUdJcERzcUs4MTN3TUs0b05YSlZFTi8r?=
 =?utf-8?B?R2tQS2YzMUZRLzVydXUwb1ZRTDlVMndQdm5ZVlJVNzNLandDVXF2K3FsNzVq?=
 =?utf-8?B?MTZOcFlnK3JpTWtnMTllbUdwYmJ4Uks0SG9JT0pVZ29Zdm0xWWRHVDRpUFZp?=
 =?utf-8?B?TThzRzhOemUrLzNNOTRsOUlCK2hsMnRYZG1ZU1I2azhGUTVwNVdRa3RlS2wz?=
 =?utf-8?B?N1RkKzFEUUZIZTdRTG5iY1htUTRWVVlIdjUzNTBPQjhKU3YreWtYVHJwaVFR?=
 =?utf-8?B?dmtsYnJMc3kvdytXQmdFd0xmQzg0cUlNMkZhNG05akR3UkJYSEtEZ0NWSEwz?=
 =?utf-8?B?d213djMwRkRXdGljQ1Zrbk15ZjY5ZHpYdEJKU3V3a0xpRFMrUUJ5bXN5YXQ1?=
 =?utf-8?B?TkhsSXViYTV0Q2g1RDF2cWFjY2lQcG9SMlFWWVhDNjI5dGVIWExGT28ycjYy?=
 =?utf-8?B?RzhMeFZtbC83a3cyMmhUVXNZZlF3Z1I5aHNQb25vQTBycFpEbDBXdHhGRTIw?=
 =?utf-8?B?QnpOR0tOQmFxN0lIOW5BYVNlRGZ0SklmRWgrN3FsWFVsd3lSQ21XUGNYSmpl?=
 =?utf-8?B?KzgxZDllV1gvbjY4R3ZUN00zVGl6ekl1NmNocExNcm1EaHZlK2ZPWGdkQldE?=
 =?utf-8?B?WjkvMjZUSE9PYWFQR2NuKzF3VEVxa00wc0Y1dDd4dVF6SzFLNy9wV09pUW5W?=
 =?utf-8?B?MWZqVWlCNE9OZ2RYVnNPR3cvYnhhQmZya1oyUWswQXZMSUFwVGU0anBpY1Bt?=
 =?utf-8?B?RXU5Rnl0MkRkclRQMTRoV28wbWYrZGFNbG0xaExqZXZ1d1hIaVcxbXd0NEcv?=
 =?utf-8?B?ZTNxUEk5aGprZUIxdU1RRHRpWmdHaUxXb0xtQjVBWURadWEyREVCTm9xbG5Z?=
 =?utf-8?B?RE1naUMyR0VEVi9DWUFWMUJPMWFrWUV5VHBkMllaOTFJZkpvTlRWa2oxd1V4?=
 =?utf-8?B?RUFHT3FBa1djRk5DczIrYW9hVkdIVHdzLzZmaGNhb2dudkw4aEJUQ0xmek5j?=
 =?utf-8?B?ZnlkRmphakxXTWpQY24xWEpld2NxTnJUbWxVYS9uSmtLWnJ1K0hITVRqdDhz?=
 =?utf-8?B?SE9qcis0RjlWdXgzb24vVkZITllNZHZzV1EvVkZ2QklQNjVxeEdwUEE2cE4z?=
 =?utf-8?B?Mm5ZTWFGdk9XMG1JRmM0RGxFQ0lmZFBRSEdqN2FEWTlLQzRrcENqNVVFd0Zp?=
 =?utf-8?B?U1k2eVpXcmxpb2F1d2JicHpRVERSN2wvdUZWciswRi8yNENQVnFkTlVBdHRh?=
 =?utf-8?B?QzY2anE5ZDI0UmR0NHUwOWlaR1FiOUxmNlNWVkpzaU91RW5xbTN6TytPTTNP?=
 =?utf-8?B?Y3N5aW5JcGI5b0tlWEsxU3FraytOcFlmNlM5OHlYc3VGLzQ0VlNQd0xqK0s5?=
 =?utf-8?B?U1A3Yjh5dDNGbGk2clJjeFNNUEZBRTJGVnpwVGxYR1B1K1hySEZjeXMrcUZn?=
 =?utf-8?B?YzdWaHZBQ3dpdzErR1B4YkRvK29MV0liQTNzSlV3dXB1eVpjVUJlcVQ5SWow?=
 =?utf-8?B?aXdlT1ZpUlIwazdsTmljZUovUDN6djB0Ymd6MlNWb21ZVmwyUm1TRlYwY0Fs?=
 =?utf-8?B?N1F3UGtWeTc1TE54RkczOThQQnZYMUFHMDVDWHN2a2xkYXRmQ1djcStPUnl3?=
 =?utf-8?B?bUJKTGdqZHZGU2NVTUcra2tSNXNNQlY5WnBpTmJucE1SdzR3dWd3cXpTN1pK?=
 =?utf-8?Q?GS/UJfob8fOJqorfeXIbuANa2d1lUD8aa//dYmc?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2df6b4a4-43e0-49fa-0222-08dc31930406
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 21:37:47.8471
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4413

On 2/20/2024 5:34 AM, Krzysztof Kozlowski wrote:
> On 19/02/2024 22:28, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@outlook.com>
>>
>> Direct MMIO resgiter access is used by Hi3798MV200. For other models,
>> of_iomap() returns 0 due to insufficient length. So they are unaffected.
>>
>> Also Hi3798MV200 INNO PHY has an extra reset required to be deasserted,
>> switch to reset_control_bulk_() APIs to resolve this.
>>
>> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
>> ---
>>   drivers/phy/hisilicon/phy-hisi-inno-usb2.c | 65 ++++++++++++++++++------------
>>   1 file changed, 39 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
>> index b7e740eb4752..5175e5a351ac 100644
>> --- a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
>> +++ b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
>> @@ -10,6 +10,7 @@
>>   #include <linux/io.h>
>>   #include <linux/module.h>
>>   #include <linux/of.h>
>> +#include <linux/of_address.h>
>>   #include <linux/phy/phy.h>
>>   #include <linux/platform_device.h>
>>   #include <linux/reset.h>
>> @@ -43,6 +44,7 @@
>>   #define PHY_CLK_ENABLE		BIT(2)
>>   
>>   struct hisi_inno_phy_port {
>> +	void __iomem *base;
>>   	struct reset_control *utmi_rst;
>>   	struct hisi_inno_phy_priv *priv;
>>   };
>> @@ -50,7 +52,7 @@ struct hisi_inno_phy_port {
>>   struct hisi_inno_phy_priv {
>>   	void __iomem *mmio;
>>   	struct clk *ref_clk;
>> -	struct reset_control *por_rst;
>> +	struct reset_control *rsts;
> This does not look related to this patch at all.
I should emphasize this in commit log. Hi3798MV200 have two resets 
rather than one. To make things easier, I simply used 
reset_control_array APIs instead.
>
>>   	unsigned int type;
>>   	struct hisi_inno_phy_port ports[INNO_PHY_PORT_NUM];
>>   };
>
>
> Best regards,
> Krzysztof
>

-- 
Regards,
Yang Xiwen