Received-SPF: pass (google.com: domain of linux-kernel+bounces-72188-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <b606216c-dae9-4bd9-a1a8-91bce67c211b@intel.com>
Date: Tue, 20 Feb 2024 09:43:40 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dmaengine: idxd: Ensure safe user copy of completion
 record
Content-Language: en-US
From: Lijun Pan <lijun.pan@intel.com>
To: Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>, "Dave
 Jiang" <dave.jiang@intel.com>
CC: <dmaengine@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>,
	Tony Zhu <tony.zhu@intel.com>
References: <20240209191412.1050270-1-fenghua.yu@intel.com>
 <4237a933-0f61-417f-bbb6-ce5954b304d4@intel.com>
In-Reply-To: <4237a933-0f61-417f-bbb6-ce5954b304d4@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGUxaERyT3NyQzRHZHBKd3dCbUdDcUZQRzZZN0RORTlVaGgrMXdTUUQxblRj?=
 =?utf-8?B?dXd3UnNXbE5GT2JXMTJrUkJBTGhnOWs0WDFlcnd5NDNmV2ZTK3p0NzlzcDBY?=
 =?utf-8?B?ejAwRmtKM3NYWmg5NUNVbUdxaE9WY0JjMXA3Tm0rWmNLbkl4SHpZQVpGUGZF?=
 =?utf-8?B?dWdtZE1kNlZ4NEF5VFJ5a2h0ZTM1aS9PeE53dlRtUmFsUk1MWG92NUEwQ3Rm?=
 =?utf-8?B?QW4zaTJXL3RiRlp2Q0UrVHlkVGowSDlPUWxaeE1YVXlhZDdZSVoxREVMd0hU?=
 =?utf-8?B?bitVT0pjRWwraVVqUlUva3VYZkhzbEFOelhlYW9lMGx1S2pUbjZpRkFVYjN1?=
 =?utf-8?B?blFQblBCK2JjblRUMGRXaEVlTDhyTzA4YzY0anJkdzU5REFtS0h1OTljc2R4?=
 =?utf-8?B?aHVnWi8rOWhYeVFabnl3b2h1NVhGaklkZ3lQa1BNMkRXMEZhbmxBTlVJcFNk?=
 =?utf-8?B?VlprV3JiNzBVRlh2cytvaVFtZWxKa0hQQlRENHRzK1VRdDJJeTJUZFdHR29O?=
 =?utf-8?B?R3RzRlN5NjljWUc0b1VhMDFNY1htbWh0dHBXQ1M3aTZlcXlsZDhmdy9QbE5D?=
 =?utf-8?B?VHZkTmxEUWx3MTl3QmFidG1qaVVDZG5scXRKVjRLd2J5NlBlYjJBRGFsV1ZM?=
 =?utf-8?B?a3YzSms3RUNzRUR4SjkySUJaUThhaVNnZytqRmtjNWpNNTNHUHFWNnFWOVpt?=
 =?utf-8?B?b1ZQZ3p4Q3F5akJjdXk4MVlLZ3hINi80TXlBN1VMNFZDeTdRRlpwb2NQeXg5?=
 =?utf-8?B?OTRQZ3d1bGpoNVV0dEFzMlAwR0RaM2dUWlpJc1N5c3JVZy9hMGVQY09PMHJW?=
 =?utf-8?B?Zkc2czdmcCsrUGVDampuQXczRm9WMTlubUVIc2N6WTdob3NmSFJVWlI1RmJS?=
 =?utf-8?B?RVFySldGZ3JDcEtuTFBLSXhVa0x5NFUxT1BYZkxtUUZwQnRtZ2N4N2owbitH?=
 =?utf-8?B?RUN4N3dkV1pWV090TVRMbkxlbzJPUkNSQnRncGVmTDB0RFdFYU8rU3hweUZG?=
 =?utf-8?B?SElhd3NxQS96LzltNEtpQWgvUGx4cG1MV2VHZ0xZYnAzYjBudms4SnVyb1N3?=
 =?utf-8?B?REpoeDVhVm9TNzgxSEN3Zy9vSWhvZ2tmZG85LzlBM3hua2NXZEIrVmhCKzNt?=
 =?utf-8?B?Y3BVQnl5bkhKZHpkTzJTWGhPY0lDOE5NdDVMMkZ6L3B1V3FVTE9lRGUyNkdR?=
 =?utf-8?B?N20rVnpVRkhoNWxqZHFiUUhCUm8xdjVQcWZqSWx2YVdCMXFpWjNuVGd6ejk3?=
 =?utf-8?B?dGRjL01RaThLV3MwY3djblBIUEs4Rmw2aWhKNXpLcTN1SVcxS1JqOU9RTklV?=
 =?utf-8?B?a0RvU1hwUjQvb0gwcmJmNmxLekpuUERpTVBVYXlBTThObnRyVVROdUx5MFQx?=
 =?utf-8?B?TmFoNm9CRUNqMlJlZEtocUdTREpaTkJaWEY5OVcxZDhyeFRkNnlEbXdIL0Vs?=
 =?utf-8?B?UndVVjhWSytsWXRWd0JVeGV3dUtRdmxoUlRoT1RmdjJwdG9rT0JXN00wUytq?=
 =?utf-8?B?cWFrWTQ5T2NGS2p5cVc3Wjd2ZndqTWdGSHl1cnhVZEdKVmlkUjhET2xnaThj?=
 =?utf-8?B?MU5sUXFoT0VnUStBSFNBYzIwYVVwRTZWVGN1bDVVcmowdFJ4NEQ4UVpUU0Vz?=
 =?utf-8?B?WUpHR0JYdXRhYWFmcGRlbkRZQnZTbHZ1VDVYZkNRS0Jpa3U0NURCZ2pIMExH?=
 =?utf-8?B?elNyQjZiNkNMTlBFcmFtdjFOaHArNzlnTkVLTlExL2c0c080Qms0ODAvcytM?=
 =?utf-8?B?M205c1FiOXN0UktkMHdXNStPMVhlN3Nad2hjMTRSSCtkZlBIQk9FUVkrd1Jv?=
 =?utf-8?B?QUx5aFJUTnJITWxXQW1YWGowcXExT0VoM0NSUFNmUWowS0tCTDBiaDQvcnNL?=
 =?utf-8?B?OHpBaW15b3dtdndoeDFCcVdHbTZpZVN2T3RuRVhiTjdsSmUrd256TzRyaXlt?=
 =?utf-8?B?am9vcHdzYU83a3lUdk9hOEwrTzdrbzUwQk9MdjFWNk9YTEp2dEdidHErSkZU?=
 =?utf-8?B?YzYxTG1xZTNyWXFDQ2NibWVyYUVLMnlXTUl2VUlUSGM2N2tzRWQ3OVUrVlhK?=
 =?utf-8?B?bE50U0JYeWZUYjB0ekFaVVNtNitaUjFYbm5BRjEzaVFxeWFCU1phVTJBOHVu?=
 =?utf-8?Q?7zEMe3lvhaOjqM6GEN/ydXnsy?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 378442f8-1e88-4c1c-e5fb-08dc31b55f0e
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB7141.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 01:43:43.6170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ol5R/K7r5fPoWx8+8vWIUF4ExMjqduUVJ7PDmStTwD5j/18rDX97kcUX5w8qdqZhoJ81N0w02Kh/sTCLaavdgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5351
X-OriginatorOrg: intel.com


On 2/10/2024 5:53 AM, Lijun Pan wrote:
> 
> 
> On 2/10/2024 3:14 AM, Fenghua Yu wrote:
>> If CONFIG_HARDENED_USERCOPY is enabled, copying completion record from
>> event log cache to user triggers a kernel bug.
>>
>> [ 1987.159822] usercopy: Kernel memory exposure attempt detected from 
>> SLUB object 'dsa0' (offset 74, size 31)!
>> [ 1987.170845] ------------[ cut here ]------------
>> [ 1987.176086] kernel BUG at mm/usercopy.c:102!
>> [ 1987.180946] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
>> [ 1987.186866] CPU: 17 PID: 528 Comm: kworker/17:1 Not tainted 
>> 6.8.0-rc2+ #5
>> [ 1987.194537] Hardware name: Intel Corporation AvenueCity/AvenueCity, 
>> BIOS BHSDCRB1.86B.2492.D03.2307181620 07/18/2023
>> [ 1987.206405] Workqueue: wq0.0 idxd_evl_fault_work [idxd]
>> [ 1987.212338] RIP: 0010:usercopy_abort+0x72/0x90
>> [ 1987.217381] Code: 58 65 9c 50 48 c7 c2 17 85 61 9c 57 48 c7 c7 98 
>> fd 6b 9c 48 0f 44 d6 48 c7 c6 b3 08 62 9c 4c 89 d1 49 0f 44 f3 e8 1e 
>> 2e d5 ff <0f> 0b 49 c7 c1 9e 42 61 9c 4c 89 cf 4d 89 c8 eb a9 66 66 2e 
>> 0f 1f
>> [ 1987.238505] RSP: 0018:ff62f5cf20607d60 EFLAGS: 00010246
>> [ 1987.244423] RAX: 000000000000005f RBX: 000000000000001f RCX: 
>> 0000000000000000
>> [ 1987.252480] RDX: 0000000000000000 RSI: ffffffff9c61429e RDI: 
>> 00000000ffffffff
>> [ 1987.260538] RBP: ff62f5cf20607d78 R08: ff2a6a89ef3fffe8 R09: 
>> 00000000fffeffff
>> [ 1987.268595] R10: ff2a6a89eed00000 R11: 0000000000000003 R12: 
>> ff2a66934849c89a
>> [ 1987.276652] R13: 0000000000000001 R14: ff2a66934849c8b9 R15: 
>> ff2a66934849c899
>> [ 1987.284710] FS:  0000000000000000(0000) GS:ff2a66b22fe40000(0000) 
>> knlGS:0000000000000000
>> [ 1987.293850] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> [ 1987.300355] CR2: 00007fe291a37000 CR3: 000000010fbd4005 CR4: 
>> 0000000000f71ef0
>> [ 1987.308413] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 
>> 0000000000000000
>> [ 1987.316470] DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 
>> 0000000000000400
>> [ 1987.324527] PKRU: 55555554
>> [ 1987.327622] Call Trace:
>> [ 1987.330424]  <TASK>
>> [ 1987.332826]  ? show_regs+0x6e/0x80
>> [ 1987.336703]  ? die+0x3c/0xa0
>> [ 1987.339988]  ? do_trap+0xd4/0xf0
>> [ 1987.343662]  ? do_error_trap+0x75/0xa0
>> [ 1987.347922]  ? usercopy_abort+0x72/0x90
>> [ 1987.352277]  ? exc_invalid_op+0x57/0x80
>> [ 1987.356634]  ? usercopy_abort+0x72/0x90
>> [ 1987.360988]  ? asm_exc_invalid_op+0x1f/0x30
>> [ 1987.365734]  ? usercopy_abort+0x72/0x90
>> [ 1987.370088]  __check_heap_object+0xb7/0xd0
>> [ 1987.374739]  __check_object_size+0x175/0x2d0
>> [ 1987.379588]  idxd_copy_cr+0xa9/0x130 [idxd]
>> [ 1987.384341]  idxd_evl_fault_work+0x127/0x390 [idxd]
>> [ 1987.389878]  process_one_work+0x13e/0x300
>> [ 1987.394435]  ? __pfx_worker_thread+0x10/0x10
>> [ 1987.399284]  worker_thread+0x2f7/0x420
>> [ 1987.403544]  ? _raw_spin_unlock_irqrestore+0x2b/0x50
>> [ 1987.409171]  ? __pfx_worker_thread+0x10/0x10
>> [ 1987.414019]  kthread+0x107/0x140
>> [ 1987.417693]  ? __pfx_kthread+0x10/0x10
>> [ 1987.421954]  ret_from_fork+0x3d/0x60
>> [ 1987.426019]  ? __pfx_kthread+0x10/0x10
>> [ 1987.430281]  ret_from_fork_asm+0x1b/0x30
>> [ 1987.434744]  </TASK>
>>
>> The issue arises because event log cache is created using
>> kmem_cache_create() which is not suitable for user copy.
>>
>> Fix the issue by creating event log cache with
>> kmem_cache_create_usercopy(), ensuring safe user copy.
> s/, ensuring/ to ensure

It is not a big deal if you really want keep original wording.

Lijun

> 
> 
> 
>>
>> Fixes: c2f156bf168f ("dmaengine: idxd: create kmem cache for event log 
>> fault items")
>> Reported-by: Tony Zhu <tony.zhu@intel.com>
>> Tested-by: Tony Zhu <tony.zhu@intel.com>
>> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> 
> Reviewed-by: Lijun Pan <lijun.pan@intel.com>
>