From: Robin Getz <rgetz@blackfin.uclinux.org>
Organization: Blackfin uClinux org
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Subject: Re: [2.6.24 patch] restore blackfin HARDWARE_PM support
Date: Sat, 29 Dec 2007 01:14:46 -0500
User-Agent: KMail/1.9.5
Cc: Adrian Bunk <bunk@kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
       Randy Dunlap <randy.dunlap@oracle.com>, bryan.wu@analog.com,
       linux-kernel@vger.kernel.org
References: <20071228185643.GB4738@stusta.de> <20071228192320.GI6780@does.not.exist> <20071228192855.GA23157@Krystal>
In-Reply-To: <20071228192855.GA23157@Krystal>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200712290114.46694.rgetz@blackfin.uclinux.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2607
Lines: 71

On Fri 28 Dec 2007 14:28, Mathieu Desnoyers pondered:
> * Adrian Bunk (bunk@kernel.org) wrote:
> > On Fri, Dec 28, 2007 at 02:14:04PM -0500, Mathieu Desnoyers wrote:
> > > * Adrian Bunk (adrian.bunk@movial.fi) wrote:
> > > > This patch restores the blackfin Hardware Performance Monitor Profiling 
> > > > support that was killed by
> > > > commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
> > > > 
> > > > Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
> > > > 
> > > 
> > > Yep, this one too must be put back, but kernel/Kconfig.instrumentation
> > > seems like the wrong spot for a blackfin-specific config option (and
> > > this will break the instrumentation menu removal patches in -mm).
> > > 
> > > Can we put this in arch/blackfin/Kconfig instead ?
> > 
> > No, this is a user visible option that belongs into the same menu as
> > "Profling support".
> > 
> 
> Actually, I wonder why these options exist at all rather than being on
> by default when profiling is enabled. There is no such thing as
> "activating the performance monitor profiling" on other architectures.
> What is so special about blackfin that makes it need it ?

This is probably more historical, and you are correct - it should just be part of profiling.


> > > > ---
> > > > 
> > > >  kernel/Kconfig.instrumentation |    9 +++++++++
> > > >  1 file changed, 9 insertions(+)
> > > > 
> > > > 942996f33f81726c5edb012d61ecdad70c55884d 
> > > > diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation
> > > > index 97c76ca..e023671 100644
> > > > --- a/kernel/Kconfig.instrumentation
> > > > +++ b/kernel/Kconfig.instrumentation
> > > > @@ -44,2 +44,11 @@ config OPROFILE_MPCORE
> > > >  
> > > > +config HARDWARE_PM
> > > > +	tristate "Hardware Performance Monitor Profiling"
> > > > +	depends on BLACKFIN && PROFILING
> > > > +	help
> > > > +	  take use of hardware performance monitor to profiling the kernel
> > > > +	  and application.
> > > > +
> > > > +	  If unsure, say N.
> > > > +
> > > >  config KPROBES
> > > > 
> > > 
> > > Mathieu Desnoyers
> > 
> > cu
> > Adrian
> > 
> > -- 
> > 
> >        "Is there not promise of rain?" Ling Tan asked suddenly out
> >         of the darkness. There had been need of rain for many days.
> >        "Only a promise," Lao Er said.
> >                                        Pearl S. Buck - Dragon Seed
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/