Received-SPF: pass (google.com: domain of linux-kernel+bounces-72199-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 19 Feb 2024 18:06:17 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Zi Yan <ziy@nvidia.com>
Cc: Zi Yan <zi.yan@sent.com>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, "Huang, Ying" <ying.huang@intel.com>, Ryan
 Roberts <ryan.roberts@arm.com>, "Matthew Wilcox (Oracle)"
 <willy@infradead.org>, David Hildenbrand <david@redhat.com>, "Yin, Fengwei"
 <fengwei.yin@intel.com>, Yu Zhao <yuzhao@google.com>, Vlastimil Babka
 <vbabka@suse.cz>, "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
 Johannes Weiner <hannes@cmpxchg.org>, Baolin Wang
 <baolin.wang@linux.alibaba.com>, Kemeng Shi <shikemeng@huaweicloud.com>,
 Mel Gorman <mgorman@techsingularity.net>, Rohan Puri
 <rohan.puri15@gmail.com>, Mcgrof Chamberlain <mcgrof@kernel.org>, Adam
 Manzanares <a.manzanares@samsung.com>, "Vishal Moola (Oracle)"
 <vishal.moola@gmail.com>
Subject: Re: [PATCH v6 0/4] Enable >0 order folio memory compaction
Message-Id: <20240219180617.89a0daaba45ce124ef01be50@linux-foundation.org>
In-Reply-To: <20240216170432.1268753-1-zi.yan@sent.com>
References: <20240216170432.1268753-1-zi.yan@sent.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 16 Feb 2024 12:04:28 -0500 Zi Yan <zi.yan@sent.com> wrote:

> Baolin's patch

Baolin writes many patches and patches have names, please use them!

> on nr_migratepages was based on this one, a better fixup
> for it might be below. Since before my patchset, compaction only deals with
> order-0 pages.

I don't understand what this means.  The patchset you sent applies OK
to mm-unstable so what else is there to do?

> diff --git a/mm/compaction.c b/mm/compaction.c
> index 01ec85cfd623f..e60135e2019d6 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1798,7 +1798,7 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data)
>  	dst = list_entry(cc->freepages.next, struct folio, lru);
>  	list_del(&dst->lru);
>  	cc->nr_freepages--;
> -	cc->nr_migratepages -= 1 << order;
> +	cc->nr_migratepages--;
>  
>  	return dst;
>  }
> @@ -1814,7 +1814,7 @@ static void compaction_free(struct folio *dst, unsigned long data)
>  
>  	list_add(&dst->lru, &cc->freepages);
>  	cc->nr_freepages++;
> -	cc->nr_migratepages += 1 << order;
> +	cc->nr_migratepages++;
>  }